Received-SPF: pass (google.com: domain of linux-kernel+bounces-103681-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
References: <20240223192658.45893-1-rrameshbabu@nvidia.com>
 <20240309084440.299358-1-rrameshbabu@nvidia.com>
 <20240309084440.299358-7-rrameshbabu@nvidia.com>
 <20240312165544.75ced7e1@kernel.org> <87plvxbqwy.fsf@nvidia.com>
 <20240313174707.38a71c84@kernel.org> <87ttl9fhyd.fsf@nvidia.com>
 <20240314110553.1c5310c9@kernel.org>
User-agent: mu4e 1.10.8; emacs 28.2
From: Rahul Rameshbabu <rrameshbabu@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: ahmed.zaki@intel.com, aleksander.lobakin@intel.com,
 alexandre.torgue@foss.st.com, andrew@lunn.ch, corbet@lwn.net,
 davem@davemloft.net, dtatulea@nvidia.com, edumazet@google.com,
 gal@nvidia.com, hkallweit1@gmail.com, jacob.e.keller@intel.com,
 jiri@resnulli.us, joabreu@synopsys.com, justinstitt@google.com,
 kory.maincent@bootlin.com, leon@kernel.org, linux-doc@vger.kernel.org,
 linux-kernel@vger.kernel.org, liuhangbin@gmail.com,
 maxime.chevallier@bootlin.com, netdev@vger.kernel.org, pabeni@redhat.com,
 paul.greenwalt@intel.com, przemyslaw.kitszel@intel.com,
 rdunlap@infradead.org, richardcochran@gmail.com, saeed@kernel.org,
 tariqt@nvidia.com, vadim.fedorenko@linux.dev, vladimir.oltean@nxp.com,
 wojciech.drewek@intel.com
Subject: Re: [PATCH RFC v2 6/6] tools: ynl: ethtool.py: Output timestamping
 statistics from tsinfo-get operation
Date: Thu, 14 Mar 2024 11:39:56 -0700
In-reply-to: <20240314110553.1c5310c9@kernel.org>
Message-ID: <87o7bgveni.fsf@nvidia.com>
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?0wCi5ozJ5S18kJGnuKC9HxqKLEtLipWGp+LEoaCFPQJBMiMUyWzMMJE+iT2Y?=
 =?us-ascii?Q?mzSOYweYi1IxDc2jNkmHZOMFHdvZQD0/z4ew5d7cGLjP5vpuAAtr5iDrGcaL?=
 =?us-ascii?Q?yRd1DuTWDsBiPhvtENqK4+XdGy7HxQFoy7mWd2E6Zmxzuh06yUqjeIh8ZdZs?=
 =?us-ascii?Q?1vuqpy52R8mR82vM6ZM0nVve4L62pI1XQbkVvt1kkxbuaKmtJZY0OlBuVI9n?=
 =?us-ascii?Q?SLoxY4HVnlZJROOP6myZrQqjmxUcTloS7Skms8JGGBWJMz6AprIPx5OOUNUj?=
 =?us-ascii?Q?D/Otn+IZ4zA/FCXi3WCFMwKH+ZWZEemMRlYeaqvYzKH4xbpVtaBBuiki+D8U?=
 =?us-ascii?Q?By8IOqWeAaw/+H6KMHv7KDwm18c2ZNWOlkivl2+zXiGOo6qgvTo5C519msI/?=
 =?us-ascii?Q?uCuT7tlI2tSgB0D0nUbO1H+sxJRIUzAzNWqTY3d6KcIpXu2DeMD7qmNACnN2?=
 =?us-ascii?Q?si2bRODM8ImwGuehGyQEBU+4omR1/wG2ZfQdOILWqOx8v+05Su32uPKc0h4t?=
 =?us-ascii?Q?InqXVlhKKWjB1A3UfGNiFEWm9A39PaSe3N9jpM1ipmAeVVjYgRH8AkwnbH0b?=
 =?us-ascii?Q?lFzyfPuihBl+KFZJLsvUOPvdxESnhIS1ZbIbG85VHCXRbE98hxhVK2GynGUr?=
 =?us-ascii?Q?XLaTXvjyTjIuDaSvqeQ5NnbC/viuwZKz6caUUdHV//xXAt+U5Sw4f4Ag7Pha?=
 =?us-ascii?Q?wlHNunRzgt+LlP4zso329pdbNUtupDnGTrkFUi3E6GnH7D0uqObD9hJpYuEm?=
 =?us-ascii?Q?UDXkW5FBAsUB7nrnqXrDcxyy+rYP8jxZJn/jxIBXTtOvi411QSUFfJ0cnnXw?=
 =?us-ascii?Q?7weKYFxidQSeHwcBSmJr8ZyqkMXt2eDArwm9h3D5i5zH/M4mGwkbS9kSD7x5?=
 =?us-ascii?Q?5KSyx4IBr2bdt/Ot7qqKSxuKhQ5GQoNINNs5ATRzTyUsbWTUuaCxi5zlMxcw?=
 =?us-ascii?Q?ZcF6X/xHmh/XSE6axQVl75QEe4avjimZi+4nMTVOfgXHDnz+qXyO+0WpF4BM?=
 =?us-ascii?Q?5KAP4gHsxkyfV6EK0AfD1Nyiy8y52P0GAjEKf7Vb7+/Qcg//DZxXeeR/oWqt?=
 =?us-ascii?Q?UQ+lx0FoqNj6pBGekC+VPlIWUjqsi6RSMEZ7Cd6Z45NYvNrRU6mLzKKSueyj?=
 =?us-ascii?Q?bj+dw49s5h9/yZ0jYN2aVZ911NfyT2wXxOg/XBzldK70/1nekM6F92MIsTcW?=
 =?us-ascii?Q?Ndgtu1qE/KLaHvROaDGAPLPUlPaKW21gcDvT2fFjKTemc0ssKbCi9Wd6LxdN?=
 =?us-ascii?Q?upuPwoTXQWhceNkmT9zyqPobzU1dl6reMkhvMmKRLD7aBQHsZJO81EUGIQJI?=
 =?us-ascii?Q?/AklmpjjfbJl+m0p97w6bucsJkAjNSRxlMIvHamKfIBBVxn8bx2n4YhRzn5F?=
 =?us-ascii?Q?/vAyopoMznNyUT4Q0jgoJxnk831mKl44w8KKeB0Azc5yDKsfjmC56+2oLJ9q?=
 =?us-ascii?Q?RPNzqSc4I8Jea5f9YswiDNQ5f8eyg7hafvEjVI92p9PeiXBZu2aiN4kp2HWj?=
 =?us-ascii?Q?0nHpRny4sFkwf2440bxa1Ntmi1W90LNJctdSETbsGBOyhaQDL5hHpaIDFvQJ?=
 =?us-ascii?Q?cMRfYgBvkboqBg/qERUMauj6qLjM+Nzr+ZhIfuFK8xN49FXqwi4up5YYQpAP?=
 =?us-ascii?Q?UQ=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e8f8b4d6-ffff-4f58-b399-08dc44567e73
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2743.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 18:42:26.0460
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: glnG0juCMLMFJj178jn+AGz+QYgtW4OPStFnMJdJ76rVMKIQ0qyB/FbjwvDWWjyzgH89QW9N5qscR51vO1w5mg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8817


On Thu, 14 Mar, 2024 11:05:53 -0700 Jakub Kicinski <kuba@kernel.org> wrote:
> On Wed, 13 Mar 2024 23:07:22 -0700 Rahul Rameshbabu wrote:
>> What's your expectation for how the request structure would look like? I
>> have tried the following.
>> 
>>   if args.show_time_stamping:
>>       req = {
>>         'header': {
>>           'flags': 'stats',
>>         },
>>       }
>> 
>>   if args.show_time_stamping:
>>       req = {
>>         'header': {
>>           'flags': {
>>              'stats': True,
>>           },
>>         },
>>       }
>> 
>> I tried looking through the lib/ynl.py code, but I did not understand
>> how the 'flags' type was specifically handled.
>
> Rebased on latest net-next?

Thanks, I was using our internal branch that mixes net-next with some of
our mlx5 changes for verification purposes, and it was not rebased to
latest net-next. Your suggestion works as expected with latest net-next
and will be integrated into the series (with the suggested-by trailer
added).

>
> I used this:
>
> ./tools/net/ynl/cli.py \
> 	--spec Documentation/netlink/specs/ethtool.yaml \
> 	--do fec-get --json '{"header":{"dev-index": 2, "flags": "stats"}}'

--
Thanks,

Rahul Rameshbabu