Received: by 2002:ab2:2994:0:b0:1ef:ca3e:3cd5 with SMTP id n20csp310310lqb;
        Thu, 14 Mar 2024 11:50:50 -0700 (PDT)
X-Forwarded-Encrypted: i=3; AJvYcCUrNR0qwKOrknUa5a+P8zjB7X0uDzVoRFDk4DGBHFYMs1WQhdNPd7/X9zQOF+KFCJEm/BuXfLez8HZ9aMZEbAePGlAMsQ7ZRIaE8EwxvQ==
X-Google-Smtp-Source: AGHT+IHJxSxKqRDADSj34n0kSPGhqhU3BvUFLiHsxXyFfzS5T9UTUtRWbN5sAOrI2tHVqp8vvwUf
X-Received: by 2002:a05:6a20:b926:b0:1a3:48ba:a25c with SMTP id fe38-20020a056a20b92600b001a348baa25cmr1032218pzb.61.1710442250662;
        Thu, 14 Mar 2024 11:50:50 -0700 (PDT)
ARC-Seal: i=2; a=rsa-sha256; t=1710442250; cv=pass;
        d=google.com; s=arc-20160816;
        b=wXsmJ3906SOOrK8y1E1a5P5xRhb0Ncl3aMy+9OtIesTDmCBZ4QXKX6xHBOPJQoJyhw
         faD5ug7fDZsrbYvyubwA7c5GRDxA9Rjl0Radyn7tEhh+NiSPFdGtL2CXGsA2oAOX+QrS
         BJy+EJCx1TjFeEae01evPGBw4Kq8Yyy87yUYenGUthnN34TBBQQDnG2T9RrSpW2Pi1/g
         bhnpzw+p5iyKn9DTq4jMsxtUwzytZ/Bs7CKMczJ+hfsP4oi6sZAfje8QlEvr0HK6WYYI
         5lweRKOQ5fAWKfmhnvb/y6SWpU5WYGGkhTH2H8uHE4fu43RPXdYicQ3wsJ5fuPLZ4ZsZ
         tjrA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=content-transfer-encoding:mime-version:list-unsubscribe
         :list-subscribe:list-id:precedence:references:in-reply-to:message-id
         :subject:cc:to:from:date:dkim-signature;
        bh=pb0vIzbYslsxt10rHOb4hxaHicDLWDRrEaXbbtynnbc=;
        fh=S4dYgODkiFYejWs5AYwa/oyj+Xs18Ln4YbEig7O0OO8=;
        b=zo+c4PMALg5RJA7uD0z9tBY/EM1gKIIUMFilwZp3bJWAr0lk2s2cQxQgBjqEWt7B2c
         u3BqW7YDsbHgKS8zZ/sWiLCJMa319ykSsQhQYTLCXKHUxDB8DYWdwMlFzxmFAM611aMv
         u/pSxulLBjfYq75JxY5FYEQpZ3XNohHXr+cN1X3qMYv5TEGEgxxsMwA4bejLsce2xaQv
         VaEv8kuInAlw6B73BiI61vycozsFxmtjvCGkjH/rAPYEORIbVCQiXzYFE23LR4lWh/sS
         XnWYRaGUyZg7I3+9lzeJXLriFL13g9bftoiTA59zs5jgsaVPoxVkOj/Ghr9Jkp20fyJC
         S1yw==;
        dara=google.com
ARC-Authentication-Results: i=2; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FgvF2cyB;
       arc=pass (i=1 dkim=pass dkdomain=kernel.org);
       spf=pass (google.com: domain of linux-kernel+bounces-103692-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-103692-linux.lists.archive=gmail.com@vger.kernel.org";
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel+bounces-103692-linux.lists.archive=gmail.com@vger.kernel.org>
Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161])
        by mx.google.com with ESMTPS id q3-20020a63d603000000b005dc3e746573si1143337pgg.826.2024.03.14.11.50.50
        for <linux.lists.archive@gmail.com>
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Thu, 14 Mar 2024 11:50:50 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel+bounces-103692-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FgvF2cyB;
       arc=pass (i=1 dkim=pass dkdomain=kernel.org);
       spf=pass (google.com: domain of linux-kernel+bounces-103692-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-103692-linux.lists.archive=gmail.com@vger.kernel.org";
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by sy.mirrors.kernel.org (Postfix) with ESMTPS id EDACAB21682
	for <linux.lists.archive@gmail.com>; Thu, 14 Mar 2024 18:50:37 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 6B7AF7604D;
	Thu, 14 Mar 2024 18:49:58 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FgvF2cyB"
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85D0873509;
	Thu, 14 Mar 2024 18:49:57 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1710442197; cv=none; b=dnl0WZY1BGUQufqKISVR+Aq6uYhnalu22DhdmaT1/mtrjRouDg0s0AJSprMcxWQzZDXEQHKB9NB4lgQJEvzxWI9qm9ckAm3+zHrBEBCVvbTVWqvSKhwvxQZCIU1Yq8ieFYJjdD2Ugi0BnFPr3f7xpbYI+xzmmLxX+EqiWcRSxNs=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1710442197; c=relaxed/simple;
	bh=pb0vIzbYslsxt10rHOb4hxaHicDLWDRrEaXbbtynnbc=;
	h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:
	 MIME-Version:Content-Type; b=VTfBLu0BE6MELs6b41hFTzQDoOgir7P1UetQpjhSLkmrMnA2iEqX/lTEDH8RAi9c30z4gE8L7vSSDs9Rx1ZioJ/pYPUPF79rofISRZxgcR7HnKCDh83GXFPpcCxRwpP02e4TxcTVJksPlO8dg4qyVTtiZyVe6zHlNG3uc/kTyA0=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FgvF2cyB; arc=none smtp.client-ip=10.30.226.201
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60025C433F1;
	Thu, 14 Mar 2024 18:49:56 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1710442197;
	bh=pb0vIzbYslsxt10rHOb4hxaHicDLWDRrEaXbbtynnbc=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
	b=FgvF2cyB2dEhOJQTo+BV/LtO+QYJphhNwiRl9EzUgEmZhyEk6Cw+cRAj8HoVpHJ3u
	 Bmg/byQz3KLSQ+8ztBi850ll+ahOLJ1795tY5/bwSVI8FDBXQGrpsWu7LKbai1nVwO
	 PC61SeYguFEfd6DMInUBougdHgVtVXQ64fOoQDxv8MO3j/BH4WdgANoYn1YuLLFWrU
	 Yu85fX5ZHmoU49tLjwI0g5pBMLraI81TktYDBu5Af6BE6kZceKJ/d7kWKX9T/5pvuv
	 qSjxq5Lj1lIUuDlNyM/51f+J9MimnnN2U/Go0ExDFeS27ewuXiTGua/+5KC/YpbGuK
	 PL7lnyJ31C6Ow==
Date: Thu, 14 Mar 2024 11:49:55 -0700
From: Jakub Kicinski <kuba@kernel.org>
To: Heng Qi <hengqi@linux.alibaba.com>
Cc: "David S. Miller" <davem@davemloft.net>, Tal Gilboa <talgi@nvidia.com>,
 Eric Dumazet <edumazet@google.com>, Paolo Abeni <pabeni@redhat.com>, Jason
 Wang <jasowang@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Xuan
 Zhuo <xuanzhuo@linux.alibaba.com>, Jonathan Corbet <corbet@lwn.net>, Randy
 Dunlap <rdunlap@infradead.org>, Bjorn Helgaas <bhelgaas@google.com>, Breno
 Leitao <leitao@debian.org>, Johannes Berg <johannes.berg@intel.com>,
 netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
 virtualization@lists.linux.dev
Subject: Re: [RFC PATCH 0/2] net: provides dim profile fine-tuning channels
Message-ID: <20240314114955.71ada20c@kernel.org>
In-Reply-To: <1710421773-61277-1-git-send-email-hengqi@linux.alibaba.com>
References: <1710421773-61277-1-git-send-email-hengqi@linux.alibaba.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 14 Mar 2024 21:09:31 +0800 Heng Qi wrote:
> The NetDIM library provides excellent acceleration for many modern
> network cards. However, the default profiles of DIM limits its maximum
> capabilities for different NICs, so providing a channel through which
> the NIC can be custom configured is necessary.

Given that DIM is currently enabled and disable via ethtool
why are you putting the API is sysfs and ops in ndo?