Received-SPF: pass (google.com: domain of linux-kernel+bounces-103685-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
References: <20240223192658.45893-1-rrameshbabu@nvidia.com>
 <20240309084440.299358-1-rrameshbabu@nvidia.com>
 <20240309084440.299358-2-rrameshbabu@nvidia.com>
 <20240312165346.14ec1941@kernel.org> <87v85ovj4d.fsf@nvidia.com>
 <20240314105943.7bc6f2ef@kernel.org>
User-agent: mu4e 1.10.8; emacs 28.2
From: Rahul Rameshbabu <rrameshbabu@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: ahmed.zaki@intel.com, aleksander.lobakin@intel.com,
 alexandre.torgue@foss.st.com, andrew@lunn.ch, corbet@lwn.net,
 davem@davemloft.net, dtatulea@nvidia.com, edumazet@google.com,
 gal@nvidia.com, hkallweit1@gmail.com, jacob.e.keller@intel.com,
 jiri@resnulli.us, joabreu@synopsys.com, justinstitt@google.com,
 kory.maincent@bootlin.com, leon@kernel.org, linux-doc@vger.kernel.org,
 linux-kernel@vger.kernel.org, liuhangbin@gmail.com,
 maxime.chevallier@bootlin.com, netdev@vger.kernel.org, pabeni@redhat.com,
 paul.greenwalt@intel.com, przemyslaw.kitszel@intel.com,
 rdunlap@infradead.org, richardcochran@gmail.com, saeed@kernel.org,
 tariqt@nvidia.com, vadim.fedorenko@linux.dev, vladimir.oltean@nxp.com,
 wojciech.drewek@intel.com
Subject: Re: [PATCH RFC v2 1/6] ethtool: add interface to read Tx hardware
 timestamping statistics
Date: Thu, 14 Mar 2024 11:43:07 -0700
In-reply-to: <20240314105943.7bc6f2ef@kernel.org>
Message-ID: <87jzm4vejp.fsf@nvidia.com>
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?23GmvrQD0jGzV9BelBiV8eOdafnq8uK+eiJhcgWmUQOdzwBEmGBoC01q4rQs?=
 =?us-ascii?Q?uiVAq0NF5+a6QtBwhoUhtSbRnct+yNkI8thJubD8rdVsgvI80MgSpp/vr59v?=
 =?us-ascii?Q?tr28io/N4KpqyAJ5zN+hGWc63tI/9aDIKfXVa0vDT/sW47bGUBRoraoLsn8r?=
 =?us-ascii?Q?m2KD+/Goc0046YRUspiDDdZgo1e6kdiWcCSTycNHV9sUxkjuwDZDSOPL0gb8?=
 =?us-ascii?Q?pHmaMOAzSxKolaEGak30lstCYFNRzVIEXW58KKPPe9l8x3RqXIaCOB0pBzHn?=
 =?us-ascii?Q?Up0HjdSKrn63y2QWNSmqNagrtK/cN59JFRa2qcV5so5JMfWBZNybF4C7votR?=
 =?us-ascii?Q?Bl/r+t1aJg/+ekbXyKYeGvuMIkICufJpRFBtTD/GTphhCEOIb8Ru4UqDo3g4?=
 =?us-ascii?Q?tiQ4a95LhO2Yy/osrAJ+xIvhi6kEI52sIMpKjSlrK4Z4jRFOwHv5IaBIbLXj?=
 =?us-ascii?Q?lv6s+WEPygtRT+/hnqUI4fhgiIuw0UICNxd6LwVHZBgAIyYWBJfeUcsZNg29?=
 =?us-ascii?Q?f1167FNBt34J40oOO7iN9SryRGT6kpnYKZGVrvOXxwgxhzOu8rEpyGn6SWuI?=
 =?us-ascii?Q?KRPEBM/K/GANsTfAm38tJi5sVVhEN1O92NRPnKOceSnGVYRTs/+ph6vCIPnm?=
 =?us-ascii?Q?oS7m6MFhVxssuYIBjbU7FCw6geL9Qo3dH6ogrvJFZP2CW7f8jOjuVJePh65c?=
 =?us-ascii?Q?twwb2uL5JqGYNtIH2Q/jwCNaK08I3nopT5UJBAktcn5fj8YfSkn2f4suLrze?=
 =?us-ascii?Q?j9+dIITZupxFlijZ4isrCnPUuEahZUxOZCBMIOoV+2Zp41g67FpAD1FRfBF6?=
 =?us-ascii?Q?woX36axBfF8/zgRJu/6bbGlZLLxIWmsCyyBOV5maK/weZJKu74Q8GehAf6wr?=
 =?us-ascii?Q?jME7V1HkxNfA7f5fEuuQxIqW24mZ/Qidj/RcrK86eTiLZrmNMVKHNZpGdusz?=
 =?us-ascii?Q?WXWUPgtq2b+rYZwnAckVYNV+8zORgKLIHFPwzE/wzTdLY7S3clnK0wmGjmYF?=
 =?us-ascii?Q?TQjVggDMYDYCRvCwtSjqBT2qgsmVENEJWVTfoKO9Gxv9yK2Qd3UaVKsDm4ba?=
 =?us-ascii?Q?0I+DQ5JfUlXEIWeM8qGqjpPuvK4hnxbzdwFSdy7Mfd4AzStYfX9EPDzZkzj6?=
 =?us-ascii?Q?+TeFKdJ6Kt5MIE7GQHpl1bCwFfVBV+O7AW2AGSmn+ihdY/KdM+KvGxaAYSrD?=
 =?us-ascii?Q?gQQb4T+0bx7elhnmIf9QuaF6Em6yed1MntuqsBRixL6Xir/em7LMBTlJWhua?=
 =?us-ascii?Q?+NrBPUIK8J1aFJJTrzUA6kjbezbP0Qpg9UEc8Ak9u4khbI5J2aHJ3c97hsxt?=
 =?us-ascii?Q?+Kr6zsGOOi8DBUks4uE9apmKIkDZoE6lktb2L6ZJXqCohydKtzKtg4B4O36X?=
 =?us-ascii?Q?ptb4/oJ2Qf7N5Pn72/DXcfmPdEO9zvSwutMmKrvPfHbYYesZ+HNOTdKPsquH?=
 =?us-ascii?Q?ewHXhr5B/dMGnGyLIjCfAEWOs6NzyhG7q414eT9hcsLbhrW5tRb9wE5fHzd3?=
 =?us-ascii?Q?GRC7I+R8F2N+iXv4yFGGayCEacQNkg2ZI2+3CP+1wc42/kOFIclWUNF61I4R?=
 =?us-ascii?Q?RQbzDkxCBVG1qoAed213irYdqAH4galvlfn4LHlHCoStsF2FPjY2Dtxm2pgs?=
 =?us-ascii?Q?Og=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3db20667-8fc4-4823-f91c-08dc4456d001
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2743.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 18:44:42.8605
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oAUKsvdrYBXigks9CzMnqXKWwaKz3XCrbvbugnLjyk3l/3eAhFoBVrHhxdk+msWE3v3VaS420aVFlzGAbmB6cA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8510


On Thu, 14 Mar, 2024 10:59:43 -0700 Jakub Kicinski <kuba@kernel.org> wrote:
> On Thu, 14 Mar 2024 10:01:49 -0700 Rahul Rameshbabu wrote:
>> You need the pad to match with ETHTOOL_A_TS_STAT_PAD (which similar to
>> other ethtool stats currently defined). Otherwise, you run into the
>> following.... mm-stat and fec-stat are good examples.
>
> I don't understand.
> Are you sure you changef the kernel to use uint, rebuilt and
> there is no ETHTOOL_A_TS_STAT_PAD anywhere, anymore?

Sorry, I was not as clear as I could have been with my last reply. I did
leave ETHTOOL_A_TS_STAT_PAD in when I tested (intentionally). I was
trying to mimic other ethtool stats implementations, but you are saying
that in general there is no need for this padding (which I agree with)
and I can remove that unnecessary offset. It'll be different from the
existing stats, but I am ok with that.

--
Thanks,

Rahul Rameshbabu