Received-SPF: pass (google.com: domain of linux-kernel+bounces-103755-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
References: <20240223192658.45893-1-rrameshbabu@nvidia.com>
 <20240309084440.299358-1-rrameshbabu@nvidia.com>
 <20240309084440.299358-7-rrameshbabu@nvidia.com>
 <20240312165544.75ced7e1@kernel.org> <87plvxbqwy.fsf@nvidia.com>
 <20240313174707.38a71c84@kernel.org> <20240314130436.1052c739@kernel.org>
User-agent: mu4e 1.10.8; emacs 28.2
From: Rahul Rameshbabu <rrameshbabu@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: ahmed.zaki@intel.com, aleksander.lobakin@intel.com,
 alexandre.torgue@foss.st.com, andrew@lunn.ch, corbet@lwn.net,
 davem@davemloft.net, dtatulea@nvidia.com, edumazet@google.com,
 gal@nvidia.com, hkallweit1@gmail.com, jacob.e.keller@intel.com,
 jiri@resnulli.us, joabreu@synopsys.com, justinstitt@google.com,
 kory.maincent@bootlin.com, leon@kernel.org, linux-doc@vger.kernel.org,
 linux-kernel@vger.kernel.org, liuhangbin@gmail.com,
 maxime.chevallier@bootlin.com, netdev@vger.kernel.org, pabeni@redhat.com,
 paul.greenwalt@intel.com, przemyslaw.kitszel@intel.com,
 rdunlap@infradead.org, richardcochran@gmail.com, saeed@kernel.org,
 tariqt@nvidia.com, vadim.fedorenko@linux.dev, vladimir.oltean@nxp.com,
 wojciech.drewek@intel.com
Subject: Re: [PATCH RFC v2 6/6] tools: ynl: ethtool.py: Output timestamping
 statistics from tsinfo-get operation
Date: Thu, 14 Mar 2024 13:05:40 -0700
In-reply-to: <20240314130436.1052c739@kernel.org>
Message-ID: <87bk7gvary.fsf@nvidia.com>
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?/ldnOkzgqJt/zkNgrJS/N8ITAZn7m4FOTZUJJ7FKGEENR9fyeqUUtx7KPISO?=
 =?us-ascii?Q?AawI5T5XyxqURVuaCroKFlNSn4SNbqLcxnlWtSFjWANiIWqh6MCbQpdCXudm?=
 =?us-ascii?Q?Txa9xwKsDYN81qdZuQYizdmPCEghss3TN8tBKIXTA/w1U2uFe4FWaRLkun88?=
 =?us-ascii?Q?cT/moNFcymLLTAI+7ptEMaBs1viGFa1hZRYZPvVpaPl4pDgI3dx8blwbNCPT?=
 =?us-ascii?Q?15eLf7OP83wSsrONDhK3dW3bbHvdw6bAqPwCn5Cx4hahrVp3GlBztMVBjV4d?=
 =?us-ascii?Q?gZ1zpsh4am3tqd7v+53nhq5jwNBwEqJWqzpmryM1bf7UzxkPahL2Oyn+T+GV?=
 =?us-ascii?Q?u2poOoARNRWS8WHAJw8oLj9bU4zfAiS0T9HUut6l9wNSkd3rd82ZkcoEH+e3?=
 =?us-ascii?Q?mxWo3Hht/8AzxMafRhlVEFVEkzeqxoUGTuxTRcn8zgVz1D/Io4yQy7U75dHe?=
 =?us-ascii?Q?bRtFEFDfHnhD6TZU1mkXy4Y05r50GBoGMUtmpbqcw5+Qd69QP1bFAgx/Niwp?=
 =?us-ascii?Q?uEYTl3wCpX8vLGwn+LUEctBAoeLYk0vYwJBcoTtI+YG6SbE/fGjnMvAWfd0B?=
 =?us-ascii?Q?lIe5weX2d0nWvUA7FDnWcvomJ0d51ArnzeBZrTwSs1Gqd9QORcLzxr5ADbF1?=
 =?us-ascii?Q?TNDf/WMX/Tsw/h7hOqJLGbV29a7Jw4KaZwKumV+aySC4VAujnfNjtHGkp/qC?=
 =?us-ascii?Q?FTKxdif57upPZVXiplPW7lfIRPXTJnCtb0d6SvAML1U+lROOMQCPAMQboszx?=
 =?us-ascii?Q?fjtpdxlmLRLtTHfc2uQtA/vDVWJgRX98/DpVp8n8rem/Ctb/iAXL2U7I5Ptw?=
 =?us-ascii?Q?ZGa+FPoHbwWuTlAzEhK82G24OEffaPp17mSVaBtFFb2+bpXFVK/E0n9S4b2o?=
 =?us-ascii?Q?LnKez5sz0WM+HraEeXNEH+BKN6RhoEicziUlf8wEGYjfBHZ8gsh54H0xxPf8?=
 =?us-ascii?Q?MkCE0O7Rs6WK1Z0+KEYjXNOPaiWFrsekp6cQq3ZITmIB6VYILjm2Qct7LD4+?=
 =?us-ascii?Q?tb71l9pk6ex2t4cJL9RY8B/Uh2RN4XQPYHjRpEsTSTOK+43WpVfu4AYfcsPa?=
 =?us-ascii?Q?FB2oGcwJlEvmyPP8R5OLCA/bBO2VzBRPxRVT7WOA7aImV2iVtgfKl1Hi9aOE?=
 =?us-ascii?Q?b7teDL705o3UHQ0UMCg9NCx6HHWEMf5ieR2QiSthBeQOYhHvHv15QuBS7TFR?=
 =?us-ascii?Q?ikmfxF1A4LGVl8fKqffWGe0Ose1Qj6449avURTvMDx+L22NLYeZIdV63SKkB?=
 =?us-ascii?Q?aIqC2QWWR6d6BD/mC+xIl+pfceeaT5/db4xkUGcFUJwCaEfwOyGD7IBNKf+J?=
 =?us-ascii?Q?/24sriYXOewdlWP8KbI2poQ/Dqa95VNytoJ7/wKkGnwzoj6+mqIAZmx5HSzw?=
 =?us-ascii?Q?g6drexEDkKvvBh+RpGCrjt/qqR4yX98Pi7UhmDWWuF0NJ/dikQfZGBOt4QUo?=
 =?us-ascii?Q?Boa3EFqdd46s+Fi/LHGrz2PbNrPZ5Ams466T1/wAm8qgIVZB2aIf5eZ8J+l8?=
 =?us-ascii?Q?CmacHQ9Q1D5BoNIKLWyd1dZJks5Ud4vZZWw1Mctgs2xD6UW3IVqv7vXPlDZT?=
 =?us-ascii?Q?qzEP/jY3So6ptPfi+gYWWIzmSpUbVMPadknuVd5qkENPO4PTHH9fSSndgRKz?=
 =?us-ascii?Q?/w=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b2e136dc-b603-4576-0a4f-08dc44623193
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2743.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 20:06:11.0495
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8dGsAJG1z9ui2dTm3fN0je9V5hqUH1PnzZw4nnTYe2u8B9O6rujcQIAPje3eBKh3aCtmkE3w7ZfqNB9Two7sqw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5810


On Thu, 14 Mar, 2024 13:04:36 -0700 Jakub Kicinski <kuba@kernel.org> wrote:
> On Wed, 13 Mar 2024 17:47:07 -0700 Jakub Kicinski wrote:
>> +  -
>> +    name: header-flags
>> +    type: flags
>> +    entries: [ compact-bitset, omit-reply, stats ]
>
> Ah. Throw in an empty:
>
> 	enum-name:
>
> into this, or change the uAPI so that an enum called
> ethtool_header_flags actually exists :)
>
> Otherwise make -C tools/net/ynl will break

Already handled this in my patches by making the enum for
ethtool_header_flags. Thanks for double checking though.

--
Rahul Rameshbabu