Received-SPF: pass (google.com: domain of linux-kernel+bounces-103761-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
References: <20240223192658.45893-1-rrameshbabu@nvidia.com>
 <20240309084440.299358-1-rrameshbabu@nvidia.com>
 <20240309084440.299358-2-rrameshbabu@nvidia.com>
 <20240312165346.14ec1941@kernel.org> <87v85ovj4d.fsf@nvidia.com>
 <20240314105943.7bc6f2ef@kernel.org> <87jzm4vejp.fsf@nvidia.com>
 <20240314120647.58a07d94@kernel.org>
User-agent: mu4e 1.10.8; emacs 28.2
From: Rahul Rameshbabu <rrameshbabu@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: ahmed.zaki@intel.com, aleksander.lobakin@intel.com,
 alexandre.torgue@foss.st.com, andrew@lunn.ch, corbet@lwn.net,
 davem@davemloft.net, dtatulea@nvidia.com, edumazet@google.com,
 gal@nvidia.com, hkallweit1@gmail.com, jacob.e.keller@intel.com,
 jiri@resnulli.us, joabreu@synopsys.com, justinstitt@google.com,
 kory.maincent@bootlin.com, leon@kernel.org, linux-doc@vger.kernel.org,
 linux-kernel@vger.kernel.org, liuhangbin@gmail.com,
 maxime.chevallier@bootlin.com, netdev@vger.kernel.org, pabeni@redhat.com,
 paul.greenwalt@intel.com, przemyslaw.kitszel@intel.com,
 rdunlap@infradead.org, richardcochran@gmail.com, saeed@kernel.org,
 tariqt@nvidia.com, vadim.fedorenko@linux.dev, vladimir.oltean@nxp.com,
 wojciech.drewek@intel.com
Subject: Re: [PATCH RFC v2 1/6] ethtool: add interface to read Tx hardware
 timestamping statistics
Date: Thu, 14 Mar 2024 13:16:42 -0700
In-reply-to: <20240314120647.58a07d94@kernel.org>
Message-ID: <877ci4va99.fsf@nvidia.com>
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?4kQIOyf9U6EeqwfJK6bm6j7M3jTlON6RZErPKp68Av/cM9B8bPrhRGiKmpBl?=
 =?us-ascii?Q?AFKOWO8ug66GlZWTyCKf4taxJkZPQWthRkUBmxwHx//Y7rYuXxp1riu8e93n?=
 =?us-ascii?Q?DWr/ztU+Boa1H0KBsEovG8tRjpz0oD6DVDD51iB7x0XbOmmoIJxo5Xdp8XSa?=
 =?us-ascii?Q?nj04rbZVNP0L4STiBlaZLUkmrwjb8/hY1GznvF50akDePFUHaUaceH64kXLS?=
 =?us-ascii?Q?EWL1PBHbJQhsSZLKCnMOdQlZCZ/E2tAAULa9KkithOnGoebBU3NTuW0XGNMk?=
 =?us-ascii?Q?HcT41BwOlnq+4IoUtxouDvB8Cq4ans0IV2pFsdy2QMIaMWB+/f9A4BzGo2PP?=
 =?us-ascii?Q?hyp6tYEnKtpneRYH/wzlJArKLQxpaTIXYegVB9M4OIjY/fhaU0CZX5GVxK6c?=
 =?us-ascii?Q?LQ/RBDKQNOjEYwt73ABH5d/GkBZUCLe2/Jh4Nl+rfH9G3L1ouzOqP1thG713?=
 =?us-ascii?Q?G28Ge/Ol7MaUG76xKGIqVqr34yYTH2lbrGD/xts785ATIbI/AL1GJtCx48Kh?=
 =?us-ascii?Q?jGRXaPg3vDpRI3I7mC7XP3Kmktt+8HXqv2oNmB3rBSKk7JA17KQxcmYO+lra?=
 =?us-ascii?Q?WbcvbSNnDKSY+OarSnGSr6lLFPAuAsW1lr78ac92erqp+JRjP5SH9vffDSKE?=
 =?us-ascii?Q?QRi3X0RFU2pSk3ujY85kLV7RmWhf3cAfDGRX1aRuuYg/KYK9PvVvF70PQMJz?=
 =?us-ascii?Q?fUYsuProY1tOsjvPvDAgZSJ4cBGZGajue0iSue4Tb8Srnj6WayOkA6zOTLC9?=
 =?us-ascii?Q?2nkFXfje5nCXD0nujs643xJbf+onx1Lx9ZT+O5kpfoZ0KnnjkkhwVjtlSXOC?=
 =?us-ascii?Q?DFs4Fzf2PLW+q5caVcFIIoY1bFi/1pRciUKg1dOW0dOjwq5Hi6zXAWAji5ax?=
 =?us-ascii?Q?0mMl8BGaTEA9oDTn815A4KDbCn/HadXiFtmKPjiz1ssrs1BuckILjMSvMveC?=
 =?us-ascii?Q?60xdCJrcuUEVq77NRdIQ1vaEKE/6+46pzR7NUa30Oj4cK32ynTXXrudgCGOt?=
 =?us-ascii?Q?CPZu9q75KggT1Ikwvro3TDa+Yw4C3fyGbe5W78j2ndpV+fuIVU2Nmfi4fIGT?=
 =?us-ascii?Q?0TkM24YU5ZiHcNXiVvMDaxAZAeegKtPkgAjpDHnEhgSdJW8sqtyH/DPv1unU?=
 =?us-ascii?Q?M/qyAILFeF1/1tXEWeWNkHvrxrOeSI5aZ2PTYpJOyhhYYNzdg2MRGWUNEczX?=
 =?us-ascii?Q?0BPIHtQ7JHecf6weLxeZW5u6OlKL4GE8vkSLozPMeNaUWuQ5LnefuVdBaMuu?=
 =?us-ascii?Q?iLoo6VdVUKR+0XXyrsh1X9R8uwHmB//qTZ9mGFKhZS+2JZZDpWiWv1uu8551?=
 =?us-ascii?Q?XtRBL4clP8B0lz4NO6ZOms6zv+cuWSZesaL3KRDAMCbG2TThC0nRDX2zJxEd?=
 =?us-ascii?Q?sl3in5zwk/Ys3YisAimpYJzdnb+cSkH2Q5VRL4568LFFpSt92IiWGsIRjK4H?=
 =?us-ascii?Q?61Si4YK67pwqkCWlbSMcjWw/Px9t+AmtdeV46lyZS5tqhHuibHXC4S+bgiNb?=
 =?us-ascii?Q?irhMeEzISweJfuhJtq21bLSltQ1+W0QBTksFcd0CE/yoDPHMRAb8krb/GIXt?=
 =?us-ascii?Q?6w7aYXslzd1D0RzsfgFJJnpJjpz51dWyfS4Oj6b0y4+TvREAVyKD4fSoPhhb?=
 =?us-ascii?Q?WA=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eb782a34-fb98-40a2-39ab-08dc4463c2a2
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2743.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 20:17:23.8820
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rE+ZHF4ZzdyvAlxx5u/pQASZ6ibFAxMRZ4oPDqC+eQTWyw4VBS35BONHaYdJn8SBYjcbRwZ95Wbc5VWspwrrZA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB8833


On Thu, 14 Mar, 2024 12:06:47 -0700 Jakub Kicinski <kuba@kernel.org> wrote:
> On Thu, 14 Mar 2024 11:43:07 -0700 Rahul Rameshbabu wrote:
>> > I don't understand.
>> > Are you sure you changef the kernel to use uint, rebuilt and
>> > there is no ETHTOOL_A_TS_STAT_PAD anywhere, anymore?  
>> 
>> Sorry, I was not as clear as I could have been with my last reply. I did
>> leave ETHTOOL_A_TS_STAT_PAD in when I tested (intentionally). I was
>> trying to mimic other ethtool stats implementations, but you are saying
>> that in general there is no need for this padding (which I agree with)
>> and I can remove that unnecessary offset. It'll be different from the
>> existing stats, but I am ok with that.
>
> Yes, the small divergence is fine - uint is pretty recent addition.

Yes, the uint suggestion is great since we no longer need to depend on
the padding. Thanks for the feedback. Accounted for in my patches.

--
Thanks,

Rahul Rameshbabu