Received: by 2002:ab2:2994:0:b0:1ef:ca3e:3cd5 with SMTP id n20csp404876lqb; Thu, 14 Mar 2024 14:59:31 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU5B+NIUYg7PGjrAthQomDJy+5mAJS6uy1hrD4eKkOU9lYFOh+cHUF8OAuXe+j7Dxn+NcgbuRT+LUx+RntkW1r19QQLN7Hc0uogmL/rHw== X-Google-Smtp-Source: AGHT+IHQJhY4x+jfAWyx5ZGcd5ie0FnddttJtdLddRa38psM/R2usnStlrVo9ksCbAFFvIvjkyLl X-Received: by 2002:a05:6a00:234c:b0:6e6:ab7a:7753 with SMTP id j12-20020a056a00234c00b006e6ab7a7753mr1807433pfj.21.1710453571339; Thu, 14 Mar 2024 14:59:31 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710453571; cv=pass; d=google.com; s=arc-20160816; b=KSGt7SkWnzzMXtinsu4PJoIIdM3LUwGUcNT8AXyFhTWD6VyCj67A4iEu0t6pMOXwD7 3DjahjWx5ORv7xHIAGhJ3aHsGEccvGxohff4nk+qD2WjFkle5bJetQ2Ona96uN0hF3kN wTYppwwp8klsQZN86pfr5qfuPvaK592yMOHrB1QeeWHo3OKngS4NYNsfW3IDDl/OskUs zMSY65uU3nJTeSIEbZXA8WaiD3MDltYcSNmiNVKLwONuruzJODGt85+AKCV3xA4fiod/ HMgngsSMOcT0qpX8NZNWrcTON1eaMEKwh6hy4tIYhNbTbwX4umiTf64eYQ/5WD1mReTM T8NA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:dkim-signature:message-id; bh=Pb2TyShn5cGzp+TKV3K1QflBfbCiucgnS6X7KCZOU18=; fh=/UtWAiL5TUXS87ngLpI/fJ4bWoWuTbQ43SRP/LWUkBQ=; b=b/CFPqmgbCjYQbUGXz7hiSERhH40pdl7fSoVoQiWY2Feh3dcADGUWTdcFLPbpF7tTO dnfjNMvJ3fwwsI/KVFqEhmi4Q7qOLX126wjxRj5Z8IPb3Infy1/3qhlQunL5HGK5HpTr 8xDjU5c0PFrQ1QLBtdZFu9RNgpM6aRU9tH5Lk1ZJFgtdEQBe1tIFz61D3rhaeaCeuz2C gbhm7qrjkvHgHf5A8zId+0hBHKrW6AO9X0OREjHDLkxjukJlqghw/gBWsT6l3m1+l/JY Bq1AYjbfjfiS97UB9bFYkJ9imRLqQVe8b9bAhFlKeMHSv7AvBEEiugDcK7D4m4gOI6KS gzxQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=Y7r6v3Ue; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-103820-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-103820-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id w14-20020a63d74e000000b005ce0474353csi1331999pgi.238.2024.03.14.14.59.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Mar 2024 14:59:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-103820-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=Y7r6v3Ue; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-103820-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-103820-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 26228B21E0D for ; Thu, 14 Mar 2024 21:59:28 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 46DCA768FF; Thu, 14 Mar 2024 21:59:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="Y7r6v3Ue" Received: from out-171.mta1.migadu.com (out-171.mta1.migadu.com [95.215.58.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B83BF76416 for ; Thu, 14 Mar 2024 21:59:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710453557; cv=none; b=CCGcdkhFwDqsFGyHabsF3pjFSkniLxXL/zco5IdVA3HDnX3z3cJN1aSvFjEhKj5KGzIbPmJ/GWSr2dq1gTTZ9DCexm86HikjAuzeoteHdXKkEW31RJ327uXe7nfd3BSHxD94umZkSopep3Yd5JwW1G7N0io2l33nqvpMs7qOxhs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710453557; c=relaxed/simple; bh=Gm5h7ocQGBzgSGVHEHZGDunuEGCq2v7EHj6bhjfuCFA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UDSnbkKoNMLj5O6WnWtMC88edM8psAqWWK5pqQH86FEtgR3q634sNuHxHyeTxItEO2Ue/fvpY8N8aFw+HuXkFsD/08KBECCosPnlPYe6ivFUeDH2OVzo5demuEPJG38yaNXP5r8CFzwZFaZ79x2t6U/RD+YsuMV1FGQ4kTeTZ7U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=Y7r6v3Ue; arc=none smtp.client-ip=95.215.58.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1710453553; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Pb2TyShn5cGzp+TKV3K1QflBfbCiucgnS6X7KCZOU18=; b=Y7r6v3Uek51lhUcMekOlWmQi5IEWPXOWW2O4/ePZLoIFYbMRrqgyMTpJpZxHTqWDTcEY5R mEkiTmAPG0a0pUTHNLCgjow7/ldir8hE/DS3mMlLMAVEyBV6REI2uxYZZaJH2EQciII7l1 F4WnbO+CEap7qeoAEBa8W7rfMfGOECI= Date: Thu, 14 Mar 2024 14:59:08 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH net-next v3] Revert "net: Re-use and set mono_delivery_time bit for userspace tstamp packets" Content-Language: en-US To: Abhishek Chauhan Cc: kernel@quicinc.com, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Halaney , Willem de Bruijn , Martin KaFai Lau , Daniel Borkmann References: <20240314192404.1867189-1-quic_abchauha@quicinc.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Martin KaFai Lau In-Reply-To: <20240314192404.1867189-1-quic_abchauha@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 3/14/24 12:24 PM, Abhishek Chauhan wrote: > This reverts commit 885c36e59f46375c138de18ff1692f18eff67b7f. > > The patch currently broke the bpf selftest test_tc_dtime because > uapi field __sk_buff->tstamp_type depends on skb->mono_delivery_time which > does not necessarily mean mono with the original fix as the bit was re-used > for userspace timestamp as well to avoid tstamp reset in the forwarding > path. To solve this we need to keep mono_delivery_time as is and > introduce another bit called user_delivery_time and fall back to the > initial proposal of setting the user_delivery_time bit based on > sk_clockid set from userspace. > > Fixes: 885c36e59f46 ("net: Re-use and set mono_delivery_time bit for userspace tstamp packets") > Link: https://lore.kernel.org/netdev/bc037db4-58bb-4861-ac31-a361a93841d3@linux.dev/ > Signed-off-by: Abhishek Chauhan Acked-by: Martin KaFai Lau