Received-SPF: pass (google.com: domain of linux-kernel+bounces-103828-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 14 Mar 2024 22:13:03 +0000
From: Cameron Williams <cang1@live.co.uk>
To: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: CH341 RTS/CTS flow control disabled in driver?
Message-ID:
 <DU0PR02MB7899EC8515D8FF35B4D01465C4292@DU0PR02MB7899.eurprd02.prod.outlook.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: DU0PR02MB7899:EE_|AM7PR02MB6017:EE_
X-MS-Office365-Filtering-Correlation-Id: f7345db0-4acb-4d47-d0c1-08dc4473ec2b
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Ber5TmOKH8/FEHZbVc1KyPpaARYKFR4tzaS7LYtuCFMwim5X/985q5tJ8VXwIA6qcqT5DaQv1tODxOWm3vZ8oJfE6TStPUAr/ZED9MboP3pYhLKZ8a66/9GhCIASi+UJQ+jwAVkIG2XJaohM4//TwxU0a2v9E3rdyz442GVfYWsimasn/M56emMrAy9EGUtDe7pRpmo3gaSq+FSehlSPM6tSVOKMKQLj1uNQ84wvqCtUrj1k3GzQQV5slD/V1ZoluZ/iu2ufAeyExY7UwCxAjI3hwt8Ul6KUWgFzvr6v12KA6RYZQkmoM4tZh1wn1+k2mpL9NuY8BamW5vkxHgcmA5RVwe9rjT0jE5cafFnNHBO+/H8O4zpGqUzKNyw/Czr7zewaZSkpJHszNA+voedh942b9mGaLvuSsoNYDVXNJfPbSGVN/bIVrpMrG2rQIKceL72Hgo1xJA+so6zrwfgenQcPZ28Jjx8VWaQHXI1ZisV3K42OIjS8PpzpQpO/5+PpUQ9dsJblZ1DosYlJJu19jfI5lu6IZIq9UUOJ76xg0MFnvEzXmvSFE+U4HiRDe0uS
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?+4pdAPMpsg2PeOJpGk2yGndaINt0LXR4sxdJ/hMlvRMNQyHzaTFq/vXEFGRN?=
 =?us-ascii?Q?Dd79i6Scn86DY+xcYTki+QdcKQYGygC4SRCDdOJJZSdMCJG38hQApJrJnZ7b?=
 =?us-ascii?Q?konXfdtwO75Ksyi1Eek6b8fCAHYmP9gVg/jImV9H1pWtJNIoVkLv1KI5KaZG?=
 =?us-ascii?Q?uqNFMRyQRyTKlbkO4qS53OQ1A7PIAZSHW/4Gie7zLNI4o+3KnwhSWTdkhUo5?=
 =?us-ascii?Q?P3nnYt6ZAhCtfe9jgH9kjjnLYOrO2fDPioDbODzSoGzmRHBW68oi+xT/iUs1?=
 =?us-ascii?Q?V+gH8rcmaUA/5m4aVg4w+eaRgI90OqgqWHvsUzUbtOxF6VNMgoLI5snNtIg5?=
 =?us-ascii?Q?eJIR6cDlbuxgeDeubFCQTfzAA8Y9UcgCmYH6QJifK9Ow8Ay/KwGLx3GyI1H4?=
 =?us-ascii?Q?nsL+KLz57WKQ8wp/WxpPQbueDIzECW4mrkgTYDNAIepziulR1Kst5vZXOPrG?=
 =?us-ascii?Q?F/ZgTrWjgR74FVyiCU+HAQ/dHhI4vTsNvvYTg8smPA/cPZpOlvXfmQ6p4rAW?=
 =?us-ascii?Q?dfwMtyzfXvLMmteS7IH2aeX/hw9A6tdo1PfhdQ4Z7DlJAb94C2E8bMoLP1iu?=
 =?us-ascii?Q?gk6Pj4qFNF/SM2DFfQa93J2I+3Pim+s8eDeOqYN7pGStEa8WagonJyxRtSxO?=
 =?us-ascii?Q?45+tlDUGOkkqpx5dgpMKIFCqphaP8Pi6kz8SSFKp+8hmZpKe1SEKGru8asfx?=
 =?us-ascii?Q?PBCBqX7hG19SQJPuz+zzeGY/7yQ7xofbd9w6LPMkXL1NbhP/kO9uvSQGdb4Z?=
 =?us-ascii?Q?BDaKr4oA/Hf905IqMQyJrfBlx7KvfWPAzGSh3TznwVF1MwqYiiA5IBI4v50X?=
 =?us-ascii?Q?fBOy8PQe6Jl2DWSNjkxUO4KQ6UX7G8m2f2iD43wRtYxaB764WfyR5PSMaoHS?=
 =?us-ascii?Q?ZoNUyoQfhJzfjsyzgDWtq6mGRa6FeLroazoE55IX75KLKCabeRLtYloZFyiN?=
 =?us-ascii?Q?eOAaBGgTFSynJ3ttXqeWZDZJDlDJYnz95nWi1NyjSUyiAS5MpAEUIZoKpRYM?=
 =?us-ascii?Q?tDeriu6uHbSi4UjtbZkwXpTXON03R4hFMEVJx7t8G7N1U8ISD3Lp2NMKHSXp?=
 =?us-ascii?Q?6SYZT868HUv3oc+jCKufhrDZg82W88hLXJhveEZKCOSvDWKKwq10NMIKtva9?=
 =?us-ascii?Q?XM2wTE0NSI/NiTRlXPcgUrJM6+lewmhhZ4gQKOZ/XzRUdcVs6aobIy6DzSPy?=
 =?us-ascii?Q?2a1HbRCNBEQBojyFhdvlKhI0/Ba6X4aQmPpaWw=3D=3D?=
X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-ab7de.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: f7345db0-4acb-4d47-d0c1-08dc4473ec2b
X-MS-Exchange-CrossTenant-AuthSource: DU0PR02MB7899.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 22:13:05.7566
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR02MB6017

Hi all.

I am wondering if anyone knows anything regarding the RTS/CTS lines on the CH341 (maybe CH340 though I have no chip example).
I have two CH341-based devices, both a generic 3V3 uart and also an all-in-one type device with SPI/I2C.

From my tests, neither of them seem to have RTS/CTS respected, and I don't believe they are fake?

My test procedure is as follows:
1) Have nothing connected except TxD/RxD via a jumper.
2) Open `statserial` to check the status of the lines. On all devices, RTS is set to 1 and CTS is set to 0.
3) Open PuTTY, ttyUSB0, 9600 baud, RTS/CTS flow control. Data should not flow as CTS is not high. Close PuTTY.
4) Open PuTTY again, same settings, but with no flow control. Characters buffered from step 3 should now appear thanks to the loopback in step 1.

Alternatively, for step 3 and 4, set Picocom to use RTS/CTS, send some data, then disable flow control, and the buffered data will now flow.

Using an (albeit fake) FTDI device, and PL2303 based device, they both work as expected.
A CP2102 doesn't like to exit with stuff already in the buffer (just hangs PuTTY), but thats a separate issue, and at least it is respecting CTS/RTS.

However with both CH341 devices I have, on step 3, the data flows regardless. Checking in statserial, CTS is indeed still set to 0.

Is this intended behaviour? Looking through the source I can see RTS/DTR should be supported, but it just doesn't seem to work.

If anyone wants to look at it I'm happy to help debug.