Received-SPF: pass (google.com: domain of linux-kernel+bounces-103863-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <46389801aeb20f18affed86d979aff7a62cf36d5.camel@gmail.com>
Subject: Re: [PATCH v2 4/6] iio: pressure: Simplify and make more clear
 temperature readings
From: Angel Iglesias <ang.iglesiasg@gmail.com>
To: Vasileios Amoiridis <vassilisamir@gmail.com>, Jonathan Cameron
	 <jic23@kernel.org>
Cc: lars@metafoo.de, andriy.shevchenko@linux.intel.com, 
	mazziesaccount@gmail.com, ak@it-klinger.de, petre.rodan@subdimension.ro, 
	linus.walleij@linaro.org, phil@raspberrypi.com, 579lpy@gmail.com, 
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Fri, 15 Mar 2024 00:22:50 +0100
In-Reply-To: <20240314201718.GD1964894@vamoiridPC>
References: <20240313174007.1934983-1-vassilisamir@gmail.com>
	 <20240313174007.1934983-5-vassilisamir@gmail.com>
	 <20240314150959.585367b5@jic23-huawei>
	 <20240314201718.GD1964894@vamoiridPC>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 (by Flathub.org) 
Precedence: bulk
MIME-Version: 1.0

On Thu, 2024-03-14 at 21:17 +0100, Vasileios Amoiridis wrote:
> On Thu, Mar 14, 2024 at 03:09:59PM +0000, Jonathan Cameron wrote:
> > On Wed, 13 Mar 2024 18:40:05 +0100
> > Vasileios Amoiridis <vassilisamir@gmail.com> wrote:
> >=20
> > > The read_press/read_humid functions need the updated t_fine value
> > > in order to calculate the current pressure/humidity. Temperature
> > > reads should be removed from the read_press/read_humid functions
> > > and should be placed in the oneshot captures before the pressure
> > > and humidity reads. This makes the code more intuitive.
> > >=20
> > > Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
> >=20
> > To me this makes the use of these calls less obvious than they were
> > previously.=C2=A0 The calls are made close to where t_fine is used and
> > don't have to go via the indirection of chip_info.
> >=20
> > So I disagree. I think this change makes the code a lot less
> > clear.
> >=20
>=20
> This was mainly driven by the fact that I wanted to avoid reading
> the temperature 3 times in case temp, press and humid are enabled
> and there are consecutive buffer readings. But thank you for the
> proposal I really appreciate it!
>=20

Hi, just a side note reflecting on this. Depending on your sampling frequen=
cy
and registers data shadowing, to avoid compensating with different samples
between readings, we should be doing burst readings to get a bundle of the
temperature+pressure and/or humidity.
On the bmp/bme280 and bmp380 this can be done as registers are contiguous o=
n the
memory. On the bmp580 this is not a problem as the values are already
compensated, you`ll get always the latest reading.

Kind regard,
Angel