Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759117AbYAHOyp (ORCPT ); Tue, 8 Jan 2008 09:54:45 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754721AbYAHOyi (ORCPT ); Tue, 8 Jan 2008 09:54:38 -0500 Received: from relay.2ka.mipt.ru ([194.85.82.65]:53456 "EHLO 2ka.mipt.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752634AbYAHOyh (ORCPT ); Tue, 8 Jan 2008 09:54:37 -0500 Date: Tue, 8 Jan 2008 17:53:40 +0300 From: Evgeniy Polyakov To: Alexey Dobriyan Cc: Herbert Xu , linux-kernel@vger.kernel.org, devel@openvz.org Subject: Re: [PATCH -mm 2/4] hifn_795x: fixup container_of() usage Message-ID: <20080108145340.GA1383@2ka.mipt.ru> References: <20080108084434.GB6209@localhost.sw.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080108084434.GB6209@localhost.sw.ru> User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 662 Lines: 19 Hi. On Tue, Jan 08, 2008 at 11:44:34AM +0300, Alexey Dobriyan (adobriyan@sw.ru) wrote: > [PATCH -mm 2/4] hifn_795x: fixup container_of() usage > > Signed-off-by: Alexey Dobriyan Well, I have no problem with the patch, although do not see any gain in it :) I usually prefer to call members the same in container usage, since I always forget where each one should be placed. -- Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/