Received-SPF: pass (google.com: domain of linux-kernel+bounces-103912-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240314201856.1991899-1-gnstark@salutedevices.com> <20240314201856.1991899-2-gnstark@salutedevices.com>
In-Reply-To: <20240314201856.1991899-2-gnstark@salutedevices.com>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Fri, 15 Mar 2024 01:33:18 +0200
Message-ID: <CAHp75Vd+UUY76K1Z0F4L=hqAfpAy=K8L26fqvh9-xeTHq3nf-A@mail.gmail.com>
Subject: Re: [PATCH v7 1/8] locking/mutex: introduce devm_mutex_init()
To: George Stark <gnstark@salutedevices.com>
Cc: pavel@ucw.cz, lee@kernel.org, vadimp@nvidia.com, 
	christophe.leroy@csgroup.eu, hdegoede@redhat.com, mazziesaccount@gmail.com, 
	peterz@infradead.org, mingo@redhat.com, will@kernel.org, longman@redhat.com, 
	boqun.feng@gmail.com, nikitos.tr@gmail.com, marek.behun@nic.cz, 
	kabel@kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, 
	kernel@salutedevices.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Mar 14, 2024 at 10:19=E2=80=AFPM George Stark <gnstark@salutedevice=
s.com> wrote:
>
> Using of devm API leads to a certain order of releasing resources.
> So all dependent resources which are not devm-wrapped should be deleted
> with respect to devm-release order. Mutex is one of such objects that
> often is bound to other resources and has no own devm wrapping.
> Since mutex_destroy() actually does nothing in non-debug builds
> frequently calling mutex_destroy() is just ignored which is safe for now
> but wrong formally and can lead to a problem if mutex_destroy() will be
> extended so introduce devm_mutex_init().

..

>  /***

Unrelated to your patch, but there are too many asterisks :-)

>   * mutex_destroy - mark a mutex unusable
>   * @lock: the mutex to be destroyed

--=20
With Best Regards,
Andy Shevchenko