Received-SPF: pass (google.com: domain of linux-kernel+bounces-103914-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <1c0b80ed-f56f-4840-b5ca-54840b1b60a3@intel.com>
Date: Thu, 14 Mar 2024 16:37:55 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] selftests: x86: skip the tests if prerequisites aren't
 fulfilled
Content-Language: en-US
To: Muhammad Usama Anjum <usama.anjum@collabora.com>, Shuah Khan
	<shuah@kernel.org>, "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Dave Hansen <dave.hansen@linux.intel.com>, Binbin Wu
	<binbin.wu@linux.intel.com>, "Peter Zijlstra (Intel)" <peterz@infradead.org>,
	Weihong Zhang <weihong.zhang@intel.com>, angquan yu <angquan21@gmail.com>
CC: <kernel@collabora.com>, <linux-kselftest@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
References: <20240314114502.466806-1-usama.anjum@collabora.com>
From: "Chang S. Bae" <chang.seok.bae@intel.com>
In-Reply-To: <20240314114502.466806-1-usama.anjum@collabora.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MHRSZWpJM0hZOEZ5OVZIMjRaK2YzQW9xZDZtZk11U1dUTHpnYURCdTArQWNY?=
 =?utf-8?B?T3NGbHM2RGxmK2NBWFlPM0RjaGxrd1ZzekNXYlZlcFh3UWl6bjVqMXBXQmMw?=
 =?utf-8?B?dTYzdUh0WjJBamRqeVppcnN0RlgzSUFidnZ2bm56eUYxVUNCSGZUVURpWURU?=
 =?utf-8?B?blBxRnl4K0xad09KV2IrSENsbnFDT3VMbE1XM1NHSEZwaXNORDR0SXRIQlVL?=
 =?utf-8?B?NFkrc29UMHBrMEdOYTluQmZ0QTdMN2tnZzNNcE94bXRtSE1LMWk3a3BHNFJG?=
 =?utf-8?B?dlQ2b0tzUmRWWUplWS9FZmIxb1pXSXdsL0RvNWZ3Y1ZxUHk4UWs4SkM1ZjJt?=
 =?utf-8?B?bmJiMXhCdlczWENoMXVMUjRZbDJxOUtySUhZOEp1WFg5d3h3MmloYVhRL25t?=
 =?utf-8?B?ZHRDUUU2c1hNc3krVzdyT2VhTVphL0s3dUM2bnBXTmU1WlZUK1BqNllNRGdC?=
 =?utf-8?B?U0w2SndiVUNKRGg1VGdCQ1FsUGpNNkxHT1QzV28zNUdXTnlINE95RVkzb3Va?=
 =?utf-8?B?TnlvK0xxeDA2bHpNaytWUHBGaXEreFBNdkJCdkNzRmRvZlVKUFhHSFhKQ0ov?=
 =?utf-8?B?Q0s5R2FtQ3NIdGk1bXBYUExLeWhhSWt1cU84VndUU2dWSFVrU25BQ2ZMelZ4?=
 =?utf-8?B?cDVHOXFKUTFLejlrV3R2MDJYU3JFYWJMb0ViUXljRDYzNjc0UW9jb01WSVZj?=
 =?utf-8?B?MkxOMnZMMDZVamgwa2x0Ty9VZXRWb0cvN2loNk1LajkrWWtwVVk4czZSSUVJ?=
 =?utf-8?B?KzZxcEdidnY0NGtQTnBXb2Q3SUNBVUlhN01lSUJ4Q2h2WVR5N212bzhLSWVN?=
 =?utf-8?B?Tm44bFlnSkptZ1VuYldBRVJqbGdUY09aanJYRTRjdUo1clBZQnVYRVBnZ0cr?=
 =?utf-8?B?SHJHWU9TeVdmYlhrNFBGQmUxRUlnYzhUdVdZVEtvaFNQTG1zeFpzbUhJMUNK?=
 =?utf-8?B?L1dUNjBkbHhPWXB1VFExWUh0dk95OHVsZU9ETHBXMlpQOExOc3VKblM1RGMz?=
 =?utf-8?B?WUZPNVJmem1qZWNOWXo1UWtlSlBZckgyRURyN2x3WmlnRDNRN0hPbGoyM29Z?=
 =?utf-8?B?Y1AzdjRXQjhTcFp6c21VWGdnZkhjNTE4WnVYNnFHbmRRejIwcHR0c2ZWVFBJ?=
 =?utf-8?B?ZC9XdjI5WVNiSmZuUUJyUm5oSGlmSEFHZzFTZ3VWTTEyKzJXWGRtcWcvK1d2?=
 =?utf-8?B?T1FWVnRIUS9TR1FDUXcrUFU0bUZ5ZzFVQTlvYXpZKysyMTBISlVIR0xRSlN1?=
 =?utf-8?B?QXpJQlRjeDFXdFB6MkIvOCtjRDlsbk9hUHA4WkIvQ3pLU0VhL3lXejNUb2lT?=
 =?utf-8?B?ajZhbEJRSFpDMFdSYStWcjJnM0tUd1BRZld6OHpETzVoeGZQRU04L3pGbDRD?=
 =?utf-8?B?MjVIRGFCQ0N4RERmRERDZHpxd0YvQmFaTTJFRnhtZGVhbEVOc3pqOUFNSHJ4?=
 =?utf-8?B?RlZKNXoxYzAwcTRvVGZoVm80Wk05N3JWS3ZROUFmR2M2WkEycU9KMDVjSXRy?=
 =?utf-8?B?Nno3aXZRTzZjTEJSaVgrUGVFOE14bWxLYmYrMWpuU2M0TkxiOEhuY2FiMzJm?=
 =?utf-8?B?NE0yeE1CZ293SWFuNjdpMEJSMkxic0FOVGxZU2x1ZGpLb2R6SWFyVk5rUm4r?=
 =?utf-8?B?alp1b05IL2dJY1RQN2NOZkdRbmdyei9CM2VsMllkdEJ3SC9MTG1qak1adlhx?=
 =?utf-8?B?YW5vdVRCb05vZ2xYY3ZrWUQ3cll1blNaT2w2Z3FoUmlJK25PZE9JWDY5RUFV?=
 =?utf-8?B?YVJDTUtJUStkbkVTRnpiVmxjdllDdGt0WjlNczI4S1BlZ2tqa2x2VEhaYlor?=
 =?utf-8?B?WXBmamFwRFVkNlVzS0xTMzRpWTVRU2RIMWxSTVZYT1BCNW5Vek44NmxCYXNB?=
 =?utf-8?B?OWkzdlFkOGI5WjFuT3kwUDFyNU9QUG9mMzN6Mm1DMENkamxkT21OaGtiYUha?=
 =?utf-8?B?a2k1QUlxRk9KOUllQ2NjbDZWRlBmb0p2amlPcU9WRUEycTRFZjc3TkdlWTUx?=
 =?utf-8?B?djh6ZmJ3YkU3SGNmNGVVWERmKzk1ckZLbUprNTl2U2xIZFF5UlF4Q0d0ek5t?=
 =?utf-8?B?N1VHaDRmdUZvUTVUOHk4WUhLM0czUC9OME5WR0pJN2FLQUs3Q3RFTmxOMW1V?=
 =?utf-8?B?RlVXYXNGUXRMUVpMS29wQlk0SGoyVGVZbEpXWW8zWER3dkNYMjAyNUNJek1Y?=
 =?utf-8?B?WUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ee6f3287-7217-4651-a7b6-08dc447fc7c6
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB7164.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 23:37:58.6968
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nXdVOd93Hvi1WDaZmLdN1dwxXuTve+ekGzSURA7FYX0nvCOzfWa6p716X8kHWCCOaItJtVJGP6S9+uArXqXMPIe006C/yBQknPWhIqX45w0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB8248
X-OriginatorOrg: intel.com

On 3/14/2024 4:44 AM, Muhammad Usama Anjum wrote:
> Skip instead of failing when prerequisite conditions aren't fulfilled,
> such as invalid xstate values etc. This patch would make the tests show
> as skip when run by:
>    make -C tools/testing/selftests/ TARGETS=x86 run_tests
> 
>    ...
>    # timeout set to 45
>    # selftests: x86: amx_64
>    # # xstate cpuid: invalid tile data size/offset: 0/0
>    ok 42 selftests: x86: amx_64 # SKIP
>    # timeout set to 45
>    # selftests: x86: lam_64
>    # # Unsupported LAM feature!
>    ok 43 selftests: x86: lam_64 # SKIP
>    ...
> 
> Cc: Chang S. Bae <chang.seok.bae@intel.com>
> Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Reviewed-by: Binbin Wu <binbin.wu@linux.intel.com>
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
> Changes since v1:
> - Use arch_prctl to check if amx is supported
> ---
>   tools/testing/selftests/x86/amx.c | 27 ++++++++++-----------------
>   tools/testing/selftests/x86/lam.c |  2 +-
>   2 files changed, 11 insertions(+), 18 deletions(-)
> 
> diff --git a/tools/testing/selftests/x86/amx.c b/tools/testing/selftests/x86/amx.c
> index d884fd69dd510..95aad6d8849be 100644
> --- a/tools/testing/selftests/x86/amx.c
> +++ b/tools/testing/selftests/x86/amx.c
> @@ -103,21 +103,6 @@ static void clearhandler(int sig)
>   
>   #define CPUID_LEAF1_ECX_XSAVE_MASK	(1 << 26)
>   #define CPUID_LEAF1_ECX_OSXSAVE_MASK	(1 << 27)
> -static inline void check_cpuid_xsave(void)
> -{
> -	uint32_t eax, ebx, ecx, edx;
> -
> -	/*
> -	 * CPUID.1:ECX.XSAVE[bit 26] enumerates general
> -	 * support for the XSAVE feature set, including
> -	 * XGETBV.
> -	 */
> -	__cpuid_count(1, 0, eax, ebx, ecx, edx);
> -	if (!(ecx & CPUID_LEAF1_ECX_XSAVE_MASK))
> -		fatal_error("cpuid: no CPU xsave support");
> -	if (!(ecx & CPUID_LEAF1_ECX_OSXSAVE_MASK))
> -		fatal_error("cpuid: no OS xsave support");
> -}
>   
>   static uint32_t xbuf_size;
>   
> @@ -350,6 +335,7 @@ enum expected_result { FAIL_EXPECTED, SUCCESS_EXPECTED };
>   
>   /* arch_prctl() and sigaltstack() test */
>   
> +#define ARCH_GET_XCOMP_SUPP	0x1021
>   #define ARCH_GET_XCOMP_PERM	0x1022
>   #define ARCH_REQ_XCOMP_PERM	0x1023
>   
> @@ -928,8 +914,15 @@ static void test_ptrace(void)
>   
>   int main(void)
>   {
> -	/* Check hardware availability at first */
> -	check_cpuid_xsave();
> +	unsigned long features;
> +	long rc;
> +
> +	rc = syscall(SYS_arch_prctl, ARCH_GET_XCOMP_SUPP, &features);
> +	if (rc || (features & XFEATURE_MASK_XTILE) != XFEATURE_MASK_XTILE) {
> +		ksft_print_msg("no AMX support\n");
> +		return KSFT_SKIP;
> +	}
> +

Reviewed-by: Chang S. Bae <chang.seok.bae@intel.com>

Thanks,
Chang