Received-SPF: pass (google.com: domain of linux-kernel+bounces-103927-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <e6e8f585-b718-4f53-88f6-89832a1e4b9f@intel.com>
Date: Fri, 15 Mar 2024 13:02:01 +1300
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v19 007/130] x86/virt/tdx: Export SEAMCALL functions
Content-Language: en-US
To: <isaku.yamahata@intel.com>, <kvm@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
CC: <isaku.yamahata@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>,
	<erdemaktas@google.com>, Sean Christopherson <seanjc@google.com>, Sagi Shahar
	<sagis@google.com>, <chen.bo@intel.com>, <hang.yuan@intel.com>,
	<tina.zhang@intel.com>
References: <cover.1708933498.git.isaku.yamahata@intel.com>
 <8f64043a6c393c017347bf8954d92b84b58603ec.1708933498.git.isaku.yamahata@intel.com>
From: "Huang, Kai" <kai.huang@intel.com>
In-Reply-To: <8f64043a6c393c017347bf8954d92b84b58603ec.1708933498.git.isaku.yamahata@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WlZoMUdFVjJ1TFByQ1lGZktCQjNyOHdPNjU5YnNRQVViRCt3aW03ck9LM2U2?=
 =?utf-8?B?NGJVNmdFK0hyeEN6RmlFRHJFclkxZDZUcXJDL21BMUx4OXhKY2ZsZTdtNTRu?=
 =?utf-8?B?RWc0VnVyaU4vMXFhMmxtWGNGZDRJUHRPY2tEbGx0Nk4rN1dqMERaclQrOGVP?=
 =?utf-8?B?MlRBN3p1U1AyMXBoTmRFaWxRUmJzU1p3K0hUam90OHczRFRPTHA2TDFoMjIy?=
 =?utf-8?B?Y0FhdUw5dWJJc1JTMFBNd3U4dEYwc1hrMTZ4dFhFK1JNK2N6ZmhaeUlrMWh1?=
 =?utf-8?B?ckRnMzhUZ1dOQVExR2wrRFg4dmN3RVhCaWxMUVpsZU5tSXUzOXFWSkE2Kzlw?=
 =?utf-8?B?SFlwdEc0QnJGTlg4N0UxKzdvelJVbkNqSC9OSGR3eTljS3VDcDVQdjFtNUxG?=
 =?utf-8?B?aGtQdTF4YXY2NDgrb2l3WnVRNzBOUmJNbkQ3QVdLRXI4UUhsUjdIMDRmZlJj?=
 =?utf-8?B?WE56MmFOOXpkR0dEMkIra1lRRlNMRWc0Mk84VU80Q1ZTZnRtQTdyZjNwdW9L?=
 =?utf-8?B?N0NmOVdIdzBNTHh4d3ptUTZPNXZEVmVpejExSE9XVnlrMGYzL0Rxd3AvS2Q5?=
 =?utf-8?B?c0NzMDVtZlFFWUYzQnBMNzNsaDFTQjJhZTMwUC9wbkNvelM2TEs3aEhMNCtx?=
 =?utf-8?B?UzFJeGVPY2NWVzVJcEhZV2h6eW5kcGtDb1NnQUkvNEhGbS9YemFVTnNSalgw?=
 =?utf-8?B?ajdqVVNTTE1HdnRoMjE1NVJNa3RySGFXb011NUx1b2c2Wkl5eW80ME4zOHF5?=
 =?utf-8?B?bHgwamx0ZlNVZ1hZOE9oV3RYaFVkQzNjRVcvZmZLRnpSWGxMV2ZqKy83b3Zs?=
 =?utf-8?B?bzY3MmZ3WUVHRHBqUXpuSjltcnNJbXFSQnAzOVgzU3JtQ2tPaW51U2kvMzZ5?=
 =?utf-8?B?UklSQlpJRzhPdUx3WmNYVitVWExjaVB0RFJVVXp6UXVPWThTY1g5cGpsdXFK?=
 =?utf-8?B?eEYwZkVIOTQxdWN0YXMyZkxHbkpQcEY3cFlrTnpoVGVtUURzNUhCbC9Wa2ZZ?=
 =?utf-8?B?WndzeVJrY3hrcW9obHdGSkx1THROL0dKQUhZZ3Fad3hwZzFyRUlpVDRLSVRY?=
 =?utf-8?B?UWhIMStnek02dUtxWkFZNkRqdTFEc285M1Y3K2NUbTVlWnl6Y1o4RW9pTUU0?=
 =?utf-8?B?SjVtMWFEWDNjTTBwaURZZGhXMzh1UXgrWmZPRVNmWFQ3cDJ2Q1JHSElDVk1B?=
 =?utf-8?B?b1pwSEU4czEzNVM0ZmVhdWcvY3BieG9RYnBnRlJCVzJQeEptR3lpcGk5eVVK?=
 =?utf-8?B?L1VLL0JmSE9vYmJJdG8vNTY3SE01RkVuRC9RdUNIOVkzdWgwMDFRK0E0TzRZ?=
 =?utf-8?B?L2E4aEo2dFpwOEJzMkl2Qit3ZkVDSVhGWisvaEVRYUZjWkp3dTUwaUNqUlVj?=
 =?utf-8?B?d1p0ZXdIMC9GUFhlVWFIbzA4ckE0RW5yWHpUYzZwaUJUUWp1eTBydW11OTJs?=
 =?utf-8?B?QlRVMjhaZm9XNUNiQktzTmlWZGNLbU9jWllkaDN0aS83TmZFOEZCdlp6eURI?=
 =?utf-8?B?ME9uVy85TEN4V3dMRFJ5cjlKcDlYbExQbFFpVmszVjJkd2ExaUQ1enM0MFhH?=
 =?utf-8?B?WS9IR3dnYitrTjFrSU5jeFpFNHpsYzdkZWRENHYyTHhwQnY0enkyTU5KL2da?=
 =?utf-8?B?SVllaE5VcU1UQVpDdGR0SkQvemh4VjVEL3dubHpmTGVCOG9jVkJoVC9ocS9F?=
 =?utf-8?B?cjRJQS9LZG5oOHlseFo3SXF6SWdGYzFSOWZWeCs1L3hKYlU2YkJKaHkzRFJy?=
 =?utf-8?B?YnRkbTRpa1ZSVlFYQm5wb1ZnQkhyTlFMUVE4WUQzc2xBNmpLL0lvQkcyT3lR?=
 =?utf-8?B?QUhDOXlLNnZSbEJzcll3M2ZrYmxuU0Nhckg3WjNLdGJiT2p6UTFWdTRsS2I2?=
 =?utf-8?B?cHhYeGFvRW0yRHpTYXB3eG0zUEkvR09YQ3BlTVdXTENFM3d4TC92MHZXUWVQ?=
 =?utf-8?B?T1dhYm5UUDZQM1BzcWpuUWhmeWlUTklZdUwvS1o0NWROeXVZb2diejFJNE1n?=
 =?utf-8?B?ZmMzU3lOZ01mU3JML3h6eW5hUnJyWndXUW93YUZwNldWWC9EcFBObVBMNjhK?=
 =?utf-8?B?SVYva1YzRHlaTlhHZ2x3ZUpvcEcxRklYVnlIYnBVaU5xbDhrOEpMNDVQNXBW?=
 =?utf-8?Q?ctrC4ouxt0sPtUROhpqEkTEPZ?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 76983dcc-b293-4159-9761-08dc4483294c
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5978.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2024 00:02:10.5581
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZUleSFSS60tavNQLOGLNLUKOO92QwuqRBd359wL1hYKK00FaELyzHxluqCY4ZrV9bKdVYmbzXyNjw3gims7H6Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7917
X-OriginatorOrg: intel.com


On 26/02/2024 9:25 pm, isaku.yamahata@intel.com wrote:
> From: Kai Huang <kai.huang@intel.com>
> 
> KVM will need to make SEAMCALLs to create and run TDX guests.  Export
> SEAMCALL functions for KVM to use.
> 

Could you also list the reason that we want to expose __seamcall() 
directly, rather than wanting to put some higher level wrappers in the 
TDX host code, and export them?

For example, we can give a summary of the SEAMCALLs (e.g., how many in 
total, and roughly introduce them based on categories) that will be used 
by KVM, and clarify the reasons why we want to just export __seamcall().

E.g., we can say something like this:

TD;LR:

KVM roughly will need to use dozens of SEAMCALLs, and all these are 
logically related to creating and running TDX guests.  It makes more 
sense to just export __seamcall() and let KVM maintain these VM-related 
wrappers rather than having the TDX host code to provide wrappers for 
each SEAMCALL or higher-level abstraction.

Long version:

You give a detailed explanation of SEAMCALLs that will be used by KVM, 
and clarify logically it's better to manage these code in KVM.