Received: by 2002:ab2:2994:0:b0:1ef:ca3e:3cd5 with SMTP id n20csp467251lqb; Thu, 14 Mar 2024 17:29:51 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWW5vtBXCXYjawnMqFb8WPefpq/QHkKS2/8No5/I5XkD30egHcCjIg/a2/2gF+HKuIA9ohH74wfsXm/rAjtPHmAEeZELl7aCxLtAvtXbg== X-Google-Smtp-Source: AGHT+IFeahNTT18jmBLDfjIguVb97XBr34RWmQ6sr5IqYevo6cgEFEsmc4rKdzoLckzSa4eNVmUg X-Received: by 2002:a17:906:81d0:b0:a46:6174:db64 with SMTP id e16-20020a17090681d000b00a466174db64mr704652ejx.21.1710462591039; Thu, 14 Mar 2024 17:29:51 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710462591; cv=pass; d=google.com; s=arc-20160816; b=bVgkljF+kru+swcdDn7UxeGKVibQuLl00WIln7Watu77yKdgpokhELlu2x5gP3Z+Sq plDBHCiOVgprZ6DJ1rKKycI3syb+AcwlWXm6xIrlKsEsMJjqi9VQpMXO9kvOwNz6eMmf 7owlm4BF72D3qTYuTjVqCigOXeN5kEP6pA0+WWRAQtuCBCy+zjqw/NBW4+x14wisS4z8 gYJq/T9X+h/NQOfaXQkU13BUCHyGgJ8jd/nluJe3tPyPespnD4rLyyTr5V3ozPwgXgQ2 PBGtTEaOKVgPQnzFqJ3ykJ60wqv684FhrZwwX4BWYkw/k6yhg11HwhKvEbAP4vaglouC xxCA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=uNFfdKqq/05p9oLlTWJ5z9qjECgP4/UvCZ0QuH1OGV8=; fh=vRSgGrEY7Iuet9T/qRhtM/+ktj3xyGGImvrMRiq0Tzc=; b=S8rN/T9vyOL6mOVR+MI5OTKFwrwHplrk+1r2xfLhC0OPQNO0BUFU73Kj4Xsw3bUpfD mZa6mo46RCnsMl0xWgDlvrf3arf5n24xEkSQruK0UjuRV7d32gdC+oESaeEwGQtuYxoA iodtT+/5g5X+UiaXBY3V6kA7yxW3YSh+PLdQR7r4FMt9u0QxHxtZ8XF4ohjuTp7EfVr/ dJiudNgH/kPRA7tfv5miIlEGCMnWdoDsmjhcLPlO/0vld3WkYl0dCyn2uH2meti4ujJu VfaJuKc9zqv6kgYim3XJJ1pNE6gqNyf7YFcNHhuGJF3HQoS3rAH4+p8HAA0MLffbiG3T R4gA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=WfVC3ChO; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-103937-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-103937-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id o15-20020a170906288f00b00a461e236482si1157760ejd.631.2024.03.14.17.29.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Mar 2024 17:29:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-103937-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=WfVC3ChO; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-103937-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-103937-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id C0D871F21CE9 for ; Fri, 15 Mar 2024 00:29:50 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 961D717F5; Fri, 15 Mar 2024 00:29:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="WfVC3ChO" Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C195635 for ; Fri, 15 Mar 2024 00:29:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710462578; cv=none; b=mjCpj2mdJNsdV1qCGDTh+YmPGIPclEjM4ZczyDuFFmD6FFT0TgLv5Vq/40+mrfp64PwOxtjDpwqUoCixTrubc+PxKKT/+7jBG0smghaz4jHpY5eKNn+Ps7Mt5MACttJUeD/4cLx8E16Y0VNyLZpHBWZn72TVv9UbPcHGzIbNFFg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710462578; c=relaxed/simple; bh=+8bX23t2xarizQFcQxqmoBbiKjw9SKjnmnIQlaEiIVI=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=BCZwHYRjHOBiYXYtPu9o3SCRj1WZqggkJQeFkrZ57ZFUZzW62Q8bdOkMEZpSlWmqT1G5QuGtgeb2TkncXv5a4N/Q4CopsAND46prZYMHli8iIGG5OZ2HT3eKI9LabdeBnw2G2zzAypr59IT1ZxXCAupLpfmVNIXMkAP5Q+kKGCQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=WfVC3ChO; arc=none smtp.client-ip=209.85.167.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-oi1-f172.google.com with SMTP id 5614622812f47-3c19aaedfdaso1053028b6e.2 for ; Thu, 14 Mar 2024 17:29:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1710462576; x=1711067376; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=uNFfdKqq/05p9oLlTWJ5z9qjECgP4/UvCZ0QuH1OGV8=; b=WfVC3ChOzDZnHM0dKeUqMoHkWvKRxAlM7bAfMMXLBelD/BAFPVuwZsEKh96HwHTm5x 8IRsWtZQgmdToIF1ycojkk7Uq7woJExjDQ6VxOytEhsSuHfFtgGY+38r5QfnFQydhehl 4YKyYb3ABLM+wdOC99siuvByTiFY/c++Y3G+g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710462576; x=1711067376; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uNFfdKqq/05p9oLlTWJ5z9qjECgP4/UvCZ0QuH1OGV8=; b=nmRWRibW4zB6JtQRioQBADgb9R0IDgQD5rb66tS2cENRDDM2tcJuriffofpKKEhiDp WyRMFtmS1znFwHJjwgVxkcMBV5NzyEu2HvpFczyDYyZBcHK5zfgZCd4v2mp55YyE8i1G hj+xAoVDiY2XWaLOkAMaXZdK91DXFKB+7HNf69/JMNpWQ9gIFFfQoPSU/4fUuBllWEXK urBABZw7lQZ5uc/g0h3+fhTQBaNcDqIyOncxhJWBRwNQ9n5KwMu9oBLv/3Md7swLwwJG AaCKg+hc5517QAZQ9pxVp3rYss2Gr1bqrOcGXrOwHafOOVNQHxwtVOsWNH62JX68bAAz 5aGw== X-Forwarded-Encrypted: i=1; AJvYcCV3nAe1RQOTvE71DgCegEUiErI0eO7mfYiTHEnA9mw6ZbxfflJXxfieJzSLtkVHDMF0a6TfuwlZFqYvFWaaOdxlU38xjtXGiF0nq/HZ X-Gm-Message-State: AOJu0YwaVr4+obUAeno6HpGxzhyzLy8fZ64RU/3cntxoF6keL8dZ+oIw 7IZHj3+Ayx3fe14ICjBDKGvpWNTMSwvIYLa64hqwww6qJoYucZOCNciCMmdElqj+kCfz7eFwcno ZF8Y0GRqnJ3VlfnWGEyKrM282lBheB9A54Fbu X-Received: by 2002:a05:6808:448a:b0:3c2:1805:8cfc with SMTP id eq10-20020a056808448a00b003c218058cfcmr4809915oib.53.1710462576367; Thu, 14 Mar 2024 17:29:36 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240314235554.90079-1-jthies@google.com> In-Reply-To: <20240314235554.90079-1-jthies@google.com> From: Prashant Malani Date: Thu, 14 Mar 2024 17:29:24 -0700 Message-ID: Subject: Re: [PATCH v1 0/1] usb: typec: ucsi: Check capabilities before discovery To: Jameson Thies Cc: heikki.krogerus@linux.intel.com, linux-usb@vger.kernel.org, bleung@google.com, abhishekpandit@chromium.org, andersson@kernel.org, dmitry.baryshkov@linaro.org, fabrice.gasnier@foss.st.com, gregkh@linuxfoundation.org, hdegoede@redhat.com, neil.armstrong@linaro.org, rajaram.regupathy@intel.com, saranya.gopal@intel.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Jameson, On Thu, Mar 14, 2024 at 4:55=E2=80=AFPM Jameson Thies w= rote: > > Hi Heikki, > > This patch updates the UCSI driver to better check the appropriate > capability bit before sending a UCSI command to discovery cable and > identity information. > > These have been tested on a the usb-testing branch merged with a > chromeOS 6.8-rc2 kernel. Let me know if you have any questions. > > Thanks, > Jameson > > Jameson Thies (1): > usb: typec: ucsi: Check capabilities before cable and identity > discovery Just something to keep in mind for future patches: it's OK to upload single patch submissions without a cover letter. BR, -Prashant