Received-SPF: pass (google.com: domain of linux-kernel+bounces-103941-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <3ce123c2-3e04-4ff0-99f3-bd402a47ecb8@intel.com>
Date: Thu, 14 Mar 2024 17:51:52 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: 32bit resctrl? (was Re: [PATCH v2] fs/resctrl: fix domid loss
 precision issue)
Content-Language: en-US
To: Peter Newman <peternewman@google.com>, Rex Nie <rex.nie@jaguarmicro.com>
CC: <james.morse@arm.com>, "x86@kernel.org" <x86@kernel.org>, "Luck, Tony"
	<tony.luck@intel.com>, Babu Moger <babu.moger@amd.com>, Borislav Petkov
	<bp@alien8.de>, <fenghua.yu@intel.com>, <ilpo.jarvinen@linux.intel.com>,
	<linux-kernel@vger.kernel.org>
References: <20240312075349.977-1-rex.nie@jaguarmicro.com>
 <fed6affb-c7f4-4992-8646-8f5a52c33966@intel.com>
 <CALPaoChnAt9+2=iVzpownX-bN+mb3Ujn_C=_QS2qsAph=LPSiA@mail.gmail.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <CALPaoChnAt9+2=iVzpownX-bN+mb3Ujn_C=_QS2qsAph=LPSiA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dTlRUnNwZ0JrcjFXTkZqM0FudDdZUWNhNHE5MmJkSzVyUDA4czNRUWJOYlJy?=
 =?utf-8?B?aytTUVp3VExZaWxBNTk0Z2owdzNqVmlCb0hTYTJLa3FGVnI0ampTeTdsYll4?=
 =?utf-8?B?dG9hZTNZTkd4NXZhTStrWmRBTUh5M0xuOGYrYU50NEx0NUNpaCtBTFNHZDFw?=
 =?utf-8?B?TW5RUUVQYjR2WlYxalFCc0c1MGRTekgyb1NSNEZXT2lMYlREOUR3RkJXVWx1?=
 =?utf-8?B?eWFjU0FRNUdOTW9GdVI2NFIrNHZYcWVUVndUTUVHbHY4VWpOR3cwMG52b1VX?=
 =?utf-8?B?OGJVMUFYay8xU3V1V2dxM200OTIrQzZHaEdXQUtlRThKUVJGdkp4Z0ViWHZF?=
 =?utf-8?B?a3daQjZLYVNYblVvQWRUeFp3Zk9LdzhJMEtuanB3a0xVQ0hvMEFpV1E2Qnd1?=
 =?utf-8?B?K3g2eGNGT0hDMUkxV01MS1NvaDBwejc3WjY1WFhRUW1uWGRnekVmZGIxYXEr?=
 =?utf-8?B?b0dyZUh0RFlLMlQvK2w2ZFJueFFNekd2NFhsb1QxNjQ2dmg5QURmN2JKUnJ1?=
 =?utf-8?B?b0xpWmhwSkM2aGRqdDNEaXQ4dzBLblV2VTg4TzFyZ1BmWTUvZk1NT0h5UFRr?=
 =?utf-8?B?L3Z2c2FTL1pnSmtTK0YzY3NsV0VwTnNxRHoxWkpVUFVKMDkvRGlrdFNiRDJh?=
 =?utf-8?B?d1dRZGN4a0RHNDZKNmZ2NC9VN1ZaclZqK0hQQ21NaUdtYVZvYUhlTVhxb2NY?=
 =?utf-8?B?MDRtZm02MWdCR2luTkF0ZFFXWjMvaktPdmJNTVpsQk4xaXo2LzF2UlUxTk0v?=
 =?utf-8?B?Wnp3UytsOS9ENmU0K2xZUFgzU3hDRnN5NW5ZQjB3WHljOWlvazZxam1hUlA4?=
 =?utf-8?B?U2V6MlE5UUYxME1sN2FneWVWZkhYOTVaK0V4ektGWlBrSkVNZFp5MmFFb2ps?=
 =?utf-8?B?alF2Z21pVU5HYzR6STJBRG5jTlkxcjM0Mm94YkoxSlFjY3F1cUV3OVpLTHRH?=
 =?utf-8?B?bUpLemIrT0xabGsxdGJ2Tk9oK0lMN0xiYzhGRHM4SjhIZm1rSU1ON2c5Wk5X?=
 =?utf-8?B?NlNGV0ZzMUNvdXc2ajRjTDBic2cxQzlqSlhzbTJNOVdYaGhVbjVtWUw4Ly9H?=
 =?utf-8?B?UU5JMEl6c1JiUXVmcFBtcWY3ZzdjcHdjWmtFd3BIV0xMYzNraXMyQ09BWldZ?=
 =?utf-8?B?OUFVS2ZNNHBjcGUzT1BTaUZLSmI0cXNDdCtlQTNYbnY5ZlI5SFZpZjBPMDdq?=
 =?utf-8?B?cUE0c0ZndUxlRFNnOWdZa1NmRUpnTS9sbGduTU1KQzFxZlVsWmJ5NTRIYkpU?=
 =?utf-8?B?Q1NMWnBqcVhnN04zeldnWWVEZzIwSHBXZEZlMHk2TnNKU0E1bmJzRjlIYjc4?=
 =?utf-8?B?a0R4cjZIcExwRlNONXNwOWlBOG9LMUYvRTIxd0Q5WHVhTWlzODYrWXpqeWJR?=
 =?utf-8?B?cTZVTklFTzU5VGtrSkJUa2ZSdGJ1YVhXU2owck1SZzZwYWJEMk90YTYwd0R3?=
 =?utf-8?B?MStuTkJtbGtYdUVyeUNxYit6L0pKeC92OWp4ZEJudWh6dnhqN1JaY05oa2Nq?=
 =?utf-8?B?QkVUWmE1MHRKalI3UTRQQ0E2Z1lpTkRqY014KzNnTzRQVUdMWVU5QzI0OTFj?=
 =?utf-8?B?M2hGNGlYdXM3ZFRSbDhVZEZEcHR6d2hlUDRzaFlJWWUyMzhXdlNWQzBNMExN?=
 =?utf-8?B?Y2ZDakFoZUFMdURWYWptWkNVVHR4aG81RkJ3amFrVmVWLzlJNWcxcGM1OW5n?=
 =?utf-8?B?L0JmTUJhNGMwWkh4RTFxS1Z0RGVSTXNYT0pqcVBBN0Fqc1VjbWhEc0JQajNE?=
 =?utf-8?B?WHl0akNNdVRMbFhRZWlQcE1tUFFnSlE0TURHd1pOS3luTmlaaVZBTFpyM0JX?=
 =?utf-8?B?NWxON25SVEgxYjJ2NzBTb0FkeXAvZVpxNzF0MGQ2amd6N2hkcnZKbUw5ZXZK?=
 =?utf-8?B?Q2RFbThFNytTSFdobjRIU0ZlY3ZDekRBOE1aaVE5d3I0SmZMdUtjaEhjYzhV?=
 =?utf-8?B?R2JYdGIzSTNLRTJjeHgzL1RDVEc4cmtzTUN0WGRnLzdMWW5qR1N2TnVROTY3?=
 =?utf-8?B?NWphV2RWakU1amZ3T3JTcmlNajJYUkNVNG9jb1NyM293YXg4YlhGY2NNT0hV?=
 =?utf-8?B?b1BCeFhYcVJWU3lERzJwNzJkMnlEOVJ5dUlaaUFMOSs0TmExems4KzhMKzM0?=
 =?utf-8?B?czVVeE1yM0h6L1VRQ0Y4V3lvTkFMdG5CdUlqZjcrbGRvS09JYjFMZ2VMa0lC?=
 =?utf-8?B?cXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e28808b3-1d48-47a6-b07c-08dc448a1c3d
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2024 00:51:55.1186
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7IuxAv3V5FIdKXKpikFlx6RRAN1wrkF1v3bqsRv7hfD2obcefeGgudajDhovm7t9Tkp1XJr1J9yBWpm6dAqhGXRhqEr96XssfsI7lZXzcIg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5142
X-OriginatorOrg: intel.com


On 3/14/2024 5:04 PM, Peter Newman wrote:
> On Thu, Mar 14, 2024 at 8:25 AM Reinette Chatre
> <reinette.chatre@intel.com> wrote:
>>
>> +x86 maintainers, Tony, Babu, Peter
>>
>> Hi Everybody,
>>
>> On 3/12/2024 12:53 AM, Rex Nie wrote:
>>> Below statement from mkdir_mondata_subdir function will loss precision,
>>> because it assigns int to 14 bits bitfield.
>>>       priv.u.domid = d->id;
>>>
>>> On some platforms(e.g.,x86), the max cache_id is the amount of L3 caches,
>>> so it is not in the range of 0x3fff. But some platforms use higher
>>> cache_id, e.g., arm uses cache_id as locator for cache MSC. This will
>>> cause below issue if cache_id > 0x3fff likes:
>>> /sys/fs/resctrl/mon_groups/p1/mon_data/mon_L3_1048564 # cat llc_occupancy
> 
> This domain ID seems unreadable in decimal and I'm wondering whether
> it's the best value to use to identify the domain. Does this system
> have over 1 million L3 domains?

I propose that Rex includes the information about Arm's cache IDs [1]
in future changelogs.

Reinette


[1] https://lore.kernel.org/lkml/KL1PR0601MB577303C9D0B1247436BB06F8E6242@KL1PR0601MB5773.apcprd06.prod.outlook.com/