Received: by 2002:ab2:2994:0:b0:1ef:ca3e:3cd5 with SMTP id n20csp510021lqb; Thu, 14 Mar 2024 19:33:03 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUuJnfxyBl57TNWjtecOEhBI3J3kNC24YUhd4rHn9X4Z+rMe2Vr924IvOQcJgyn2SjLKNg/CEymdmHItZNDeQ/fd7XvsmwxpWRsQ/PR3A== X-Google-Smtp-Source: AGHT+IGCM7Ok7QccPr7JcOPCuPkN+g92eRhQfSf3JIekZzYZ5f1LvNZ0+Lmp4b2CXlgZrFiF7BV/ X-Received: by 2002:a05:6214:713:b0:690:c9fa:194b with SMTP id c19-20020a056214071300b00690c9fa194bmr3548838qvz.34.1710469983071; Thu, 14 Mar 2024 19:33:03 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710469983; cv=pass; d=google.com; s=arc-20160816; b=thwg9fFYKkGD1VJ/2eAf9Bl8wkv9O7T5Nr4f0bH/Jw00FE/DQ8jClvPdRgsOd+SHay NRrrFbjo5CliHLSmbIOokx1qTS6KXIWg+Z99RxcxiKEtVLrLTUxFFaYgCGp5MzubXxem eFVc1ZglMn4zY2Wp5AbYr/HLMOQXKgJDG4lQ37SdYdkEJCubN3vKrs3Sz2XqHNit57t8 0ievbaV2gYE1cCFNH8t68Bv0O2ucKSO6XmmHNFGo7DWrWOVfexNt7X67zyskzFPzNjuN FuaP0ynXBMwjv3lFllbRwYeDqZ1ayEOc3SwTM7+dM6UArXSEUT0PjA7Oysl6O0DLfsgq bNtA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:list-unsubscribe:list-subscribe:list-id :precedence:date:message-id:dkim-signature; bh=uWppkp/CDYn1IU8SGxz0loaKDXyaJFyU0HWPRcBekZI=; fh=95L1i3klccyWghDlqG+ueZkNussIKDsshwxuURNHIYM=; b=BNd9tQsU8cq1ufU3I5VNTXdr6/AYMnZeUjrG6wRxLBhxS5zWIfkevRe6mwKnpCWUnh +3B5Na4HDSKQE+5kl0xnDQhWDENHxrV981/hhSlONc3dlno+VT6nh22hPtglX3HPQFTD ZWPin700Ag02zPX/B0LJKkJeBK+eiTPSt+GYR9/KlX/Nt+oQTJlFUSIKRKbB9TsLHWKw lp8MTSF9u4Iu++XvrIeNE8wg7gJp1qlJ2QShrO8jfIUdyyESaN97u7bXgmM8gTPI/at7 Q1Vl3sU3aPG97NoL1ECIjlDuH6BoDDfPs16VO1QPJntB7wGgy6sA0TEJxMiPX3QWfQLI /Zig==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.alibaba.com header.s=default header.b=Ih+a+xQC; arc=pass (i=1 spf=pass spfdomain=linux.alibaba.com dkim=pass dkdomain=linux.alibaba.com dmarc=pass fromdomain=linux.alibaba.com); spf=pass (google.com: domain of linux-kernel+bounces-103990-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-103990-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.alibaba.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id r9-20020ad45769000000b0068fe8554c3csi2020378qvx.86.2024.03.14.19.33.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Mar 2024 19:33:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-103990-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.alibaba.com header.s=default header.b=Ih+a+xQC; arc=pass (i=1 spf=pass spfdomain=linux.alibaba.com dkim=pass dkdomain=linux.alibaba.com dmarc=pass fromdomain=linux.alibaba.com); spf=pass (google.com: domain of linux-kernel+bounces-103990-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-103990-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.alibaba.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id C8BC61C20EF6 for ; Fri, 15 Mar 2024 02:33:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 15D068C13; Fri, 15 Mar 2024 02:32:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="Ih+a+xQC" Received: from out30-132.freemail.mail.aliyun.com (out30-132.freemail.mail.aliyun.com [115.124.30.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC82C79D3; Fri, 15 Mar 2024 02:32:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.132 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710469974; cv=none; b=FpLbu0GdgEjIAA3YzTbb+B8421M1NhNYKtMQnW9hR0nwqKWF8K3KRZYDiyvtLu8GpzOqEnWfLh1R1RVG2DMFy2DaAxUDMM83m7qH7i4br4YC5r9j1gfxGi25rpjq16tvLccr/+qaBOdxV00g+fCPqg4EsJJsUFfQYlLijwxHxdc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710469974; c=relaxed/simple; bh=9j14obn7LJhO8DocmOfVRGauUW8ZOKLXG5D4pRwAFBA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lKLdNXtVCV2VYneta2nWFxauwHXP+xjOokPsXqZ+K7ByFNDI5n/OyyghMXY6R1n8UFr3AM26+H4IQH2sRtx32pbvJPmFPrbM6dQVehSRgKufCkz4fwRzDbPhZR1LHzJ9wdv8tY0ldV4S01QleT+TaduQ3NwhtDN4yYIbgEwa73w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=Ih+a+xQC; arc=none smtp.client-ip=115.124.30.132 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1710469963; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=uWppkp/CDYn1IU8SGxz0loaKDXyaJFyU0HWPRcBekZI=; b=Ih+a+xQC/wzNtKFtMAd6uzxbbpp1KtFPmyxhsxW+QPHKrPBqRL5RZLxkWb1O7h/7jUAFdZWfoy8KGxKUzfCbR6U6XweEwIl/kmtero5oueZOr/XAV/pUoc1TS3qtMqsoZumc4TnvstwHabw7K1hk4EKl6CgERrtfaNzd9rPKI2s= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R761e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=hengqi@linux.alibaba.com;NM=1;PH=DS;RN=16;SR=0;TI=SMTPD_---0W2UXABh_1710469953; Received: from 30.221.148.72(mailfrom:hengqi@linux.alibaba.com fp:SMTPD_---0W2UXABh_1710469953) by smtp.aliyun-inc.com; Fri, 15 Mar 2024 10:32:41 +0800 Message-ID: <143ea675-97e5-42ab-b8e6-55b2675294c3@linux.alibaba.com> Date: Fri, 15 Mar 2024 10:32:32 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 0/2] net: provides dim profile fine-tuning channels To: Jakub Kicinski Cc: "David S. Miller" , Tal Gilboa , Eric Dumazet , Paolo Abeni , Jason Wang , "Michael S. Tsirkin" , Xuan Zhuo , Jonathan Corbet , Randy Dunlap , Bjorn Helgaas , Breno Leitao , Johannes Berg , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux.dev References: <1710421773-61277-1-git-send-email-hengqi@linux.alibaba.com> <20240314114955.71ada20c@kernel.org> From: Heng Qi In-Reply-To: <20240314114955.71ada20c@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit 在 2024/3/15 上午2:49, Jakub Kicinski 写道: > On Thu, 14 Mar 2024 21:09:31 +0800 Heng Qi wrote: >> The NetDIM library provides excellent acceleration for many modern >> network cards. However, the default profiles of DIM limits its maximum >> capabilities for different NICs, so providing a channel through which >> the NIC can be custom configured is necessary. > Given that DIM is currently enabled and disable via ethtool > why are you putting the API is sysfs and ops in ndo? Hi Jakub, Thank you for reaching out. We're flexible regarding configuration methods and are open to using either sysfs or ethtool, depending on what's most appropriate for the task at hand. If the ethtool is favored, I am happy to proceed with it! Best regards, Heng