Received-SPF: pass (google.com: domain of linux-kernel+bounces-103993-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: zhangzhengming <zhang.zhengming@h3c.com>
To: <lulie@linux.alibaba.com>
CC: <akpm@linux-foundation.org>, <alibuda@linux.alibaba.com>,
        <dust.li@linux.alibaba.com>, <gregkh@linuxfoundation.org>,
        <guwen@linux.alibaba.com>, <hengqi@linux.alibaba.com>,
        <kunyu@nfschina.com>, <linux-kernel@vger.kernel.org>,
        <nabijaczleweli@nabijaczleweli.xyz>, <xuanzhuo@linux.alibaba.com>,
        <zhang.zhengming@h3c.com>, <zhao_lei1@hoperun.com>,
        <zhou.kete@h3c.com>
Subject: Re: [PATCH] relay: avoid relay_open_buf inproperly fails in buffer-only mode
Date: Fri, 15 Mar 2024 10:39:12 +0800
Message-ID: <20240315023912.13390-1-zhang.zhengming@h3c.com>
In-Reply-To: <20240220105836.15815-1-lulie@linux.alibaba.com>
References: <20240220105836.15815-1-lulie@linux.alibaba.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

> diff --git a/kernel/relay.c b/kernel/relay.c
> index a8e90e98bf2c..0d8b8325530a 100644
> --- a/kernel/relay.c
> +++ b/kernel/relay.c
> @@ -391,12 +391,13 @@ static struct rchan_buf *relay_open_buf(struct rchan *chan, unsigned int cpu)
>  			goto free_buf;
>  		relay_set_buf_dentry(buf, dentry);
>  	} else {
> -		/* Only retrieve global info, nothing more, nothing less */
> +		/* In buffer-only mode, relay_open_buf is called with
> +		 * filename=NULL, but create_buf_file is still needed to
> +		 * retrieve is_global info. So dentry should be NULL here.
> +		 */
>  		dentry = chan->cb->create_buf_file(NULL, NULL,
>  						   S_IRUSR, buf,
>  						   &chan->is_global);
> -		if (IS_ERR_OR_NULL(dentry))
> -			goto free_buf;
>  	}
>  
>   	buf->cpu = cpu;
I suggest replacing IS_ERR_OR_NULL with IS_ERR instead of removing it due to the possibility of create_buf_file callback returning an error.