Received-SPF: pass (google.com: domain of linux-kernel+bounces-104011-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <b1d59c5e-26ae-45a8-8677-13d2bb5e9751@amlogic.com>
Date: Fri, 15 Mar 2024 11:13:16 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [DMARC error][DKIM error] [PATCH 3/4] arm64: dts: add support for
 A4 based Amlogic BA400
Content-Language: en-US
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 Dmitry Rokosov <ddrokosov@salutedevices.com>,
 Xianwei Zhao via B4 Relay <devnull+xianwei.zhao.amlogic.com@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>,
 Neil Armstrong <neil.armstrong@linaro.org>,
 Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
 Jerome Brunet <jbrunet@baylibre.com>, Kevin Hilman <khilman@baylibre.com>,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org
References: <20240312-basic_dt-v1-0-7f11df3a0896@amlogic.com>
 <20240312-basic_dt-v1-3-7f11df3a0896@amlogic.com>
 <20240313095311.dxrr7gvt4t3gwoho@CAB-WSD-L081021>
 <74f96887-572d-47eb-bce4-9d61ec51b88d@amlogic.com>
 <c0e564f1-bfd9-450f-8bce-835837719688@linaro.org>
From: Xianwei Zhao <xianwei.zhao@amlogic.com>
In-Reply-To: <c0e564f1-bfd9-450f-8bce-835837719688@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QjlKVmJjUlZWNUUyeG1CQ1FxSWt0UHlLbytEczA4TGt5L2pGREdLUFIrVjBZ?=
 =?utf-8?B?a25zbkcwb1ZyekNQbmR6UmNnU2p5WS9BcnY3SUFTWkU3dGYzQUtzSjB0VUla?=
 =?utf-8?B?TGUrZWJoQTFYRmZnUGRTVk5OdkVWVEdhRHFJZm01eWsycW9CUTNLSGt3TDJj?=
 =?utf-8?B?R1dycDV0amtwUXhJK2dOS3E2MUdFcFl2bzNIV2lmazAyWm5jMUpUMFR3Y0Rl?=
 =?utf-8?B?c2EzNnZQYWpnOHV3ZVBXTjliVEtBMGN2YnF0cUhSM0loaVlWYUZaRDU0S3BF?=
 =?utf-8?B?cHFNbnRiVlFBMEhCZzFvWExTUGZ3QURrclNKSEc4aEJiRVAzcE5RNmM2QWFt?=
 =?utf-8?B?WU9XMVZROUxKY1hVQ0U4dktnWDVxZWJXcExuQ252Q2VINFFEZnFzMDZrREdq?=
 =?utf-8?B?RUh5TzVVdndtQzZBRlY3bUtNY0JJdG9Xc2FpNkYxM0NQenFzSWtoTml1OVBF?=
 =?utf-8?B?OUQ5UmFIVmowQTRpWk5GQythQWpvSzlZQnQ3ZFVYSlc0dDFNRll5QlRHc3pm?=
 =?utf-8?B?VXNEeWNVTlFzcXRuODhjdUFrMXBGMm9PdGxRZWFoL2JHK2pTSGJjMSs3OGRP?=
 =?utf-8?B?OVdoQkpkNk05OFFqbVdJNm9pQnZEcDdNVHJRRE82eVMvV09aaWcwVWIzdk9O?=
 =?utf-8?B?cVlVK3FUYjJCQStZZzJyRWY0OVk3ZDNYenh6NGQvVFBxQTUwc05Cd2l4RUs1?=
 =?utf-8?B?SUgrSkJkRzhKazQxbXdlUjJWa092YmpVTUVJTXBhTVlHaElKSUpLcm9OSXN3?=
 =?utf-8?B?RjkyVDdGQ1JrL3BFbTl3VThXQk9hM1llWWR4bW9OY3dqdmMzUjdQKytleEJn?=
 =?utf-8?B?ZHVBMEF4S3pRRGFSUG5TRTFkWFcwYVNOVjgvZUE5SW0vbVpUb01tL1VFOEdK?=
 =?utf-8?B?b3dJaFZHNlBKZzRDKzU4RSs2amY3Qlg3akIwSkJ6eUFNUnFrWWppMzJKMGRa?=
 =?utf-8?B?dHpxa3hiblUyUlpHeTFDL2cyRzdzQ2dYL1l4ZUh0b2pyMGVDeXdkZE0zeS9I?=
 =?utf-8?B?MkgwanV2NGtEVk1aaGRESW53Z0NvZmlCbjBLMkxkazNHUDNFS1V2MncybnBC?=
 =?utf-8?B?RmlMY0tNZG8wQWwycUlLbngySWxTQnpsa1RpY1JRZWFxREcwMmdKdDk3OFVI?=
 =?utf-8?B?dTJqcm9rYnZQQmlTVldoU29HOTRvbFhrdTNvck1ySTV4OU1BMnpQN28xNnF1?=
 =?utf-8?B?Q1UyL3lqcWNoS3NTZXphRkdUVzVPdjhmelVRVGVMdlNWN2VBTzJtYXVZejBi?=
 =?utf-8?B?cFZ4OUpTeW01YVJReVBrWVNMSTdnbmlnNERFVTcwUWtOM2lObCtTKzNUWjdI?=
 =?utf-8?B?SFErV3ZVN3loOEY3K2R5YXhQMWhtMk9lZ2dYWk1Uc0dJOEhYa214ZEdMeG9F?=
 =?utf-8?B?RlZMN25sN3NHK1REdHR4R3YyanoyTjBFV0lmeVRoM09reXplOUdyN01uQzh5?=
 =?utf-8?B?SElqN0Y1YlYxMzFTYWRrS3RVS29ialpuMUV5aGhrVmtmWHhxeWlqU3NDb1VS?=
 =?utf-8?B?TzNYcnBqcGpxTjk0bTNzci9lV1FBUUYrVnYyTEx1Vlp6VWFwdmJjakY5Y2Z5?=
 =?utf-8?B?SlhjWjZ2Q1c3eWt1WVRZb1paZXNsSmlSTTdXLzFDa3M1SjdOc2Vsb3BsV3NZ?=
 =?utf-8?B?UXVvalFvRGZ6NDZZR3hqbnN0S1F5VWVTUE5lUmdnY1kvNllnOHJDZFNtdkwz?=
 =?utf-8?B?UitzeTZsREtTckE4b2JXaG9lc3ArUmErc2JaSzlibWhJbExsLyszcUhZbW52?=
 =?utf-8?B?cTJCdWdmT2xqQ0xvWDhHSXdmK2lac1F5dldIdGttV1c4WDgwSVlNd2VwTldn?=
 =?utf-8?B?dnh4MWZCS1BGQVZJQkxoOXpKU0lRbGhDdVRvWndpMXk1SE5KM2lrM2JkRTRK?=
 =?utf-8?B?R2d0WnNEWXJnYTBaUENQTFJmZ0hmNDJScnFmcW9sY1pQSnIxL09XMFRlU05v?=
 =?utf-8?B?K3pBUFBXL0lXeFlBN3FCU3A2elMzTTVJcnk5c0dwZDFpaGhiTlJOTFc3UGNY?=
 =?utf-8?B?WXhtM0dyZDlnYjlHbEdpb2FHR1dDUWl2N002eE9ZR3dqeC90NXFvUnJZYTIr?=
 =?utf-8?B?VXRTUmFtUmkxMU1sQXZ0aXdwUXhUd3E1ekRhSmdjeHVHL3ZkclpMUm1DTUJY?=
 =?utf-8?B?anN1RW1BblZKR1kyQTFadm44NWZmL0JnUWNIL0tOK0d6QnBIZUdIWDAzMXBK?=
 =?utf-8?B?NXc9PQ==?=
X-OriginatorOrg: amlogic.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 82c34e65-f177-4123-53d1-08dc449ddf2f
X-MS-Exchange-CrossTenant-AuthSource: TYZPR03MB6896.apcprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2024 03:13:22.6465
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0df2add9-25ca-4b3a-acb4-c99ddf0b1114
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SmAT9cBUPyaiHW0OJYn+/+A1wQCveCoKHb+UHgEY4EHm/QZTepqmYI0srUq1iUXzL6okqte/fu/rVDhkipi30QqKi21sx5JBUQM/h7avqN4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR03MB9049

Hi Krzysztof,
      Thanks for your reply.

On 2024/3/14 14:58, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
> 
> On 14/03/2024 06:19, Xianwei Zhao wrote:
>>>> +
>>>> +             apb@fe000000 {
>>>> +                     compatible = "simple-bus";
>>>> +                     reg = <0x0 0xfe000000 0x0 0x480000>;
>>>> +                     #address-cells = <2>;
>>>> +                     #size-cells = <2>;
>>>> +                     ranges = <0x0 0x0 0x0 0xfe000000 0x0 0x480000>;
>>>> +
>>>> +                     uart_b: serial@7a000 {
>>>> +                             compatible = "amlogic,meson-s4-uart",
>>>
>>> If I'm not wrong, you need to create dt-binding alias for meson-a4-uart
>>> and use it as 3rd compatible string.
>>>
>> On UART module, A4 and A5 SoCs exactly the same as S4. There's no
>> difference.
> 
> That's not really the point. You are supposed to always provide SoC
> specific compatible in front of the fallback. See writing bindings document.
> 
Will add bindings.
If two chips use a common dtsi, and this module is in the common dtsi, 
can I only add one to suit this two chips?
> 
> Best regards,
> Krzysztof
>