Received-SPF: pass (google.com: domain of linux-kernel+bounces-100448-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 12 Mar 2024 17:36:03 +0200
From: Andy Shevchenko <andy@kernel.org>
To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= <u.kleine-koenig@pengutronix.de>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>, kernel@pengutronix.de,
	linux-kernel@vger.kernel.org, Paul Burton <paulburton@kernel.org>
Subject: Re: [PATCH 3/3] auxdisplay: img-ascii-lcd: Convert to platform
 remove callback returning void
Message-ID: <ZfB2Y1P5VRZWEUqu@smile.fi.intel.com>
References: <cover.1710194084.git.u.kleine-koenig@pengutronix.de>
 <44de2d4c1fed6fe96b68ba9ad768d297b8f392a5.1710194084.git.u.kleine-koenig@pengutronix.de>
 <CAMuHMdVvmN2xns_76zSDpUX-v8V16mSP12A=Y4gght9cdgNb+A@mail.gmail.com>
 <r5ydocz3u3ng6voax2iveoqvvqpuo6s3defjkpqzmuoj222clw@76ilb4kbjlrw>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <r5ydocz3u3ng6voax2iveoqvvqpuo6s3defjkpqzmuoj222clw@76ilb4kbjlrw>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Tue, Mar 12, 2024 at 11:27:37AM +0100, Uwe Kleine-König wrote:
> On Tue, Mar 12, 2024 at 09:17:54AM +0100, Geert Uytterhoeven wrote:
> > On Mon, Mar 11, 2024 at 10:59 PM Uwe Kleine-König
> > <u.kleine-koenig@pengutronix.de> wrote:
> > > The .remove() callback for a platform driver returns an int which makes
> > > many driver authors wrongly assume it's possible to do error handling by
> > > returning an error code. However the value returned is ignored (apart
> > > from emitting a warning) and this typically results in resource leaks.
> > >
> > > To improve here there is a quest to make the remove callback return
> > > void. In the first step of this quest all drivers are converted to
> > > .remove_new(), which already returns void. Eventually after all drivers
> > > are converted, .remove_new() will be renamed to .remove().
> > >
> > > Trivially convert this driver from always returning zero in the remove
> > > callback to the void returning variant.
> > >
> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > 
> > Thanks for your patch!
> > 
> > > --- a/drivers/auxdisplay/img-ascii-lcd.c
> > > +++ b/drivers/auxdisplay/img-ascii-lcd.c
> > > @@ -279,13 +279,12 @@ static int img_ascii_lcd_probe(struct platform_device *pdev)
> > >   *
> > >   * Return: 0
> > 
> > Please remove this line.
> 
> Good catch, thanks.
> 
> @Andy: Should I resend this patch? Or the whole series? Or do you want
> to fixup while applying?

Not big deal, I'll fix it whilst applying.
Thank you!

-- 
With Best Regards,
Andy Shevchenko