Received-SPF: pass (google.com: domain of linux-kernel+bounces-99478-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Chad Monroe <chad.monroe@adtran.com>
To: Rob Herring <robh@kernel.org>, Daniel Golle <daniel@makrotopia.org>
CC: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley
	<conor+dt@kernel.org>, Ulf Hansson <ulf.hansson@linaro.org>, Jens Axboe
	<axboe@kernel.dk>, Dave Chinner <dchinner@redhat.com>, Jan Kara
	<jack@suse.cz>, =?iso-8859-1?Q?Thomas_Wei=DFschuh?= <linux@weissschuh.net>,
	Christian Brauner <brauner@kernel.org>, Li Lingfeng <lilingfeng3@huawei.com>,
	Damien Le Moal <dlemoal@kernel.org>, Min Li <min15.li@samsung.com>, Adrian
 Hunter <adrian.hunter@intel.com>, Hannes Reinecke <hare@suse.de>, Christian
 Loehle <CLoehle@hyperstone.com>, Avri Altman <avri.altman@wdc.com>, Bean Huo
	<beanhuo@micron.com>, Yeqi Fu <asuk4.q@gmail.com>, Victor Shih
	<victor.shih@genesyslogic.com.tw>, Christophe JAILLET
	<christophe.jaillet@wanadoo.fr>, "Ricardo B. Marliere"
	<ricardo@marliere.net>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>, Diping Zhang
	<diping.zhang@gl-inet.com>, Jianhui Zhao <zhaojh329@gmail.com>, Jieying Zeng
	<jieying.zeng@gl-inet.com>, Adam Fox <adam.fox@adtran.com>, John Crispin
	<john@phrozen.org>
Subject: RE: [EXTERNAL] Re: [RFC PATCH v2 1/8] dt-bindings: block: add basic
 bindings for block devices
Thread-Topic: [EXTERNAL] Re: [RFC PATCH v2 1/8] dt-bindings: block: add basic
 bindings for block devices
Thread-Index: AQHacKKp9hC8jPZxIEu5tTtMXn0DXrEy9RtQ
Date: Mon, 11 Mar 2024 19:40:24 +0000
Message-ID:
 <PH0PR19MB4844582040B0622565ED11ED8D242@PH0PR19MB4844.namprd19.prod.outlook.com>
References: <cover.1709667858.git.daniel@makrotopia.org>
 <f70bb480aef6f55228a25ce20ff0e88e670e1b70.1709667858.git.daniel@makrotopia.org>
 <20240307145102.GA2550133-robh@kernel.org>
In-Reply-To: <20240307145102.GA2550133-robh@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?iso-8859-1?Q?6IPSMAkbJzdgr0qd1+BZdu12uMQbZFZM4r4wVs8xsWYngIVyGTkbphvrS+?=
 =?iso-8859-1?Q?v3k4vAbG0ATWWLYvltGXHlomHG8gQFHnazVBCPtkIzuH1ct/KMRk3oNhYS?=
 =?iso-8859-1?Q?hIqnhSY+ZaACOjgmng0exvQhjK4mcVTH73pAGCXnjc+Ck9Ag/5D9s/1ssc?=
 =?iso-8859-1?Q?Df5SNIYWAyMDPQVmFZ7V1U8zU0X4ZP9FQ+rxbjnQzcQD/UlI+6+7RK1i+q?=
 =?iso-8859-1?Q?PJqoALeysp/P9L4N2To3MmAtjf1ybX3jLJGs+dm14y4wV9kXira9Bct1wN?=
 =?iso-8859-1?Q?ebsJHMq9jeBvmh2fjPe5448fXUEn9wk4k6HAwUtq4hWhOuwjRBo/Y3AQyx?=
 =?iso-8859-1?Q?cJAYOQTiN9AfKspp/eU3y+K+AfHmhDM4Sb4PKICIlVPUFxB7K5SULxMHC4?=
 =?iso-8859-1?Q?NqvN8HNVenn6ZM1lMDjjJqTGBRGWRE+8pSNqicgK+V90xtQ6A7rPshnpSz?=
 =?iso-8859-1?Q?aTZJoQJ7tILHW4L0gDMOVGjFYQ960SRAwoIo5GW5V/oRtBEAsWCeCVzFky?=
 =?iso-8859-1?Q?c2ZZz7QSoCYiyVJPJ8LL4nD42YScyZ4l4qmeQpoG4N8lK8lozA8XD05h/z?=
 =?iso-8859-1?Q?42RkHT4UwtPa9HipGRkTdZweMp/rrPAFIfxNxiHqRGK8g7R0JehxeDlWOb?=
 =?iso-8859-1?Q?pq7lsQsyPfPEdj+PcADLdFelJbtNM0Ido7RgGMfO+gMWfv3KUcouV+bkQA?=
 =?iso-8859-1?Q?ZjpxuVUDOI7wz4tqD52s0ZWE7hQPMmRZf0rwitNLyzp2hkn5DE1dDxQRQq?=
 =?iso-8859-1?Q?nN5AjaUBIuuKs9628NaFWzhQ+1pJvvyd2P9BXniBkMEpRoZOcu7fGv+La3?=
 =?iso-8859-1?Q?/q9hkrZCmQZ8y/tN0YJitB8q/hCLM2MUoH6RChf1IG1PJdyumct6lbSt9B?=
 =?iso-8859-1?Q?Jwj3i3CNUwYaraji9HRc60GTJo3fBjOBi+ykiebySqpGyLVCw9YGM7+1vO?=
 =?iso-8859-1?Q?/IuQjVDA+KW3e40qJbWiH787WvOPIZ8RkvlAwM0PNBBtARJCFErCcdngNO?=
 =?iso-8859-1?Q?4YsmT0SxiYceAS9uJQC80CsNK5oczE7BwwvyFGjP+kjhnI7Ra63Yd8Jv36?=
 =?iso-8859-1?Q?nXn6/IIEyqu8IKm72Y2utK0k+ef2b8xt6YdSo/TTBvxwV9LtW+DFWWu7AT?=
 =?iso-8859-1?Q?FrhsP24MjQBfpDwRzl2sbSfnrKa3gfyh20u0WNjBG5BAFOXaGqkWwiUVhQ?=
 =?iso-8859-1?Q?p7IelNBLavhRgWgWAcqrswS36gIzF9lbyhnkuq8gM5L3Kce9qS84tOxXQq?=
 =?iso-8859-1?Q?GDbOjd1mYniAm+1E1M0G+/Gnj9GpGoVfOw6sY3B66JCDd97GcUeuNv+zu9?=
 =?iso-8859-1?Q?v8elka8Q2TBTpzBDgpa2N+SNE5WMBt+mfUvNjiY7XGGJtRapu2AfcwyIvm?=
 =?iso-8859-1?Q?wEy22mGaAdTD/KGHc2GLgMs+nCMU0EllEkxJ54ipooZZ8cacG1zLR8zfYx?=
 =?iso-8859-1?Q?Ws118Ube9YXZG2Vynj4gt4rEzOyNu5HJ/w13e7R1IQtf4urlVuRhPA2IiT?=
 =?iso-8859-1?Q?ze++QkT+Z11ltkSXgFn76jow1Ux5CR0XR6xgf2qD0oR/toMMrrzO5ohaB1?=
 =?iso-8859-1?Q?86fx/+e8riHJRMFupupH3jGw3rum07NZsd5eusYTJTbbfdpLWvCh/MrLgC?=
 =?iso-8859-1?Q?49t40ae23HYlqbqCpq4ZX7sHdLgXwwgTqt?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: adtran.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR19MB4844.namprd19.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 57620b99-af3a-4a7f-686c-08dc42031886
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Mar 2024 19:40:24.3033
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 423946e4-28c0-4deb-904c-a4a4b174fb3f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: C1OtquyqKU/psEGqWY7Xf6z2q7qnYd7+GJn8O4REhi+C+F/oYUoZ/+PEJGw+mAJb2/YPENrpe8v3DDz9K7lUgg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR19MB4352


> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: Thursday, March 7, 2024 6:51 AM
> To: Daniel Golle <daniel@makrotopia.org>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley
> <conor+dt@kernel.org>; Ulf Hansson <ulf.hansson@linaro.org>; Jens Axboe
> <axboe@kernel.dk>; Dave Chinner <dchinner@redhat.com>; Jan Kara
> <jack@suse.cz>; Thomas Wei=DFschuh <linux@weissschuh.net>; Christian Brau=
ner
> <brauner@kernel.org>; Li Lingfeng <lilingfeng3@huawei.com>; Damien Le Moa=
l
> <dlemoal@kernel.org>; Min Li <min15.li@samsung.com>; Adrian Hunter
> <adrian.hunter@intel.com>; Hannes Reinecke <hare@suse.de>; Christian Loeh=
le
> <CLoehle@hyperstone.com>; Avri Altman <avri.altman@wdc.com>; Bean Huo
> <beanhuo@micron.com>; Yeqi Fu <asuk4.q@gmail.com>; Victor Shih
> <victor.shih@genesyslogic.com.tw>; Christophe JAILLET
> <christophe.jaillet@wanadoo.fr>; Ricardo B. Marliere <ricardo@marliere.ne=
t>;
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>; devicetree@vger.kernel.o=
rg;
> linux-kernel@vger.kernel.org; linux-mmc@vger.kernel.org; linux-
> block@vger.kernel.org; Diping Zhang <diping.zhang@gl-inet.com>; Jianhui Z=
hao
> <zhaojh329@gmail.com>; Jieying Zeng <jieying.zeng@gl-inet.com>; Chad Monr=
oe
> <chad.monroe@adtran.com>; Adam Fox <adam.fox@adtran.com>; John Crispin
> <john@phrozen.org>
> Subject: [EXTERNAL] Re: [RFC PATCH v2 1/8] dt-bindings: block: add basic =
bindings
> for block devices
>=20
> On Tue, Mar 05, 2024 at 08:23:20PM +0000, Daniel Golle wrote:
> > Add bindings for block devices which are used to allow referencing
> > nvmem bits on them.
> >
> > Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> > ---
> > .../bindings/block/block-device.yaml | 22 ++++++++
> > .../devicetree/bindings/block/partition.yaml | 51 +++++++++++++++++++
> > .../devicetree/bindings/block/partitions.yaml | 20 ++++++++
> > 3 files changed, 93 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/block/block-
> device.yaml
> > create mode 100644 Documentation/devicetree/bindings/block/partition.ya=
ml
> > create mode 100644 Documentation/devicetree/bindings/block/partitions.y=
aml
> >
> > diff --git a/Documentation/devicetree/bindings/block/block-device.yaml
> b/Documentation/devicetree/bindings/block/block-device.yaml
> > new file mode 100644
> > index 0000000000000..c83ea525650ba
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/block/block-device.yaml
> > @@ -0,0 +1,22 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/block/block-device.yaml# <https://p=
rotect-
> de.mimecast.com/s/gI6FCDqGk9uBM0gMFZVG39?domain=3Ddevicetree.org>
> > +$schema: http://devicetree.org/meta-schemas/core.yaml# <https://protec=
t-
> de.mimecast.com/s/rGEGCEqJR9uWnMRnHZK6FQ?domain=3Ddevicetree.org>
> > +
> > +title: block storage device
> > +
> > +description: |
> > + This binding is generic and describes a block-oriented storage device=
.
> > +
> > +maintainers:
> > + - Daniel Golle <daniel@makrotopia.org>
> > +
> > +properties:
> > + partitions:
> > + $ref: /schemas/block/partitions.yaml
> > +
> > + nvmem-layout:
> > + $ref: /schemas/nvmem/layouts/nvmem-layout.yaml#
> > +
> > +unevaluatedProperties: false
> > diff --git a/Documentation/devicetree/bindings/block/partition.yaml
> b/Documentation/devicetree/bindings/block/partition.yaml
> > new file mode 100644
> > index 0000000000000..df561dd33cbc9
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/block/partition.yaml
> > @@ -0,0 +1,51 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/block/partition.yaml# <https://prot=
ect-
> de.mimecast.com/s/8Tf9CGRL65UJqGjqu07YGR?domain=3Ddevicetree.org>
> > +$schema: http://devicetree.org/meta-schemas/core.yaml# <https://protec=
t-
> de.mimecast.com/s/rGEGCEqJR9uWnMRnHZK6FQ?domain=3Ddevicetree.org>
> > +
> > +title: Partition on a block device
> > +
> > +description: |
> > + This binding describes a partition on a block storage device.
> > + Partitions may be matched by a combination of partition number, name,
> > + and UUID.
> > +
> > +maintainers:
> > + - Daniel Golle <daniel@makrotopia.org>
> > +
> > +properties:
> > + $nodename:
> > + pattern: '^block-partition-.+$'
> > +
> > + partnum:
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + description:
> > + Matches partition by number if present.
> > +
> > + partname:
> > + $ref: /schemas/types.yaml#/definitions/string
> > + description:
> > + Matches partition by PARTNAME if present.
>=20
> Why do we need something new here? The existing fixed-partitions can
> already define block device partitions. It just matches by
> address/offset which works whether its MBR or GPT. Also, in DT we always
> have an address when there is an address.
>=20
> I'm sure you want to statically define this and have it work even if the
> partitions move, but sorry...

The partitions which hold this data are typically defined as a MBR or GPT
partition and referenced by PARTNAME, PARTUUID or PARTNO. The data is
referenced as an offset within that partition. It's possible for the offset
of the RF/calibration partition to change if the size of eMMC chip changes
between builds of the same device for example. Within the RF partition the
data is always available at the same offsets.

Based on this, we don't always know the offset of the RF partition and
simply want to use the partition table to point us at the right location.

>=20
> > +
> > + uuid:
> > + $ref: /schemas/types.yaml#/definitions/string
> > + description:
> > + Matches partition by PARTUUID if present.
>=20
> If this remains it will need some work in the dtschema tools. The reason
> is json-schema already has support for UUIDs as a defined 'format' key
> value and we should use that.
>=20
> > +
> > + nvmem-layout:
> > + $ref: /schemas/nvmem/layouts/nvmem-layout.yaml#
> > + description:
> > + This container may reference an NVMEM layout parser.
> > +
> > +anyOf:
> > + - required:
> > + - partnum
> > +
> > + - required:
> > + - partname
> > +
> > + - required:
> > + - uuid
> > +
> > +unevaluatedProperties: false