Received-SPF: pass (google.com: domain of linux-kernel+bounces-99161-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Mon, 11 Mar 2024 15:58:29 +0000
From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
CC: Vasileios Amoiridis <vassilisamir@gmail.com>, <jic23@kernel.org>,
	<lars@metafoo.de>, <ang.iglesiasg@gmail.com>, <phil@raspberrypi.com>,
	<579lpy@gmail.com>, <linux-iio@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: pressure: Fixes SPI support for BMP3xx devices
Message-ID: <20240311155829.00004478@Huawei.com>
In-Reply-To: <Ze7XU5JS8FF5FZdg@smile.fi.intel.com>
References: <20240311005432.1752853-1-vassilisamir@gmail.com>
	<Ze7XU5JS8FF5FZdg@smile.fi.intel.com>
Organization: Huawei Technologies Research and Development (UK) Ltd.
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit

On Mon, 11 Mar 2024 12:05:07 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> On Mon, Mar 11, 2024 at 01:54:32AM +0100, Vasileios Amoiridis wrote:
> > Bosch does not use unique BMPxxx_CHIP_ID for the different versions of
> > the device which leads to misidentification of devices if their ID is
> > used. Use a new value in the chip_info structure instead of the
> > BMPxxx_CHIP_ID, in order to choose the regmap_bus to be used.  
> 
> ...
> 
> >  	const struct regmap_config *regmap_config;
> > +	int spi_read_extra_byte;  
> 
> Why is it int and not boolean?
> Also, please run `pahole` to see the best place for a new member.

Whilst that's good in general, there aren't many of these structs (4ish)
so if the 'cheapest' positioning isn't natural or hurts readability
ignore what you get from pahole.

Jonathan

>