Message-ID: <4783A41B.1090100@cosmosbay.com>
Date: Tue, 08 Jan 2008 17:26:03 +0100
From: Eric Dumazet <dada1@cosmosbay.com>
User-Agent: Thunderbird 1.5.0.14 (Windows/20071210)
MIME-Version: 1.0
To: Changli Gao <xiaosuo@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Improve scalability of epoll_ctl
References: <478397F7.1030005@gmail.com>
In-Reply-To: <478397F7.1030005@gmail.com>
Content-Type: text/plain; charset=GB2312
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1012
Lines: 25

Changli Gao a ??crit :
> Replace the epitem rbtree with a dynamic array to get the constant insertion/deletion/modification time of the file descriptors. Reuse the size argument of epoll_create, however the size must be smaller than the max file descriptor number: ether the resource limitation or the compiling time limitation.
>
>   
Hum, you should read this :

http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.7-rc3/2.6.7-rc3-mm2/broken-out/epoll-uses-rbtrees.patch


Your patch is a revert of this change, it probably wont be accepted.

epoll_ctl() is scalable, since it's O(log2(N)) : With 1 millions files
descriptors, that means less than 20 nodes to lookup in the tree.

In what situation do you think epoll_ctl() performance is bad ?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/