Received-SPF: pass (google.com: domain of linux-kernel+bounces-98843-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 11 Mar 2024 13:56:27 +0100 (CET)
From: Richard Weinberger <richard@nod.at>
To: Christian Heusel <christian@heusel.eu>
Cc: David Woodhouse <dwmw2@infradead.org>, 
	linux-mtd <linux-mtd@lists.infradead.org>, 
	linux-kernel <linux-kernel@vger.kernel.org>, 
	kernel-janitors <kernel-janitors@vger.kernel.org>
Message-ID: <1349276201.40757.1710161787719.JavaMail.zimbra@nod.at>
In-Reply-To: <b4oa6jak7f4hiaqcqpmasclaylqdhdzgne75a6nol6z33d4o7z@3soexkn4smz4>
References: <20240211003907.167891-1-christian@heusel.eu> <b4oa6jak7f4hiaqcqpmasclaylqdhdzgne75a6nol6z33d4o7z@3soexkn4smz4>
Subject: Re: [PATCH] jffs2: print symbolic error name instead of error code
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Thread-Topic: jffs2: print symbolic error name instead of error code
Thread-Index: W9U2fKy9ORNwIjN+anjPvwswt4VI2w==

----- Urspr=C3=BCngliche Mail -----
> Von: "Christian Heusel" <christian@heusel.eu>
> An: "David Woodhouse" <dwmw2@infradead.org>, "richard" <richard@nod.at>, =
"linux-mtd" <linux-mtd@lists.infradead.org>,
> "linux-kernel" <linux-kernel@vger.kernel.org>
> CC: "kernel-janitors" <kernel-janitors@vger.kernel.org>
> Gesendet: Montag, 11. M=C3=A4rz 2024 13:47:40
> Betreff: Re: [PATCH] jffs2: print symbolic error name instead of error co=
de

> On 24/02/11 01:39AM, Christian Heusel wrote:
>> Utilize the %pe print specifier to get the symbolic error name as a
>> string (i.e "-ENOMEM") in the log message instead of the error code to
>> increase its readablility.
>>=20
>> This change was suggested in
>> https://lore.kernel.org/all/92972476-0b1f-4d0a-9951-af3fc8bc6e65@suswa.m=
ountain/
>>=20
>> Signed-off-by: Christian Heusel <christian@heusel.eu>
>> ---
>>  fs/jffs2/background.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>=20
>> diff --git a/fs/jffs2/background.c b/fs/jffs2/background.c
>> index 6da92ecaf66d..bb0ee1a59e71 100644
>> --- a/fs/jffs2/background.c
>> +++ b/fs/jffs2/background.c
>> @@ -44,8 +44,8 @@ int jffs2_start_garbage_collect_thread(struct jffs2_sb=
_info
>> *c)
>>=20
>>  =09tsk =3D kthread_run(jffs2_garbage_collect_thread, c, "jffs2_gcd_mtd%=
d",
>>  =09c->mtd->index);
>>  =09if (IS_ERR(tsk)) {
>> -=09=09pr_warn("fork failed for JFFS2 garbage collect thread: %ld\n",
>> -=09=09=09-PTR_ERR(tsk));
>> +=09=09pr_warn("fork failed for JFFS2 garbage collect thread: %pe\n",
>> +=09=09=09tsk);
>>  =09=09complete(&c->gc_thread_exit);
>>  =09=09ret =3D PTR_ERR(tsk);
>>  =09} else {
>> --
>> 2.43.1
>=20
> Friendly ping on the above patch, since it's now a month after sending
> it :)

Thanks for the ping. Your patch looks good. I'll queue it.

Thanks,
//richard