Received-SPF: pass (google.com: domain of linux-kernel+bounces-97825-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Sat, 9 Mar 2024 09:04:40 +0000 (GMT)
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Andreas Larsson <andreas@gaisler.com>
cc: sam@ravnborg.org, sparclinux@vger.kernel.org, 
    Randy Dunlap <rdunlap@infradead.org>, 
    Miquel Raynal <miquel.raynal@bootlin.com>, 
    linux-parport@lists.infradead.org, "David S. Miller" <davem@davemloft.net>, 
    Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/7] sparc32: Do not select GENERIC_ISA_DMA
In-Reply-To: <d7134c1f-7c6a-4715-9ffb-e8ef0143d662@gaisler.com>
Message-ID: <alpine.DEB.2.21.2403090903560.16468@angie.orcam.me.uk>
References: <20240224-sam-fix-sparc32-all-builds-v2-0-1f186603c5c4@ravnborg.org> <20240224-sam-fix-sparc32-all-builds-v2-5-1f186603c5c4@ravnborg.org> <d7134c1f-7c6a-4715-9ffb-e8ef0143d662@gaisler.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 8 Mar 2024, Andreas Larsson wrote:

> > From: Sam Ravnborg <sam@ravnborg.org>
> > 
> > sparc32 do not support generic isa dma, so do not select the symbol.
> > 
> > This fixes the following warnings:
> > dma.c:70:5: error: no previous prototype for 'request_dma' [-Werror=missing-prototypes]
> > dma.c:88:6: error: no previous prototype for 'free_dma' [-Werror=missing-prototypes]
> > 
> > Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> > Fixes: 0fcb70851fbf ("Makefile.extrawarn: turn on missing-prototypes globally")
> > Acked-by: Randy Dunlap <rdunlap@infradead.org>
> > Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
> > Cc: Andreas Larsson <andreas@gaisler.com>
> > Cc: "David S. Miller" <davem@davemloft.net>
> > Cc: Randy Dunlap <rdunlap@infradead.org>
> > Cc: Maciej W. Rozycki <macro@orcam.me.uk>
> > ---
> >  arch/sparc/Kconfig | 4 ----
> >  1 file changed, 4 deletions(-)
> 
> Reviewed-by: Andreas Larsson <andreas@gaisler.com>

Reviewed-by: Maciej W. Rozycki <macro@orcam.me.uk>
Tested-by: Maciej W. Rozycki <macro@orcam.me.uk> # build-tested

  Maciej