Received: by 2002:ab2:5d18:0:b0:1ef:7a0f:c32d with SMTP id j24csp233555lqk; Sat, 9 Mar 2024 07:42:10 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCUPHyzn9xg67dGRXKQELqBixsdlWa+87dVkCDq9Lc3/ehgQiCpkbFTGcYD+kKyQq4TX31zh6ohWyJeW63qiwUrHGJY+8XHigtRNZCym2g== X-Google-Smtp-Source: AGHT+IHfcpyyTSry1GB7OgR1NxafjIp+NIY/1wKgKcYQs8I0AugRIMNlLA4uYkzj1lZqr5nljRL9 X-Received: by 2002:a05:620a:1357:b0:788:485:21a1 with SMTP id c23-20020a05620a135700b00788048521a1mr2366760qkl.67.1709998930221; Sat, 09 Mar 2024 07:42:10 -0800 (PST) Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id y22-20020a05620a44d600b0078826373df2si1937025qkp.611.2024.03.09.07.42.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Mar 2024 07:42:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-97942-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@google.com header.s=20230601 header.b=mrLTnH+h; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-97942-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-97942-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=REJECT sp=REJECT dis=REJECT) header.from=google.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id E661A1C20A40 for ; Sat, 9 Mar 2024 15:42:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id ED11B446D6; Sat, 9 Mar 2024 15:42:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="mrLTnH+h" Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9215440873 for ; Sat, 9 Mar 2024 15:41:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709998921; cv=none; b=AndA+BTC6kq05J3toDRxDJvKcbND8oSIBIqQ4buo/Dba1wQvPx8yVr0l3MN1/4I1k9vJ6EjJROgyhpv8N50dq86TliHPWl8Yp8frn7BLT1EORjlQdqvjjkjC6/0V7U92PctQnWls1olxx8nkcY6v0OsfwxO2TAAYB5SQsTXesIM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709998921; c=relaxed/simple; bh=lgwpTNi1M3yVskswaglSg5hLDE71jPPK741kQGr7/SQ=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=CGbdrhuHuq03oemai5pxxwrZgb5bJJdprrY5oOM7UwfcdI8CMTV/YDKgE0MutKUDon6gDSB/wBL+f+5B4sChyNf6JVIgx3opUtIDF3TxyzbZdIy7kgQG4eV7EPKdw+s/hB2K9smdEUkWrDwlkJdhgwC8qn0q+kb/VKtM4Hn1Vbo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=mrLTnH+h; arc=none smtp.client-ip=209.85.208.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-5682df7917eso8056a12.0 for ; Sat, 09 Mar 2024 07:41:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1709998918; x=1710603718; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zkDsUMSZYlTGnFq8L8u1MCZSuc7DRjwYv05YSVPzzQs=; b=mrLTnH+h/N6GRDiJvOJL72/FEFTtqWG/1a+jry6zxfXlDRsOZ+xrBxpkoUT1RxXHy6 V7kIuUP0iXn+dFs4geLRYH/J6SlPL4BXNPvw1BvHg/M/SNGvU99xsvxi/QymhEgtxj7p 4Q41RyntcpusFYdX/CBCDO1RoO/EPrnpRFYfrGh4oWCYiqNkdBl+tQ0DcZg5vdNjpBK+ 9S8gpIgwMzVKUE/W82e3E6c25ogxUgFOZGxNoxp8rq3pcoUg7lKdZ9Wqaa1Qo72l0kKD 49gkk8Ezc7CcBFiKqQNga+TnIWmPO4Qceo6xJIuCrPF6yn0gRxcqXSUisUtr357M7UHZ bW4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709998918; x=1710603718; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zkDsUMSZYlTGnFq8L8u1MCZSuc7DRjwYv05YSVPzzQs=; b=HS2oyaAIqlyurEgZbQSKLyfIifPYBQ9cGwdO7NhWv2IYQo+Ynf8KlTCWXX0/4DPUfT pBV890PYXPl8obHd40G4Z+DrkbCzjt2G2RkDO+IwK8gli9waxZ8MpCy4LXKHkFBgrS1E KSeBKF20Nw5u+Z50y1MVbjulUn00QHvFJ0p6BTgLOahPOQtHNMUXGXQeBZKG/oSbLLvV FsXV/ALbNL+kId03+sD+NJxAYhdDvk5LaGM3Et0bDv/IekaGCrlU0aXfpFSaFMklVRxn sC/SW1QaBLMs4FUwnNpR+8t00/ygY2Qi2fhhoZJXQooW1rdVrL6YCRZecx4Mw5moXrTY Yohw== X-Forwarded-Encrypted: i=1; AJvYcCX+MhVtvFD5EZDWes4iReNdNUGCzN2PKLkaSE3Yde5EKtT1EmDNhuAzYS8/C2hE2gStS6ijDTanI0RxctPxBIPzYQul9cZwy64Z913q X-Gm-Message-State: AOJu0YyLuS0RAOahpGBN8VZWzjihoxT76K5mhDUCpNGavwlVXuDU+Lwi 3lyEIIfusJK2692/BZh6fq7iJNyIve0FFVWQ30rmrJ+hWk4I/RLa+HgU7rVSvcV5gw+qyK+biBh 0ROUU6teiYFmHXXMyd2veCYOWkQgN4SjF1Ky4 X-Received: by 2002:a05:6402:1b06:b0:568:3c0c:1755 with SMTP id by6-20020a0564021b0600b005683c0c1755mr84512edb.6.1709998917765; Sat, 09 Mar 2024 07:41:57 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <88831c36-a589-429f-8e8b-2ecb66a30263@gmail.com> In-Reply-To: <88831c36-a589-429f-8e8b-2ecb66a30263@gmail.com> From: Eric Dumazet Date: Sat, 9 Mar 2024 16:41:46 +0100 Message-ID: Subject: Re: [PATCH net-next v3 4/4] net: gro: move L3 flush checks to tcp_gro_receive To: Richard Gobert Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, willemdebruijn.kernel@gmail.com, dsahern@kernel.org, xeb@mail.ru, shuah@kernel.org, idosch@nvidia.com, razor@blackwall.org, amcohen@nvidia.com, petrm@nvidia.com, jbenc@redhat.com, bpoirier@nvidia.com, b.galvani@gmail.com, gavinl@nvidia.com, liujian56@huawei.com, horms@kernel.org, linyunsheng@huawei.com, therbert@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Mar 9, 2024 at 4:35=E2=80=AFPM Richard Gobert wrote: > > {inet,ipv6}_gro_receive functions perform flush checks (ttl, flags, > iph->id, ...) against all packets in a loop. These flush checks are > relevant only to tcp flows, and as such they're used to determine whether > the packets can be merged later in tcp_gro_receive. > > These checks are not relevant to UDP packets. I do not think this claim is true. Incoming packets -> GRO -> GSO -> forwarded packets The {GRO,GSO} step must be transparent, GRO is not LRO.