Received-SPF: pass (google.com: domain of linux-kernel+bounces-96749-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240307214317.2914835-1-alexander.sverdlin@gmail.com>
In-Reply-To: <20240307214317.2914835-1-alexander.sverdlin@gmail.com>
From: Bartosz Golaszewski <brgl@bgdev.pl>
Date: Fri, 8 Mar 2024 10:32:54 +0100
Message-ID: <CAMRc=Me8J0fd066QaSmDhhc+g54A8m-dWTDmtx14HOPc+d0TYA@mail.gmail.com>
Subject: Re: [PATCH] gpio: sysfs: repair export returning -EPERM on 1st attempt
To: Alexander Sverdlin <alexander.sverdlin@gmail.com>
Cc: linux-gpio@vger.kernel.org, 
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Mar 7, 2024 at 10:43=E2=80=AFPM Alexander Sverdlin
<alexander.sverdlin@gmail.com> wrote:
>
> It would make sense to return -EPERM if the bit was already set (already
> used), not if it was cleared. Before this fix pins can only be exported o=
n
> the 2nd attempt:
>
> $ echo 522 > /sys/class/gpio/export
> sh: write error: Operation not permitted
> $ echo 522 > /sys/class/gpio/export
>
> Fixes: 35b545332b80 ("gpio: remove gpio_lock")
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
> ---
>  drivers/gpio/gpiolib-sysfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpiolib-sysfs.c b/drivers/gpio/gpiolib-sysfs.c
> index 67fc09a57f26..6853ecd98bcb 100644
> --- a/drivers/gpio/gpiolib-sysfs.c
> +++ b/drivers/gpio/gpiolib-sysfs.c
> @@ -593,7 +593,7 @@ int gpiod_export(struct gpio_desc *desc, bool directi=
on_may_change)
>         if (!guard.gc)
>                 return -ENODEV;
>
> -       if (!test_and_set_bit(FLAG_EXPORT, &desc->flags))
> +       if (test_and_set_bit(FLAG_EXPORT, &desc->flags))
>                 return -EPERM;
>
>         gdev =3D desc->gdev;
> --
> 2.43.2
>

That's of course correct. Applied.

Bart