Received-SPF: pass (google.com: domain of linux-kernel+bounces-95525-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID:
 <SEZPR06MB69597EEFAB2F77049E9B257296202@SEZPR06MB6959.apcprd06.prod.outlook.com>
Date: Thu, 7 Mar 2024 20:22:52 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] mmc: dw_mmc: remove unneeded assignment
Content-Language: en-US
To: Muhammad Usama Anjum <usama.anjum@collabora.com>,
 Jaehoon Chung <jh80.chung@samsung.com>, Ulf Hansson <ulf.hansson@linaro.org>
Cc: kernel@collabora.com, kernel-janitors@vger.kernel.org,
 linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240307122129.2359553-1-usama.anjum@collabora.com>
From: Yang Xiwen <forbidden405@outlook.com>
In-Reply-To: <20240307122129.2359553-1-usama.anjum@collabora.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SEZPR06MB6959:EE_|TY0PR06MB5801:EE_
X-MS-Office365-Filtering-Correlation-Id: 1aa7c7bd-8086-41f2-bb02-08dc3ea151b7
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	7sQXAS/e2snwpD6/MYf9pQM/idrJMTkDIblH32nLoJU0Cza+FZRerl9iOW6rIccs34g2HPblvs9MPrcOgDQDjG3qcz1FYlViIdlh6TLkA3ULUnnvLHQm4M7xta06izwcEe+PZQnngISe4o7V14t7nF/PXw4CN2xEkoMy9sf3qbGQreeutX110HfGd1mfocaZu+KPut6fGs4ihPxFmRQGUXDhjsSRFXw3c1sHo2E3dGDjIsm+ICF9EzOJFOHYdn5C9u85iltUhpKgKeEbhKuGOoT/+rn+ehZTbMCcmZRR3/QzIFNbn+6qynokXO9tWUTUJzSClldb+gW7chL73Lv86alngprwhvQPX24099OscPIcAhl+N0Jk6U8vnhpIxoDQjTbngq5hw7cCE9KQTortN+YTOR3NZ8ZG0ZWzHdVycO3jwh8Ibfj1zDRL8NVVNfxkI1/pYx/JNBro/0NCk0zyy/nrmqX/fCZbWh+WhQj1bBv/PUUgPDJ5Cxrjhafm46TngW447/Y0pYbGIk1mggj3rUpXf/jIIzaWlYPe+sU+aQ48B5gjzKHgiexanp8YG3T3
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MHZjZUxJeXdpUHdZNVhldGJUY2dlRURSNG9iYU0yeFkwUXNXcy9TYzZSS0t2?=
 =?utf-8?B?NGFKRzhRZDd1NGJLTmtEdFJVTnZXNEc3SFh2d2czSGdxbTU0NWJEN1ZWUVZi?=
 =?utf-8?B?amJsbFpOamJjbThqNnVTSGdtajY4c1JybDNKSnVGczZUZnpXdU92UnI2RGs3?=
 =?utf-8?B?c3N0TDhQTGcwWExTZ1oyOFR3WHA3NUJiU1FDY2RQcHBTM054SWJLYnFKTzRS?=
 =?utf-8?B?Q0x0SnBOc3FNOWNWTWxvR3ZaZFYzbzU5V3lEeUQ0VnF6SlJZaUV3S092Q3Zn?=
 =?utf-8?B?V1lnVHpLQTNrZjVpNVJnaEVLNXJvUVlTSmlPRUVIUkJoenBUR3VTaE1EUER1?=
 =?utf-8?B?RnVtSGpwcG50TnpPNzZBdHBrNGtUc1Uya2VsRW5MekJ2bWlvaHZzNFE4dTFK?=
 =?utf-8?B?NThBQ2NWQS85a0JwVkNzQnZ3V1ZSN2dQdlNCSUVFenJ1YUppeVhSajl0TXFo?=
 =?utf-8?B?QnFmUWZIbTRqeG5GNHhwT2ZyUmFEMldXSUJsTzVURnVZTGR0WjFUeksyT1FV?=
 =?utf-8?B?UHBGdlZYVmp1RXJBRGlSTlZiREExTE1qM2xhTG9lNldIK3M0M3BiS1g5R2dy?=
 =?utf-8?B?TzMxa1VsV2VSYjBWZmlucDVQRHdmSGZLKzBxNkdJS3BmRE0vVHR2ZS9pSDVj?=
 =?utf-8?B?Z0luQVNDK21iSWVScTF1U0wwSnJTSlNITnZBMytDTlpYOEl2Qm1YN2RUUVZ6?=
 =?utf-8?B?NmZid09WeXMwQlJMN3IrS3NVeDhlNXRLQ3pTWlp6aUVJUGxZdlpiNXR2Wmxa?=
 =?utf-8?B?a010REV4VVRhVU9MRFdGVEFWc0YxS3pkMnpWNW9kY29PQ1ZyR1BQYTFhL2J4?=
 =?utf-8?B?ZHJYZk8yTUZ4WnBZQ0ZSNmVMWWdJVWo1ZHBZRUJYeTNrb2svdnJlVWdUc3dj?=
 =?utf-8?B?M1hTTzlCSTRwZXhxMFV3dlFsejdGNi9yNlNmOWFqcUJTUjNYUkdvRENEeUh0?=
 =?utf-8?B?aHk3SXJxYTdXMm5lR3pSK3Y1WU9iaGx4Vk5peUxLbWlZRms1bWRFSmRtcWt2?=
 =?utf-8?B?U3pFZXkxUzRCazVBMHZ1dzd0NVI0bUM5NlJGWkIrb1dTWkhqSlZDSm1wUVVD?=
 =?utf-8?B?WmJRSXRUQ1B3TlU2TGhsa25IVHo0NC94Y3U5eGkrYW5qYk12ZDlZV3NVVmow?=
 =?utf-8?B?SkZyQzNXZlY1cE0wbTYxNkhRV2IycnpGVmZSTXhhdmMrT2RQVDluT0ozVnZm?=
 =?utf-8?B?NXVaRzllRzR2ZytPS0FXYzFMNEo2ajN3ZTF6Q1JZM3V2N1VpZW1iRVZMbGZT?=
 =?utf-8?B?VFhCcmpoNVlRbDVqaFc3NFlrYW0wMjhUWWQ1dzROdzJSRXRHclRZalJLbHJL?=
 =?utf-8?B?eGdxQWMzZnVwNVRuMjlJK3IxYVBWYUhDeHRYb2pZNWVZcEtyWVhvcmdNQVFr?=
 =?utf-8?B?cTgyaTZKdmtLMlhxKytKYVAweHpESjZIeDl1ak5oU3pjRVJONGRUc21pd2t5?=
 =?utf-8?B?OWlzem1tS096WG4xNDRySm1Qb3BjaEVqOFo0dmVTQVIwa2UzZTJqcXNQbTc3?=
 =?utf-8?B?SU52NFdvOUZMd3cvUGZzOGU2RkMyVE9VZFBsSkJGcC8ydThDSEgwU0wwR2g4?=
 =?utf-8?B?TVpCM1ZVd21Vb1RGQ2FGdHc4OGhOQk0rcG5kbHVzWlFxUU9BeG03dHFHbDZJ?=
 =?utf-8?B?dzZBM0dVY0NSbG5tUXN6WHhJKzVhZzFWczB5VUE5amRZY2ozeXBtTlMveVJ5?=
 =?utf-8?B?VFArN21WWTBsaFFHaXRTVTRwdUlyRHJ2QXhWUG1wSlJaeUx3VWZlNFN2VFJ1?=
 =?utf-8?Q?NTyVZMTpDu4yubq8UyWymOn1eOXDvuHigr/wVxv?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1aa7c7bd-8086-41f2-bb02-08dc3ea151b7
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB6959.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2024 12:22:56.3283
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY0PR06MB5801

On 3/7/2024 8:21 PM, Muhammad Usama Anjum wrote:
> The err is being set to 0 and replaced every time after this
> assignment. Remove this assignment as it is extraneous.
>
> Fixes: 25d043841db1 ("mmc: dw_mmc: add support for hi3798mv200")
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
>   drivers/mmc/host/dw_mmc-hi3798mv200.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-hi3798mv200.c b/drivers/mmc/host/dw_mmc-hi3798mv200.c
> index 989ae8dda7228..96af693e3e37c 100644
> --- a/drivers/mmc/host/dw_mmc-hi3798mv200.c
> +++ b/drivers/mmc/host/dw_mmc-hi3798mv200.c
> @@ -133,7 +133,6 @@ static int dw_mci_hi3798mv200_execute_tuning_mix_mode(struct dw_mci_slot *slot,
>   			goto tuning_out;
>   
>   		prev_err = err;
> -		err = 0;


Same for dw_mmc-hi3798cv200.c, maybe fix it as well?


>   	}
>   
>   tuning_out:


-- 
Regards,
Yang Xiwen