Received-SPF: pass (google.com: domain of linux-kernel+bounces-95199-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
IronPort-SDR: s2r9boCswk44kgrxVXVgIt3dntph98vGssg0BeLOWdvmdoRI/88/B2hDmLZQasT+h6VJXxxpl7
 JNy2VA8uiQ7A==
From: Bhargav Raviprakash <bhargav.r@ltts.com>
To: broonie@kernel.org
Cc: arnd@arndb.de,
	bhargav.r@ltts.com,
	conor+dt@kernel.org,
	devicetree@vger.kernel.org,
	eblanc@baylibre.com,
	gregkh@linuxfoundation.org,
	jpanis@baylibre.com,
	kristo@kernel.org,
	krzysztof.kozlowski+dt@linaro.org,
	lee@kernel.org,
	lgirdwood@gmail.com,
	linus.walleij@linaro.org,
	linux-arm-kernel@lists.infradead.org,
	linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	m.nirmaladevi@ltts.com,
	nm@ti.com,
	robh+dt@kernel.org,
	vigneshr@ti.com
Subject: Re: [PATCH v2 12/14] regulator: tps6594-regulator: Add TI TPS65224 PMIC regulators
Date: Thu,  7 Mar 2024 14:48:23 +0530
Message-Id: <20240307091823.171504-1-bhargav.r@ltts.com>
In-Reply-To: <6fa04f9a-2904-4955-a219-d4962b8fe41b@sirena.org.uk>
References: <6fa04f9a-2904-4955-a219-d4962b8fe41b@sirena.org.uk>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Hi,
On Thu, 29 Feb 2024 14:49:16 +0000, Mark Brown wrote:
> On Thu, Feb 29, 2024 at 03:42:50PM +0100, Esteban Blanc wrote:
> > On Fri Feb 23, 2024 at 10:36 AM CET, Bhargav Raviprakash wrote:
> 
> > > +	/* Number of interrupts supported by each voltage source */
> > > +	interrupt_cnt = (tps->chip_id == TPS6594) ?
> > > +			 ARRAY_SIZE(tps6594_buck1_irq_types) :
> > > +			 ARRAY_SIZE(tps65224_buck1_irq_types);
> 
> > The comment is not adding anything, the name is clear and ARRAY_SIZE is
> > quite explicit.
> 
> Also please don't abuse the ternery operator like this, write normal
> conditionals or for a case like this where we may get more options in
> future use switch statements.

Got it! will fix it in the next version.

Regards,
Bhargav