Received-SPF: pass (google.com: domain of linux-kernel+bounces-95377-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Josua Mayer <josua@solid-run.com>
Date: Thu, 07 Mar 2024 12:06:58 +0100
Subject: [PATCH] hwmon: (amc6821) add of_match table
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <20240307-amc6821-of-match-v1-1-5f40464a3110@solid-run.com>
To: Jean Delvare <jdelvare@suse.com>, Guenter Roeck <linux@roeck-us.net>
Cc: Yazan Shhady <yazan.shhady@solid-run.com>, 
 Jon Nettleton <jon@solid-run.com>, linux-hwmon@vger.kernel.org, 
 linux-kernel@vger.kernel.org, stable@vger.kernel.org, 
 Josua Mayer <josua@solid-run.com>, Rabeeh Khoury <rabeeh@solid-run.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aGFVb0tjcnd6ZUd3dFJiTlhSZURCSGhhTUZ6ZjVpeXVFZlZFekNvbUFkWExt?=
 =?utf-8?B?aU5WT1pTN0dkME1WMVlYRmJoZ040MFF1KzltaWcvTHFZWnJQV2VUcDRyQ3Bw?=
 =?utf-8?B?NVo3UVVFdXp0MGsxemtMQnhHaEpKMEkvTkJBeStxU3Q0OGxiR1N5VUlyT0hL?=
 =?utf-8?B?eHg0QmFzRy9uOXBOVkFhRitLU2hCY0Z2eEZFcWcycjByQ3NDOXh6MVYwQ1gr?=
 =?utf-8?B?MzFrNjFlVEk0SGlKTXdzRHBSTUJxS3dyRGlKZkhybnJQcHZlSzQvRy9ZZ1Uz?=
 =?utf-8?B?ZlBPSG85TW80RXpPUXp5MVUwQlpBejFkTVdwNithOW1ObjNlckRISkcvanI4?=
 =?utf-8?B?RHpYdUtMTDBPK0NWVkZUeks0RXc4dU9sYW8yMDF2WGQzVTB4eFZJaTdZbEIr?=
 =?utf-8?B?TVZrK21vVGpuMmM3NmRIb1p5ektZU1pOSXJ1elRiTVQvUGc0YStTRmJZekNn?=
 =?utf-8?B?OFlZSEY5REViaWxmdTExUU41b0JCZHY3YmtvN2s4ZWo0ektnVGQwK29FdDRY?=
 =?utf-8?B?bk1oY3dIVW9acXB5d3BmUEVxdjFqaHJ0QUZtQy9Mdm53YUdKWktaYnNYKzkz?=
 =?utf-8?B?Z1NFbTFhZkpmRWhSbUlWQzlyREh1RndKNE1qdnprQXFWRmpjWDQwczVYdElO?=
 =?utf-8?B?M0JPWjZ5cE9WeHpJeUhaYlpxWm9NUU1BY3JWWnpDUlorWnhjSnhXcWFST2Ex?=
 =?utf-8?B?ajViamdWZTdkVHdhdmY4Mnk3b056SHNjc0hGd2FBaWNxWHNRTmhVUUlpTVlG?=
 =?utf-8?B?bmcrWEhiZTRPRUNMQ2hFNC9yV25aSndGNk42Wk8xWGtUWXg1eUc5UVFBVzlC?=
 =?utf-8?B?amluYkRncWdkangxVERuaWxuTUUxbnJ5a3ovWWpLNlFDNnl5R1J3RFRydzBK?=
 =?utf-8?B?ZkVyZmc3ODVHUG9wcTdXUGtuUXJ0dDBuKzBQdG9NK1FxeXNCSWJoTWNjQThD?=
 =?utf-8?B?cUtwMmJ6bW9VSjJ3RDM5WWl5RjBjbjNuc0lNVThlbThwM2huZnNXUkJhZXR1?=
 =?utf-8?B?ODY2RHVtUnJTSGhmMU9WQVFYdTNaNjlGelNjSWJ3VW1uS3kwQ0JJV3RERGFF?=
 =?utf-8?B?K3VheGNNQzBiTDBvMmNVODNDR2ZQVG9qSW9veEVrUmFlZnFjdEoyM3NMY0tq?=
 =?utf-8?B?dDNMQ1hUSHBlRnhKRDRvcG03OGF4WnVIM0xzL0ZCQ3puc0NudWdJczB1STRY?=
 =?utf-8?B?WE5PeDhUK3VWa1hUN2pyNk9Dcno3V0dNOVZRN01DblBsczl5ZStOQXBrdm5S?=
 =?utf-8?B?L09ocFlhcFE4YkhGQ0hUZ05qbnA2bklSVSsxeTJCNmZGQVZJbnk1eUU1RUY1?=
 =?utf-8?B?dHZtVzhsOTlQaUpnYjE4S2ZOcFV6djR0a0JrTlNJRXFuN1g0T1Y4UzVPckRi?=
 =?utf-8?B?RGpFN1k3Njdra1FtNFRFQXI0aXNkdmkvMCthOGpQeHRidHpQQ2dJcmVya0VH?=
 =?utf-8?B?cmxmc3B2QVRVVThFRUtXMSs4NGV4ckpOSDV3ZTNyLzl2RnN1b0RRNGh2b0xl?=
 =?utf-8?B?azlnakY0WFNHVXB2VVJiY28wa3UvVnhkaTB5TXNSSXFqVkZJbWNvbW8ydDVa?=
 =?utf-8?B?V1M4K0tSN3NsRDJzMFFNNEtGb0lOdlNYanBvR2FFWEE2UFhTbDY3dng3ai9Y?=
 =?utf-8?B?UnNBbmRsdEdxNXZhZnBIT0xEK214WE0wWVNDR3dBZWxGMGd6UlBVVVFLNmh2?=
 =?utf-8?B?bE0xK0NndmFHb2VtNFRKcThpS20zeW5QQ3JsRDdnVGY4UXFxN0xSb2xvd2FG?=
 =?utf-8?B?UEtHWklFRUZQUU9FaVZuSGZ5cS9NUHFkcGgvN2R0bDRMZVNaVzRha2g1U1Uv?=
 =?utf-8?B?cHU4YjhKWitiVTZmdUY3dC92cGJsQjdXTldjVDBmT0xSTVcwNXRSQnM1SGg5?=
 =?utf-8?B?ZC9obDREemJEdi9YTzBDSHQwYVlWdStEaFRSQkdTMmtXUGJPZjM2eEdEOGFL?=
 =?utf-8?B?UkRZM3dkSysxTXNadm9GKzVwQWtIcGlyL3c0dXpFZlp5L3pWVjVoeDBkMUZZ?=
 =?utf-8?B?ZkIzcm0rTDVaTWZiT2tjTW1XcVhTVUxvTXBmbjE2NmY2d0dhSlcybEUzNllr?=
 =?utf-8?B?V1VXQy9yb2dCUzJyT0hHMURxL0JrOCtLd2c4Mmo1MmEwK0N4eGJ6b3lSMEUw?=
 =?utf-8?Q?H8RaKChGvAu5h+zRbFPYyjmpY?=
X-OriginatorOrg: solid-run.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f34b0e5f-f7c7-4606-58dd-08dc3e96c958
X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB7586.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2024 11:07:32.5886
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: a4a8aaf3-fd27-4e27-add2-604707ce5b82
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ypj07NFziTFSdKxu1/r8NxxIWgpEwFJCLW2HfloNcRu/PhEcHZ9e5KpJZJrdwqwfaLolEfM+0Qr4tlf1dcum9w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9298

Add of_match table for "ti,amc6821" compatible string.
This fixes automatic driver loading by userspace when using device-tree,
and if built as a module like major linux distributions do.

While devices probe just fine with i2c_device_id table, userspace can't
match the "ti,amc6821" compatible string from dt with the plain
"amc6821" device id. COnsequently kernel module ca not be loaded.

Cc: stable@vger.kernel.org
Signed-off-by: Josua Mayer <josua@solid-run.com>
---
Bcc: Rabeeh Khoury <rabeeh@solid-run.com>
---
 drivers/hwmon/amc6821.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/hwmon/amc6821.c b/drivers/hwmon/amc6821.c
index 2a7a4b6b0094..9b02b304c2f5 100644
--- a/drivers/hwmon/amc6821.c
+++ b/drivers/hwmon/amc6821.c
@@ -934,10 +934,21 @@ static const struct i2c_device_id amc6821_id[] = {
 
 MODULE_DEVICE_TABLE(i2c, amc6821_id);
 
+static const struct of_device_id __maybe_unused amc6821_of_match[] = {
+	{
+		.compatible = "ti,amc6821",
+		.data = (void *)amc6821,
+	},
+	{ }
+};
+
+MODULE_DEVICE_TABLE(of, amc6821_of_match);
+
 static struct i2c_driver amc6821_driver = {
 	.class = I2C_CLASS_HWMON,
 	.driver = {
 		.name	= "amc6821",
+		.of_match_table = of_match_ptr(amc6821_of_match),
 	},
 	.probe = amc6821_probe,
 	.id_table = amc6821_id,

---
base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d
change-id: 20240307-amc6821-of-match-3e3308fbf133

Best regards,
-- 
Josua Mayer <josua@solid-run.com>