Received-SPF: pass (google.com: domain of linux-kernel+bounces-95195-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
IronPort-SDR: pFAQhK/U09cP+wiB7l6RG0lxZZjNkZK3B3ZMJcRpEklRHafZn2W7+iU80n+FX2QzAQFb6X7OVe
 8JJdotaedGmw==
From: Bhargav Raviprakash <bhargav.r@ltts.com>
To: broonie@kernel.org
Cc: arnd@arndb.de,
	bhargav.r@ltts.com,
	conor+dt@kernel.org,
	devicetree@vger.kernel.org,
	gregkh@linuxfoundation.org,
	jpanis@baylibre.com,
	kristo@kernel.org,
	krzysztof.kozlowski+dt@linaro.org,
	lee@kernel.org,
	lgirdwood@gmail.com,
	linus.walleij@linaro.org,
	linux-arm-kernel@lists.infradead.org,
	linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	m.nirmaladevi@ltts.com,
	nm@ti.com,
	robh+dt@kernel.org,
	vigneshr@ti.com
Subject: Re: [PATCH v2 12/14] regulator: tps6594-regulator: Add TI TPS65224 PMIC regulators
Date: Thu,  7 Mar 2024 14:45:53 +0530
Message-Id: <20240307091553.171178-1-bhargav.r@ltts.com>
In-Reply-To: <a71bda52-524d-4493-aede-786aae7ff468@sirena.org.uk>
References: <a71bda52-524d-4493-aede-786aae7ff468@sirena.org.uk>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Hi,
On Thu, 29 Feb 2024 13:58:54 +0000, Mark Brown wrote:
> On Fri, Feb 23, 2024 at 03:06:59PM +0530, Bhargav Raviprakash wrote:
> 
> > +static struct tps6594_regulator_irq_type tps65224_ext_regulator_irq_types[] = {
> > +	{ TPS65224_IRQ_NAME_VCCA_UVOV, "VCCA", "voltage out of range",
> > +	  REGULATOR_EVENT_OVER_VOLTAGE_WARN },
> > +	{ TPS65224_IRQ_NAME_VMON1_UVOV, "VMON1", "voltage out of range",
> > +	  REGULATOR_EVENT_OVER_VOLTAGE_WARN },
> > +	{ TPS65224_IRQ_NAME_VMON2_UVOV, "VMON2", "voltage out of range",
> > +	  REGULATOR_EVENT_OVER_VOLTAGE_WARN },
> > +};
> 
> These should be REGULATOR_EVENT_REGULATION_OUT I think - they look like
> they could be warning on either under or over voltage.

Thanks for the feedback.
In the next version we will use REGULATOR_EVENT_REGULATION_OUT.

Regards,
Bhargav