Received-SPF: pass (google.com: domain of linux-kernel+bounces-93854-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Guanbing Huang <albanhuang@outlook.com>
To: gregkh@linuxfoundation.org
Cc: jirislaby@kernel.org,
	linux-kernel@vger.kernel.org,
	linux-serial@vger.kernel.org,
	albanhuang@tencent.com,
	tombinfan@tencent.com
Subject: [PATCH v2] serial: 8250_pnp: Support configurable reg shift property
Date: Wed,  6 Mar 2024 19:42:27 +0800
Message-ID:
 <PSAPR06MB4952ED7EAD4410B25258F42FC9212@PSAPR06MB4952.apcprd06.prod.outlook.com>
In-Reply-To: <2024030518-encrust-gutter-f507@gregkh>
References: <2024030518-encrust-gutter-f507@gregkh>
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: PSAPR06MB4952:EE_|SG2PR06MB5012:EE_
X-MS-Office365-Filtering-Correlation-Id: 33f6d9cb-1357-4849-437c-08dc3dd284d3
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	VdbCCszulPVYB0idHNKveKksC27pM/whwuv8OnFLkY7TtZNsPc2KNAS+tJYD0J4gPeU3maxBa8EnfH/IOOXLkAHe6zfXalMHkQRkcgn79XitQT8Qx6oWY+zdrW04ItXE6ubGFoRXNco5Nz2FpyUEFHDmu6ZnvbET1bMTbhd2SKaFJFtN1qBb2ErPb+I1MKQyPcRjLTU0lfsj6BxGfBbTJc3RUIgvfqkyzpJ3/ilokFiv55uay790Cslxi/i1oyt85zMrFeMaRvd+6pHeUg9CLlamvdCY9k3p6M5Q3OXMxiEnC7m5DWe65kOeFpchk4g+ZaXA/UK5urfNicoCKISbMYhm9ufWPrqaG0OW4cmeOl+lR0oPxW9amrGdF3HBxpnT8JgHh1yHk87ZtNBFOkLMH8BlJMHD9yeK6EQzT0N+Cpfx+ie3/0l8rKi5O09M+z/onGR4/kG/YBC0gl8wZpdP6Aygux4EFnKAbbvBeD6EBbaGjgzZY0XyRRI+Iu33N6UfavD6L5pjHe5DpcQM+mgUONw23QoCYhJINRH28LetD5Eisk+0keXkoVY+zeEGorZR
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?yIrIoNhkX/U5dEIqa2WD58yMVhfOoEpy/d05Nw4rR6dgApLskilr5nKmdb0b?=
 =?us-ascii?Q?4LgO9Ks+8MPHjh5dBz55Y498Uyp9KTm+geUE1AiNFIJL8y4alwqMed4qYF6j?=
 =?us-ascii?Q?aslInNMBdFKEP2YdH0P0CzWFwN/jdtk+UKOCcukdB/eo7aEsIM7wP1bTocvK?=
 =?us-ascii?Q?cg5Zs6FNtxNQEm+c1It/1NYO4u1a2BLnZdJlBJ6wKn7oJdbn70zde57pP6L4?=
 =?us-ascii?Q?FjziuYElFD8JVwPnY3Pw4w6E8EeZsFyahhHrXwXAr23hdaWrMl+dBq+CWIg1?=
 =?us-ascii?Q?Xzc7Z2eioTW3Q6YiVEuwFluxsmtCWwTWDbb3trCvIcNDOgbO7yEckSnfVo2L?=
 =?us-ascii?Q?iAt55P17G1EhmJNKa3H1Ls8mf1LPeQQsnt2iBNHpqZyTCIgTG4+KHQMUFrkB?=
 =?us-ascii?Q?xKBqv83XsK07Kg7d2hcLGad2/Gh1U/nGMNLKFsj5FS+GB0neckNCKkFN3HOm?=
 =?us-ascii?Q?UoaexKtANb8adWtljAlHWEJ7kK+sxSgukDLcu8v4by8gdd83IbcmUCJWdy0T?=
 =?us-ascii?Q?P5XyYiQ5Pw+dFWTNXSbrwOzKIXBSN+l7AUBnq+F0DnWw5jp9g0LJrN/Wl22a?=
 =?us-ascii?Q?tUTyYU59eNVDUCd5tRqaLP7bK04s/vHU0ToP8saTdj3IdLamgYeHbaip5uzu?=
 =?us-ascii?Q?HgDO6K3IEkY6VUdbgO3wS7ApRH1/jhnbF90xMSxToVmVVgDmVkckfZWDuucP?=
 =?us-ascii?Q?DCPRrWufWq2uYEXeXo90ui//aUv+pKHegpmTuDtEQuVp2nhzfRMXnQG7g+w4?=
 =?us-ascii?Q?HbOz881WkWTjR5oCQMXOCXKZzw8aLfBiSDgMcvhvBVepr4pjjzth9zKRfgKw?=
 =?us-ascii?Q?vXpjEdQi56w85YpncjJl12NzaVjvB74B84e27bH9oV9eX6tEsGKQ1yG5/veC?=
 =?us-ascii?Q?Q7cn6X9/fOyeymXinlY+s5IhsiTMIyIaGSAvXYA+nnmyPspFenLnYXZS/PJG?=
 =?us-ascii?Q?rNDaE1GkF7lkQQhMJo0x/oNmoN6OWbtrB2dDSGCL0BCuaN0IVPWtZCSwbjH/?=
 =?us-ascii?Q?Px9R6jb2l0ywVjug9CuzYyXg2XDtzWwXtoIAVTqLA0vM3lsfwF5NywXszb4G?=
 =?us-ascii?Q?peWmOxSGOyFH5kiJDvPMNDgF7xuI2XQ06LsClTFV72AQ3gekC+5Q647ZzXKB?=
 =?us-ascii?Q?IeVNnliRTt4OSP7TmB6Yyqg57Nrb+ETrJgmuaZchx15AjaPj8BPwVy2Ne4Ks?=
 =?us-ascii?Q?jZA2Vq6uchnr8bOJCpRtRZT7IU4938JAt0BWygQNxqaR12fN6MFQHCPDj28?=
 =?us-ascii?Q?=3D?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 33f6d9cb-1357-4849-437c-08dc3dd284d3
X-MS-Exchange-CrossTenant-AuthSource: PSAPR06MB4952.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2024 11:42:36.3662
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB5012

From: Guanbing Huang <albanhuang@tencent.com>

The 16550a serial port based on the ACPI table requires obtaining the
reg-shift attribute. In the ACPI scenario, If the reg-shift property
is not configured like in DTS, the 16550a serial driver cannot read or
write controller registers properly during initialization.

Signed-off-by: Guanbing Huang <albanhuang@tencent.com>
Signed-off-by: Bing Fan <tombinfan@tencent.com>
Signed-off-by: Linheng Du <dylanlhdu@tencent.com>
---
v2: change the names after "Signed off by" to the real names

 drivers/tty/serial/8250/8250_pnp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/tty/serial/8250/8250_pnp.c b/drivers/tty/serial/8250/8250_pnp.c
index 1974bbadc975..25b4e41e9745 100644
--- a/drivers/tty/serial/8250/8250_pnp.c
+++ b/drivers/tty/serial/8250/8250_pnp.c
@@ -473,6 +473,7 @@ serial_pnp_probe(struct pnp_dev *dev, const struct pnp_device_id *dev_id)
 		uart.port.flags |= UPF_SHARE_IRQ;
 	uart.port.uartclk = 1843200;
 	device_property_read_u32(&dev->dev, "clock-frequency", &uart.port.uartclk);
+	device_property_read_u8(&dev->dev, "reg-shift", &uart.port.regshift);
 	uart.port.dev = &dev->dev;
 
 	line = serial8250_register_8250_port(&uart);
-- 
2.17.1