Received: by 2002:a89:2c3:0:b0:1ed:23cc:44d1 with SMTP id d3csp1070491lqs; Wed, 6 Mar 2024 05:39:13 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCVOATk7BSIhPJ7TaLBPvjoixeDtjXPy6KW8jJCotjOe3VNHhRr4W5rUVs7fjY0FrCTzV7Yig7rciKOOIOSgwNIqc4N8ndO2jGXuKN9wvg== X-Google-Smtp-Source: AGHT+IGSElfXREvo3FqRLLMN1i6gSB7fcxAkXpP43j+dzofbqUa8injaGhutD3IascdogmEcrFNO X-Received: by 2002:a05:622a:18e:b0:42e:7999:3f58 with SMTP id s14-20020a05622a018e00b0042e79993f58mr5786228qtw.57.1709732352600; Wed, 06 Mar 2024 05:39:12 -0800 (PST) Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id e12-20020ac85dcc000000b0042eb487594csi60813qtx.174.2024.03.06.05.39.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 05:39:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-93989-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel.com header.s=Intel header.b=O+u1Gi+F; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-93989-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-93989-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 575B31C21789 for ; Wed, 6 Mar 2024 13:39:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CF113131746; Wed, 6 Mar 2024 13:38:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=intel.com header.i=@intel.com header.b="O+u1Gi+F" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACECA131729; Wed, 6 Mar 2024 13:38:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709732299; cv=none; b=pPy8WUcoydaWwWHFYemxCedzIHCsCUo5ZCL+MWVGBqHmM1uAO0SyJDR5FOQpW1X1AWTwtknDwLg+lpileXPyZroeiN3tCZlkqfaRAI2aTbi6Klb9x/eWjD5tB2Ee7aIwmYTCCgX3/pmfSVa4jTUkYhIIO/AvGCzu8px7hspRBYI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709732299; c=relaxed/simple; bh=G2rmJ+Q2gQEQNdkWWv7W1eo2pFGNMfvC8toDVdsvsyM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Aa0VModZ9X/78Xeji863swgKlvbpMmgEjPAth6bZMV/pW0Ji4IPah0jZ/DUGAnk/08jkKNmTRu1+rxw5H3aonf7+4xMm7efviUmTt4bYY887pPoq/aU6WNXufxVd/BcdseNE5VprlSVFpSu5bWgjUskX/qiVojxEgrugRa8aD8o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=O+u1Gi+F; arc=none smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709732298; x=1741268298; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=G2rmJ+Q2gQEQNdkWWv7W1eo2pFGNMfvC8toDVdsvsyM=; b=O+u1Gi+FbLxbzEb23bS2Xs0edNtHqaMwqn8VedIyHCNaKZK9LmfOvgXm NGO8JjtRx81OiuFG4mz2ecQ2fdTigdbZcpB+BsqK3b6eJjk4mi7gLYktV w5pudmxZSPkR8u5bSvYJBDeq1ZCTPXXSgwJC5K+B2zT2dqRovCXzJO76n Fp33ceSgbHz14RbY4MZcQyMiJvOjRpKqNJh4fd+XSKFx3QHxPC0sDbDkS EY6WHngKmLuoUXXrNHRd6flZO+GHxN4CmrnWuB3cbfkl8SVN3fYmZ/e/I URQEXfsd/5/yOPXaHZGhJEyMNCFehoIrNtLSzcjp/+pEHNj7WZGTjdGxS Q==; X-IronPort-AV: E=McAfee;i="6600,9927,11004"; a="4207656" X-IronPort-AV: E=Sophos;i="6.06,208,1705392000"; d="scan'208";a="4207656" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2024 05:38:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11004"; a="914178599" X-IronPort-AV: E=Sophos;i="6.06,208,1705392000"; d="scan'208";a="914178599" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2024 05:38:13 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rhrTG-0000000AHH6-1kPA; Wed, 06 Mar 2024 15:38:10 +0200 Date: Wed, 6 Mar 2024 15:38:10 +0200 From: Andy Shevchenko To: Yury Norov Cc: Herve Codina , Vadim Fedorenko , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rasmus Villemoes , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Andrew Lunn , Mark Brown , Christophe Leroy , Thomas Petazzoni Subject: Re: [PATCH v6 1/5] net: wan: Add support for QMC HDLC Message-ID: References: <20240306080726.167338-1-herve.codina@bootlin.com> <20240306080726.167338-2-herve.codina@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Wed, Mar 06, 2024 at 05:27:51AM -0800, Yury Norov wrote: > On Wed, Mar 06, 2024 at 09:07:17AM +0100, Herve Codina wrote: .. > It's minor, but you can avoid conditionals doing something like: > > netdev->stats.rx_over_errors += !!(flags & QMC_RX_FLAG_HDLC_OVF); This is harder to read. And IIUC net subsystem dislikes the proposed one (I tried to submit a patch to clarify some boolean types vs. integer ones and it was rejected because of the reason I have mentioned). -- With Best Regards, Andy Shevchenko