Received-SPF: pass (google.com: domain of linux-kernel+bounces-92724-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <tencent_E7385EE2AEC4B486DC343AF1A108DE68370A@qq.com>
Content-Type: text/plain;
	charset=utf-8
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.400.31\))
Subject: Re: [PATCH v3 7/7] riscv: config: enable SOC_CANAAN in defconfig
From: Yangyu Chen <cyy@cyyself.name>
In-Reply-To: <2a206c9b-b570-4081-b4e4-d177343482f3@kernel.org>
Date: Wed, 6 Mar 2024 00:55:52 +0800
Cc: linux-riscv@lists.infradead.org,
 Conor Dooley <conor@kernel.org>,
 Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Paul Walmsley <paul.walmsley@sifive.com>,
 Palmer Dabbelt <palmer@dabbelt.com>,
 Albert Ou <aou@eecs.berkeley.edu>,
 Guo Ren <guoren@kernel.org>,
 devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org,
 Conor Dooley <conor.dooley@microchip.com>
Content-Transfer-Encoding: quoted-printable
References: <tencent_BB2364BBF1812F4E304F7BDDD11E57356605@qq.com>
 <tencent_E2812086B695A334EE5E8C70C85CA3171F06@qq.com>
 <2a206c9b-b570-4081-b4e4-d177343482f3@kernel.org>
To: Damien Le Moal <dlemoal@kernel.org>


> On Mar 5, 2024, at 07:50, Damien Le Moal <dlemoal@kernel.org> wrote:
>=20
> On 3/5/24 06:06, Yangyu Chen wrote:
>> Since K230 has been supported, allow SOC_CANAAN to be selected to =
build dt
>> and drivers for it in defconfig.
>>=20
>> Signed-off-by: Yangyu Chen <cyy@cyyself.name>
>> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
>> ---
>> arch/riscv/configs/defconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>=20
>> diff --git a/arch/riscv/configs/defconfig =
b/arch/riscv/configs/defconfig
>> index 89a009a580fe..20b557ec28df 100644
>> --- a/arch/riscv/configs/defconfig
>> +++ b/arch/riscv/configs/defconfig
>> @@ -33,6 +33,7 @@ CONFIG_SOC_STARFIVE=3Dy
>> CONFIG_ARCH_SUNXI=3Dy
>> CONFIG_ARCH_THEAD=3Dy
>> CONFIG_SOC_VIRT=3Dy
>> +CONFIG_SOC_CANAAN=3Dy
>=20
> Given that the k210 need !MMU, including it like this in the defconfig =
is
> odd... I do not even see how that could work. But that depends on =
patch 5,
> which does not seem OK to me.
>=20

I don=E2=80=99t know why =E2=80=9Cnot seem OK=E2=80=9D here.

I will show the console to tell you what changes in defconfig:

```console
$  linux git:(rv_builtin_dtb_v3) make ARCH=3Driscv =
CROSS_COMPILE=3Driscv64-linux-gnu- defconfig
*** Default configuration is based on 'defconfig'
#
# configuration written to .config
#
$  linux git:(rv_builtin_dtb_v3) cp .config .config.bak
$  linux git:(rv_builtin_dtb_v3) git checkout k230_dt_initial_v3
Switched to branch 'k230_dt_initial_v3'
$  linux git:(k230_dt_initial_v3) make ARCH=3Driscv =
CROSS_COMPILE=3Driscv64-linux-gnu- defconfig
*** Default configuration is based on 'defconfig'
#
# configuration written to .config
#
$  linux git:(k230_dt_initial_v3) diff .config .config.bak
301,302d300
< CONFIG_ARCH_CANAAN=3Dy
< CONFIG_SOC_CANAAN=3Dy
2678d2675
< CONFIG_PINCTRL_K210=3Dy
4621d4617
< CONFIG_COMMON_CLK_K210=3Dy
4<
706,4707d4701
< CONFIG_SOC_K210_SYSCTL=3Dy
5334d5327
< CONFIG_ARCH_HAS_RESET_CONTROLLER=3Dy
5336d5328
< CONFIG_RESET_K210=3Dy
$  linux git:(k230_dt_initial_v3) grep -r =
"CONFIG_ARCH_HAS_RESET_CONTROLLER"
kernel/config_data:CONFIG_ARCH_HAS_RESET_CONTROLLER=3Dy
include/config/auto.conf:CONFIG_ARCH_HAS_RESET_CONTROLLER=3Dy
include/generated/autoconf.h:#define CONFIG_ARCH_HAS_RESET_CONTROLLER 1
include/generated/rustc_cfg:--cfg=3DCONFIG_ARCH_HAS_RESET_CONTROLLER
include/generated/rustc_cfg:--cfg=3DCONFIG_ARCH_HAS_RESET_CONTROLLER=3D"y"=

config:CONFIG_ARCH_HAS_RESET_CONTROLLER=3Dy
$  linux git:(k230_dt_initial_v3)
```

As you can see, we only have some drivers enabled for K210 and
CONFIG_ARCH_HAS_RESET_CONTROLLER being enabled. The next grep -r shows =
it
does not change the kernel behavior.

>> CONFIG_SMP=3Dy
>> CONFIG_HOTPLUG_CPU=3Dy
>> CONFIG_PM=3Dy
>=20
> --=20
> Damien Le Moal
> Western Digital Research