Received: by 2002:a89:2c3:0:b0:1ed:23cc:44d1 with SMTP id d3csp372926lqs; Tue, 5 Mar 2024 04:55:45 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUGmH1ZbUqM9On0Qz4up6nk5+yaQ+xB/1NqjVJiNg/J4Npu1xGEMAdpvO1xZgOM2q90RgPY5oXZ1LT0oDgX6lBy9b0OfYW1U0ua/4QtWw== X-Google-Smtp-Source: AGHT+IHqhotJ8+zCmznMwc3ntnnmNUfdEGdmflQhygaKA0epZ4eMA/azUQIN/loJfYVgH4lzrZi9 X-Received: by 2002:ac8:5d49:0:b0:42e:b8e8:dcd9 with SMTP id g9-20020ac85d49000000b0042eb8e8dcd9mr1651418qtx.15.1709643345498; Tue, 05 Mar 2024 04:55:45 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709643345; cv=pass; d=google.com; s=arc-20160816; b=RvrW9X1Q8OSRZFr1xSQbzFHMItDuP3ag6jv9crtq/pnYoERbcSsWikcMn2V8jfT2dE zgm8goryO3gteDlKyjxabDxSoTdFO4s9hX2me0jFlZslMLpisONUHVwSI6RDGkbAMBfZ Toa+kEkLeGqnsiq9EA3MkbAikiY7cF1nKG2O6Hi/leARzOnhJS3mKOZVorY3MZq6iIqU ufqeI+K+S4UxVYg8upCOnZnQqCEZVPcXdPlybGfZzMLzB7q2n6z5scl1SX29ux/A7p2e 7hZnpnpfhKZdeHdCr7YA3POoH2QahNnkNOtxxqpxFOU7i8IFCMeq33EfwpuZRFkj2Ino GtSg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:user-agent:date :message-id:from:references:cc:to:subject; bh=emH1T4ln4UNgH1FvQDF0gEv4wLTdY1+KrVbyFUTNXIs=; fh=l0LGNhmPia+VThkjdmNpLxVohbUnAndDhEk3E5iHwX8=; b=YMO5js6y2mMzqFl4iABIEYqgODe820Yjulnim2jwrX8/ks/p81AC+7ZX027GC2cGH5 Bov6q3A1AZUB3kT59n8Nm7cAIv07bB3ATdUOUyzRgO03GdI8WsTMvJt/VyDoHk9vISZk xb2c3fmRSk3dBoL49h8JWdKe+RY2dd5kaNhxeajpSf39nkWxzdsdgGnPiPTJHG0eSCZ7 /CM9VzaO1Nq95Y7lnrBjNkhQAdw2R7h/yPz751GoBoHl+Bzd5wn1pzPKeRbLDM06EQ8l QYs32+b395YLhN6lXbNB0jXzw4ASsqz4aDHvONnS3EF2MRojHBD3XLfXcgZQiHaDpAnr 3+Gw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=huawei.com dmarc=pass fromdomain=huawei.com); spf=pass (google.com: domain of linux-kernel+bounces-92398-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-92398-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=QUARANTINE) header.from=huawei.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id kd24-20020a056214401800b00690047b8128si12123131qvb.190.2024.03.05.04.55.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Mar 2024 04:55:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-92398-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=huawei.com dmarc=pass fromdomain=huawei.com); spf=pass (google.com: domain of linux-kernel+bounces-92398-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-92398-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=QUARANTINE) header.from=huawei.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 32B341C21013 for ; Tue, 5 Mar 2024 12:55:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D9E4A81AB4; Tue, 5 Mar 2024 12:55:06 +0000 (UTC) Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AD4F58AB6; Tue, 5 Mar 2024 12:55:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.32 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709643306; cv=none; b=XJTUTrFGkaBYG2kD4epP1L+k+lHRP32YG/qDtzDGeaMX3qrL3XeDiBTxHTk3szCX90bZrv6FT84iuiZeAQSgCmcvNVKS3keFhH1Oqm+Vl1mRNjIlE2ljYGEHYlh9CcN+73PW9dzcaBX8npuU3enJFAumu2dSxB6QG+p/zkzikyk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709643306; c=relaxed/simple; bh=emH1T4ln4UNgH1FvQDF0gEv4wLTdY1+KrVbyFUTNXIs=; h=Subject:To:CC:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=fNQ0nGYfNrLvXidigpjWXcnkllgd43COsHnaVFNtG93rqKp/u/Rmp5Lu82TQUPs3Ml9HrS+FamWFzL0D9X6Ns6ePsxmu035AXA8PuOJhNkdz6WTwoNOsLrP+taWM+797EwNIWa3eFK3Jpcm8KcPPc6+AyOktg0DPJqonSiSOq78= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.234]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4TpwW20SkKz1vvwk; Tue, 5 Mar 2024 20:54:22 +0800 (CST) Received: from dggpemm500005.china.huawei.com (unknown [7.185.36.74]) by mail.maildlp.com (Postfix) with ESMTPS id D89411402E1; Tue, 5 Mar 2024 20:55:01 +0800 (CST) Received: from [10.69.30.204] (10.69.30.204) by dggpemm500005.china.huawei.com (7.185.36.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 5 Mar 2024 20:55:01 +0800 Subject: Re: [RFC PATCH net-next v6 03/15] net: page_pool: factor out page_pool recycle check To: Mina Almasry , , , , , , , , , , , , , CC: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan Corbet , Richard Henderson , Ivan Kokshaysky , Matt Turner , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Andreas Larsson , Jesper Dangaard Brouer , Ilias Apalodimas , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Arnd Bergmann , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , David Ahern , Willem de Bruijn , Shuah Khan , Sumit Semwal , =?UTF-8?Q?Christian_K=c3=b6nig?= , Pavel Begunkov , David Wei , Jason Gunthorpe , Shailend Chand , Harshitha Ramamurthy , Shakeel Butt , Jeroen de Borst , Praveen Kaligineedi References: <20240305020153.2787423-1-almasrymina@google.com> <20240305020153.2787423-4-almasrymina@google.com> From: Yunsheng Lin Message-ID: <3732e5ba-9cfb-f6de-09e2-fab4f46a11d8@huawei.com> Date: Tue, 5 Mar 2024 20:55:01 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20240305020153.2787423-4-almasrymina@google.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500005.china.huawei.com (7.185.36.74) On 2024/3/5 10:01, Mina Almasry wrote: > The check is duplicated in 2 places, factor it out into a common helper. Reviewed-by: Yunsheng Lin