Received-SPF: pass (google.com: domain of linux-kernel+bounces-104042-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20231117125807.1058477-1-masahiroy@kernel.org>
 <CAK7LNAStoCja1gnoFmsKikbzGZmKTcTu+Vc7v9zg8B9hwsH+iQ@mail.gmail.com>
 <CAK7LNATVAcj-pa_G-NGBTr9doCACGk1nKCNbxM50-M0mi9q=7w@mail.gmail.com> <ca097f2a-59ec-4945-9860-5e380e1665e4@ghiti.fr>
In-Reply-To: <ca097f2a-59ec-4945-9860-5e380e1665e4@ghiti.fr>
From: Masahiro Yamada <masahiroy@kernel.org>
Date: Fri, 15 Mar 2024 13:06:09 +0900
Message-ID: <CAK7LNARShVA953-U+p6=wzq3GFsKx4GwpRiqmqftjQz3VkE2VA@mail.gmail.com>
Subject: Re: [PATCH] riscv: compat_vdso: install compat_vdso.so.dbg to /lib/modules/*/vdso/
To: Alexandre Ghiti <alex@ghiti.fr>
Cc: Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, 
	Albert Ou <aou@eecs.berkeley.edu>, linux-riscv@lists.infradead.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Mar 7, 2024 at 5:12=E2=80=AFAM Alexandre Ghiti <alex@ghiti.fr> wrot=
e:
>
> Hi Masahiro,
>
> On 24/02/2024 04:37, Masahiro Yamada wrote:
> > Ping x 2 ?
> >
> >
> >
> >
> >
> > On Sun, Jan 21, 2024 at 6:48=E2=80=AFAM Masahiro Yamada <masahiroy@kern=
el.org> wrote:
> >> On Fri, Nov 17, 2023 at 9:58=E2=80=AFPM Masahiro Yamada <masahiroy@ker=
nel.org> wrote:
> >>> 'make vdso_install' installs debug vdso files to /lib/modules/*/vdso/=
.
> >>>
> >>> Only for the compat vdso on riscv, the installation destination diffe=
rs;
> >>> compat_vdso.so.dbg is installed to /lib/module/*/compat_vdso/.
> >>>
> >>> To follow the standard install destination and simplify the vdso_inst=
all
> >>> logic, change the install destination to standard /lib/modules/*/vdso=
/.
> >>>
> >>> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> >>> ---
> >>
> >> Ping?
> >> (in case "yet more RISC-V updates" happens)
> >>
> >>
> >>
> >>
> >>>   arch/riscv/Makefile | 2 +-
> >>>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/arch/riscv/Makefile b/arch/riscv/Makefile
> >>> index a74be78678eb..5cbe596345c1 100644
> >>> --- a/arch/riscv/Makefile
> >>> +++ b/arch/riscv/Makefile
> >>> @@ -146,7 +146,7 @@ endif
> >>>   endif
> >>>
> >>>   vdso-install-y                 +=3D arch/riscv/kernel/vdso/vdso.so.=
dbg
> >>> -vdso-install-$(CONFIG_COMPAT)  +=3D arch/riscv/kernel/compat_vdso/co=
mpat_vdso.so.dbg:../compat_vdso/compat_vdso.so
> >>> +vdso-install-$(CONFIG_COMPAT)  +=3D arch/riscv/kernel/compat_vdso/co=
mpat_vdso.so.dbg
> >>>
> >>>   ifneq ($(CONFIG_XIP_KERNEL),y)
> >>>   ifeq ($(CONFIG_RISCV_M_MODE)$(CONFIG_ARCH_CANAAN),yy)
> >>> --
> >>> 2.40.1
> >>>
> >>
> >> --
> >> Best Regards
> >> Masahiro Yamada
> >
> >
> > --
> > Best Regards
> > Masahiro Yamada
> >
> > _______________________________________________
> > linux-riscv mailing list
> > linux-riscv@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-riscv
>
>
> Couldn't changing this library install path break some existing
> application? I mean it kind of breaks where the library is expected to
> be right?


Do you have a particular library in mind?


RISV-V is the only architecture that installs a debug vdso
to a different location than the
standard lib/modules/*/vdso/.


I regard this as a fix.


--=20
Best Regards
Masahiro Yamada