Received-SPF: pass (google.com: domain of linux-kernel+bounces-104104-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 15 Mar 2024 08:16:21 +0100
From: Nicolas Schier <nicolas@fjasle.eu>
To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= <u.kleine-koenig@pengutronix.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Masahiro Yamada <masahiroy@kernel.org>, kernel@pengutronix.de,
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] lib/build_OID_registry: Don't mention the full path
 of the script in output
Message-ID: <ZfP1xdcYlUawm3uV@bergen.fjasle.eu>
References: <20240313211957.884561-2-u.kleine-koenig@pengutronix.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="0mj95xAbx5R1PIon"
Content-Disposition: inline
In-Reply-To: <20240313211957.884561-2-u.kleine-koenig@pengutronix.de>
Jabber-ID: nicolas@jabber.no


--0mj95xAbx5R1PIon
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed 13 Mar 2024 22:19:56 GMT, Uwe Kleine-K=F6nig wrote:
> Date: Wed, 13 Mar 2024 22:19:56 +0100
> From: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>
> To: Andrew Morton <akpm@linux-foundation.org>
> Cc: Masahiro Yamada <masahiroy@kernel.org>, kernel@pengutronix.de,
>  linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
> Subject: [PATCH v2] lib/build_OID_registry: Don't mention the full path of
>  the script in output
> Message-ID: <20240313211957.884561-2-u.kleine-koenig@pengutronix.de>
> X-Mailer: git-send-email 2.43.0
> X-Mailing-List: linux-kbuild@vger.kernel.org
>=20
> This change strips the full path of the script generating
> lib/oid_registry_data.c to just lib/build_OID_registry. The motivation
> for this change is Yocto emitting a build warning
>=20
> 	File /usr/src/debug/linux-lxatac/6.7-r0/lib/oid_registry_data.c in packa=
ge linux-lxatac-src contains reference to TMPDIR [buildpaths]
>=20
> So this change brings us one step closer to make the build result
> reproducible independent of the build path.
>=20
> Signed-off-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>
> ---
> Changes since (implicit) v1, archived at
> https://lore.kernel.org/lkml/20240311110121.459581-2-u.kleine-koenig@peng=
utronix.de:
>=20
>  - Handle abs_srctree not being exported any more
>=20
> The v1 patch made it into next but im combination with commit e2bad142bb3d
> ("kbuild: unexport abs_srctree and abs_objtree") resulted in a build warn=
ing
> about $ENV{"abs_srctree"} being uninitialized which required this respin.
>=20
> Best regards
> Uwe
>=20
>  lib/build_OID_registry | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>=20
> diff --git a/lib/build_OID_registry b/lib/build_OID_registry
> index d7fc32ea8ac2..56d8bafeb848 100755
> --- a/lib/build_OID_registry
> +++ b/lib/build_OID_registry
> @@ -8,6 +8,7 @@
>  #
> =20
>  use strict;
> +use Cwd qw(abs_path);
> =20
>  my @names =3D ();
>  my @oids =3D ();
> @@ -17,6 +18,8 @@ if ($#ARGV !=3D 1) {
>      exit(2);
>  }
> =20
> +my $abs_srctree =3D abs_path($ENV{'srctree'});
> +
>  #
>  # Open the file to read from
>  #
> @@ -35,7 +38,7 @@ close IN_FILE || die;
>  #
>  open C_FILE, ">$ARGV[1]" or die;
>  print C_FILE "/*\n";
> -print C_FILE " * Automatically generated by ", $0, ".  Do not edit\n";
> +print C_FILE " * Automatically generated by ", $0 =3D~ s#^\Q$abs_srctree=
/\E##r, ".  Do not edit\n";

I'd rather remove the script name from the comment or hard-code the=20
file name, but this is correct as it is.

Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>

--0mj95xAbx5R1PIon
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEh0E3p4c3JKeBvsLGB1IKcBYmEmkFAmXz9b8ACgkQB1IKcBYm
Emk/AxAA2HczsXAYEJ0izKaGPxnW0T2YOi1oC5XuGrjmnzeLZuu/JJIpmQdPyP2T
iJ2YpbcbZfAhBGteDjzDFjoDLnED5YjfTDWD+pQWYkrWXy27AzvfykdvMRwECFRD
FdSn2RoKrQChljtSz5OLoIcxSesGU+/iPhdDR98VimlNyaS8uPvjkXcj4r6me84a
qvrdC4CyhA2fCe3lk2d1nGc/ZJudqYJRAhNuIFo84WDUVPIA62lxNK/K5J69/mdI
foci2JMqouPdgqnTXBmlri4uwaUJDQgiGFCkPpTw6T8+jxRoSnFu1t41mkTBg9Yd
rLzOKVJooD6F2ihrkWyGUL5+d7xr6cDChyUnwYBpiPmGPamL/cRK/pJQFwq7Bzy4
CB1pMBqDvp1EwM9DSC4665SawZhzbBNfu01mwYmTjiIhFzN+Qq/qiA9DsKj5NzBu
lQfPoOcVEJ6RC3Y8QfsupmFlFBO1mYQOtoSlHGgh9kYnRq9bHKAWB0e8iZta2nOz
eGH3gE9MgvRiV8cHWyr87R3pMHnbW6N8x9CIghwF5Exp27MyQN8mgNUZfH5VqFXU
a374p1FjFC17FktlXuSgJtDwIoQHDpEc37Tvz49TWNXjGt8lmA/GIthGDZBaQDGN
yWt2OpQpL0K7WbVFbPJ0mLOI8rWwpEkHxiC68WTrKOYiR2IAYDU=
=VqKJ
-----END PGP SIGNATURE-----

--0mj95xAbx5R1PIon--