Message-ID: <4783AFE5.6040102@ct.jp.nec.com>
Date: Tue, 08 Jan 2008 09:16:21 -0800
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
User-Agent: Thunderbird 2.0.0.9 (Windows/20071031)
MIME-Version: 1.0
To: Ingo Molnar <mingo@elte.hu>
Cc: mingo@redhat.com, tglx@linutronix.de, hpa@zytor.com,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86_64: enable irq in default_idle
References: <4782984F.3050601@ct.jp.nec.com> <20080108080419.GD31838@elte.hu>
In-Reply-To: <20080108080419.GD31838@elte.hu>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 936
Lines: 30

Ingo Molnar wrote:
> * Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> wrote:
> 
>> Hi Ingo,
>>
>> I think local_irq_enable() is missing in default_idle() on x86_64. 
>> It's for recent x86 tree.
>>
>> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
>> Subject: [PATCH] x86_64: enable irq in default_idle
>>
>> local_irq_enable() is missing after sched_clock_idle_wakeup_event().
> 
> thanks Hiroshi, applied.
> 
> The effects of this bug should be increased latencies on 64-bit. Did you 
> notice these latencies, or did you find the bug in some other way (code 
> review)?

I found this when I was comparing 32-bit and 64-bit source code
for x86 unification.

Thanks,
Hiroshi Shimamoto

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/