Received-SPF: pass (google.com: domain of linux-kernel+bounces-104125-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 15 Mar 2024 14:43:18 +0700
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Herve Codina <herve.codina@bootlin.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Yury Norov <yury.norov@gmail.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Networking <netdev@vger.kernel.org>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v2] lib/bitmap: Fix bitmap_scatter() and bitmap_gather()
 kernel doc
Message-ID: <ZfP8FowhZ3ZtSq2T@archie.me>
References: <20240314120006.458580-1-herve.codina@bootlin.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Vkpw4sfr+qcOP7vO"
Content-Disposition: inline
In-Reply-To: <20240314120006.458580-1-herve.codina@bootlin.com>


--Vkpw4sfr+qcOP7vO
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Mar 14, 2024 at 01:00:06PM +0100, Herve Codina wrote:
> diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h
> index fb3a9c93ac86..aa4096126553 100644
> --- a/include/linux/bitmap.h
> +++ b/include/linux/bitmap.h
> @@ -522,17 +522,18 @@ static inline void bitmap_replace(unsigned long *ds=
t,
>   *
>   * (Bits 0, 1, 2, 3, 4, 5 are copied to the bits 0, 1, 4, 8, 9, 12)
>   *
> - * A more 'visual' description of the operation:
> - * src:  0000000001011010
> - *                 ||||||
> - *          +------+|||||
> - *          |  +----+||||
> - *          |  |+----+|||
> - *          |  ||   +-+||
> - *          |  ||   |  ||
> - * mask: ...v..vv...v..vv
> - *       ...0..11...0..10
> - * dst:  0000001100000010
> + * A more 'visual' description of the operation::
> + *
> + *	src:  0000000001011010
> + *	                ||||||
> + *	         +------+|||||
> + *	         |  +----+||||
> + *	         |  |+----+|||
> + *	         |  ||   +-+||
> + *	         |  ||   |  ||
> + *	mask: ...v..vv...v..vv
> + *	      ...0..11...0..10
> + *	dst:  0000001100000010
>   *
>   * A relationship exists between bitmap_scatter() and bitmap_gather().
>   * bitmap_gather() can be seen as the 'reverse' bitmap_scatter() operati=
on.
> @@ -568,16 +569,17 @@ static inline void bitmap_scatter(unsigned long *ds=
t, const unsigned long *src,
>   *
>   * (Bits 0, 1, 4, 8, 9, 12 are copied to the bits 0, 1, 2, 3, 4, 5)
>   *
> - * A more 'visual' description of the operation:
> - * mask: ...v..vv...v..vv
> - * src:  0000001100000010
> - *          ^  ^^   ^   0
> - *          |  ||   |  10
> - *          |  ||   > 010
> - *          |  |+--> 1010
> - *          |  +--> 11010
> - *          +----> 011010
> - * dst:  0000000000011010
> + * A more 'visual' description of the operation::
> + *
> + *	mask: ...v..vv...v..vv
> + *	src:  0000001100000010
> + *	         ^  ^^   ^   0
> + *	         |  ||   |  10
> + *	         |  ||   > 010
> + *	         |  |+--> 1010
> + *	         |  +--> 11010
> + *	         +----> 011010
> + *	dst:  0000000000011010
>   *
>   * A relationship exists between bitmap_gather() and bitmap_scatter(). S=
ee
>   * bitmap_scatter() for the bitmap scatter detailed operations.

LGTM, thanks!

Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>

--=20
An old man doll... just what I always wanted! - Clara

--Vkpw4sfr+qcOP7vO
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCZfP8EwAKCRD2uYlJVVFO
owRnAP9+A9A7YmJqbQ2uV2vnT+S7PoxF2bX1VkyDqbjfObqyFAEA2VkJEBlkBFez
dVNRdRo6w3txtpn1mAv+fYEFEEItYgY=
=2+Hm
-----END PGP SIGNATURE-----

--Vkpw4sfr+qcOP7vO--