Received-SPF: pass (google.com: domain of linux-kernel+bounces-104156-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Fri, 15 Mar 2024 16:21:13 +0800
From: kernel test robot <oliver.sang@intel.com>
To: Christoph Hellwig <hch@lst.de>
CC: <oe-lkp@lists.linux.dev>, <lkp@intel.com>, <linux-kernel@vger.kernel.org>,
	Keith Busch <kbusch@kernel.org>, Max Gurtovoy <mgurtovoy@nvidia.com>,
	<linux-nvme@lists.infradead.org>, <ying.huang@intel.com>,
	<feng.tang@intel.com>, <fengwei.yin@intel.com>, <oliver.sang@intel.com>
Subject: [linus:master] [nvme]  63dfa10043:  fsmark.files_per_sec 6.4%
 improvement
Message-ID: <202403151552.e3809b61-oliver.sang@intel.com>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?29VOB02kYUZwAU4Ap0vPsZkYiV/RoOn+7DToyAbxYOU7LqTtpgm53H6coX?=
 =?iso-8859-1?Q?p2fV1sxKowCnm2+nJDNIfMxbOiVQMaWDt+/rlQQqJo+JXOYs45qcW2bcdC?=
 =?iso-8859-1?Q?j1WFtt89s4aSsP3CptLZ5XhmBSDq3j16aj+okeA9QYyVKo9PMBjH/tDOGl?=
 =?iso-8859-1?Q?Cma5PrFg7FpdRQC6b8ZusZv5vde86Zsdub3m8h4FpczCGHESmWcEvf55+8?=
 =?iso-8859-1?Q?PAqNn7gIFmDvwes843RTd1HoC+6x1dT9pXCoEpHQ8h81IIAZnGYsYJs+jL?=
 =?iso-8859-1?Q?O6ZbakCjMAoIHgUHSJM3S1WdZYNe5ZdKHkuiAAnFA5ucSGkoe0acUxSbPn?=
 =?iso-8859-1?Q?c6VWAyBVlHgfnxC+0KZEdlL8xa4maIsakj82Sb0uOcr8Xwg8rV5rnx3zH0?=
 =?iso-8859-1?Q?nF0/o7R5I3VhbQ+F3fuya8dpcKKvuIWdovcgclpDfGVb1G/K8vkF6UWkbX?=
 =?iso-8859-1?Q?RmrGazxwKE9K7lxJUIazNqKFBcKGd6a9yQxztZGeXmVdK9YnIM8V70zE+O?=
 =?iso-8859-1?Q?xeO+40ZdksnJE8ec/riT48HyEbYeNeqwBDpFMYnA+jzEAwmiPREj8xKx1Y?=
 =?iso-8859-1?Q?dRwboYNdi4q1wYUx63y1MfAqYVbCI3kOmlmbmGOdUwOtzWJ86a57L2kaaf?=
 =?iso-8859-1?Q?IJOSMKdefjpTI1F/zTEKGE2ZfXcZazjte5BuBCoi3pcRShq/xagpzMfHu0?=
 =?iso-8859-1?Q?TdLuevSW0zdFywmjIZUpCbNkN67qyFqMvpvWq1ELhpJW01YdjeU4UK3mDS?=
 =?iso-8859-1?Q?vPIRJGX/+i2RaTff+SsDMfbMKpAugO40Azd7Uxj90UjBek+c/wm1BB4KGs?=
 =?iso-8859-1?Q?Ep4mv5+DMV/kTTnuGY3kK38BaiaaxKaeEiTVVlAVWQR/rWEeJFL4FrEmpY?=
 =?iso-8859-1?Q?32G2B1yPA1w0XzUcWymJ8fXEbNNT/eTVs/NgHcXdrCP7pLgDMthjDYIIhE?=
 =?iso-8859-1?Q?+mMZsmsURryTW9luy6dXk45BS+t/VXSkffLRPrffb9KH/7T/+GApJ+iWUH?=
 =?iso-8859-1?Q?vTf1l9vMYex6yO/ta68IDG5z7IXDkTWFxrCF4RWKfWkXvGK+RoO/MG08UL?=
 =?iso-8859-1?Q?IEZ1P8EVYD565A6ZZxaBWAZ5jv5LpA0jvH2opQVm+urv1np7ifqf5qBrQ3?=
 =?iso-8859-1?Q?/3HnCi2KL+QWCWZnqOibsXl0iYJHOgZZ549cA11eRMt1MpSJSviqt3guS6?=
 =?iso-8859-1?Q?aP/AFQB/5jUEzL3uueA73wUejBNUxymuqeqXDXMsxt7F4NP7CiPlBU1DPK?=
 =?iso-8859-1?Q?F7TZplyPJ6zaRfBgTSBRA4vKwOOiwSa61B9+BRle1bhHS8EAZUl8g/J/DA?=
 =?iso-8859-1?Q?zOu0joGKaSbw5Uz/hSCI3An/rio5dTdk4XgfUQKEKKLY4+xq81o29zKg/D?=
 =?iso-8859-1?Q?Ns7cB93jdYuPbiqi5lkUmYD22Q0iev7e/XfAgP13nJbxKkRJowTDF7fybu?=
 =?iso-8859-1?Q?dlgVgMKR3MxbBszqwvlrRWNqvRK/pm5m2vLrorXi6aKWO1Avqi+5T18lQX?=
 =?iso-8859-1?Q?VFDhznwhxHeh35ZStYdVgs3n8wR2FGxnzCPxrDUljk/W38TZinVL36N735?=
 =?iso-8859-1?Q?Mi0fqv7l+aXT0fmpCEQjIId3yWw5KB60EkLg2xt0euaqJYKoku414NP3IL?=
 =?iso-8859-1?Q?Hmvt30JYxWtE8iYhGf8dbTU1JLd0XtQFBF1d5AAMypYyAAaWVmNB2e4A?=
 =?iso-8859-1?Q?=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 42764ad6-b8a4-4b5b-92ab-08dc44c8e5ea
X-MS-Exchange-CrossTenant-AuthSource: LV3PR11MB8603.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2024 08:21:22.4554
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vmkLB8BanRG80jX2DvLPMcRVcN5mQ8VIBu7FeUQ+DkzwU/ng99xvlLgG7QunKKIGM06rZUWxMHfu1zj02f9v8A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7875
X-OriginatorOrg: intel.com


Hello,

kernel test robot noticed a 6.4% improvement of fsmark.files_per_sec on:


commit: 63dfa1004322d596417f23da43cdc43cf6298c71 ("nvme: move NVME_QUIRK_DEALLOCATE_ZEROES out of nvme_config_discard")
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master

testcase: fsmark
test machine: 96 threads 2 sockets Intel(R) Xeon(R) Platinum 8260L CPU @ 2.40GHz (Cascade Lake) with 128G memory
parameters:

	iterations: 8
	disk: 1SSD
	nr_threads: 16
	fs: ext4
	filesize: 8K
	test_size: 75G
	sync_method: fsyncBeforeClose
	nr_directories: 16d
	nr_files_per_directory: 256fpd
	cpufreq_governor: performance


Details are as below:
-------------------------------------------------------------------------------------------------->


The kernel config and materials to reproduce are available at:
https://download.01.org/0day-ci/archive/20240315/202403151552.e3809b61-oliver.sang@intel.com

=========================================================================================
compiler/cpufreq_governor/disk/filesize/fs/iterations/kconfig/nr_directories/nr_files_per_directory/nr_threads/rootfs/sync_method/tbox_group/test_size/testcase:
  gcc-12/performance/1SSD/8K/ext4/8/x86_64-rhel-8.3/16d/256fpd/16/debian-12-x86_64-20240206.cgz/fsyncBeforeClose/lkp-csl-2sp3/75G/fsmark

commit: 
  152694c829 ("nvme: set max_hw_sectors unconditionally")
  63dfa10043 ("nvme: move NVME_QUIRK_DEALLOCATE_ZEROES out of nvme_config_discard")

152694c82950a093 63dfa1004322d596417f23da43c 
---------------- --------------------------- 
         %stddev     %change         %stddev
             \          |                \  
    492322 ?  8%     +15.1%     566574 ?  2%  meminfo.Active(anon)
    501325 ?  8%     +15.0%     576573 ?  2%  meminfo.Shmem
    458144 ? 18%     +22.6%     561659 ?  2%  numa-meminfo.node1.Active(anon)
    462634 ? 18%     +22.6%     567357 ?  2%  numa-meminfo.node1.Shmem
    114517 ? 18%     +22.6%     140395 ?  2%  numa-vmstat.node1.nr_active_anon
    115654 ? 18%     +22.6%     141838 ?  2%  numa-vmstat.node1.nr_shmem
    114517 ? 18%     +22.6%     140395 ?  2%  numa-vmstat.node1.nr_zone_active_anon
    396.50          +745.6%       3353 ?181%  vmstat.memory.buff
    201414            +6.0%     213473        vmstat.system.cs
     57760            +5.4%      60879        vmstat.system.in
     22022 ?  2%      +6.4%      23432        fsmark.files_per_sec
    502.56            -5.9%     472.94        fsmark.time.elapsed_time
    502.56            -5.9%     472.94        fsmark.time.elapsed_time.max
    243.62 ?  2%      +5.0%     255.75        fsmark.time.percent_of_cpu_this_job_got
    123079 ?  8%     +15.1%     141624 ?  2%  proc-vmstat.nr_active_anon
      8462            +2.1%       8637        proc-vmstat.nr_mapped
    125342 ?  8%     +15.0%     144138 ?  2%  proc-vmstat.nr_shmem
    123079 ?  8%     +15.1%     141624 ?  2%  proc-vmstat.nr_zone_active_anon
    140970 ?  7%     +14.1%     160889 ?  2%  proc-vmstat.pgactivate
 3.617e+08            -3.7%  3.483e+08        proc-vmstat.pgpgout
      2.10 ?  9%      -0.2        1.85 ?  3%  perf-profile.calltrace.cycles-pp.__sysvec_apic_timer_interrupt.sysvec_apic_timer_interrupt.asm_sysvec_apic_timer_interrupt.cpuidle_enter_state.cpuidle_enter
      2.08 ?  9%      -0.2        1.84 ?  3%  perf-profile.calltrace.cycles-pp.hrtimer_interrupt.__sysvec_apic_timer_interrupt.sysvec_apic_timer_interrupt.asm_sysvec_apic_timer_interrupt.cpuidle_enter_state
      0.99 ? 20%      +0.4        1.37 ? 11%  perf-profile.calltrace.cycles-pp.jbd2__journal_start.ext4_do_writepages.ext4_writepages.do_writepages.filemap_fdatawrite_wbc
      0.50 ? 60%      +0.4        0.89 ? 14%  perf-profile.calltrace.cycles-pp.add_transaction_credits.start_this_handle.jbd2__journal_start.ext4_do_writepages.ext4_writepages
      2.50 ? 10%      -0.3        2.20 ?  3%  perf-profile.children.cycles-pp.__sysvec_apic_timer_interrupt
      2.48 ? 10%      -0.3        2.19 ?  3%  perf-profile.children.cycles-pp.hrtimer_interrupt
      0.24 ?  6%      +0.0        0.27 ?  6%  perf-profile.children.cycles-pp.ext4_dirty_inode
      0.19 ? 11%      +0.1        0.24 ?  6%  perf-profile.children.cycles-pp.ext4_block_bitmap_csum_set
 1.107e+09            +6.6%   1.18e+09        perf-stat.i.branch-instructions
    202521            +6.1%     214902        perf-stat.i.context-switches
 1.322e+10 ?  2%      +6.7%   1.41e+10        perf-stat.i.cpu-cycles
  5.46e+09            +6.6%  5.818e+09        perf-stat.i.instructions
      2.11            +6.2%       2.24        perf-stat.i.metric.K/sec
 1.105e+09            +6.6%  1.178e+09        perf-stat.ps.branch-instructions
    202013            +6.1%     214333        perf-stat.ps.context-switches
 1.319e+10 ?  2%      +6.7%  1.407e+10        perf-stat.ps.cpu-cycles
 5.448e+09            +6.5%  5.805e+09        perf-stat.ps.instructions


Disclaimer:
Results have been estimated based on internal Intel analysis and are provided
for informational purposes only. Any difference in system hardware or software
design or configuration may affect actual performance.


-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki