Received-SPF: pass (google.com: domain of linux-kernel+bounces-104177-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <fee79370-b992-46a0-a675-80b913d48e05@amlogic.com>
Date: Fri, 15 Mar 2024 16:48:40 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 3/4] arm64: dts: add support for A4 based Amlogic BA400
Content-Language: en-US
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>,
 Neil Armstrong <neil.armstrong@linaro.org>,
 Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
 Kevin Hilman <khilman@baylibre.com>, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 linux-amlogic@lists.infradead.org
References: <20240312-basic_dt-v1-0-7f11df3a0896@amlogic.com>
 <20240312-basic_dt-v1-3-7f11df3a0896@amlogic.com>
 <1jsf0vephv.fsf@starbuckisacylon.baylibre.com>
 <9a38fd52-5eea-468d-bd7c-29a505503268@amlogic.com>
 <1jcyrxi2l0.fsf@starbuckisacylon.baylibre.com>
From: Xianwei Zhao <xianwei.zhao@amlogic.com>
In-Reply-To: <1jcyrxi2l0.fsf@starbuckisacylon.baylibre.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VUlyeHpoN2ZHb2dSK3hoblBuS00wM2wweG5wMVRab25MTFhUVEwxdUJDZ2ha?=
 =?utf-8?B?SkV1c1FJK3VmUDRJc2N3ZEdHUVZtN0dydUQ4cG5ISjI4UlJWMGtKVitTVDN1?=
 =?utf-8?B?VzRsREJ3eVBRRTJFR2NnVXZ6dDEvVllZY3BsWWxYWlBQdTdNM21uTDF6Tmh4?=
 =?utf-8?B?ZFNIZFV6VmFsdW8reFY1VUE2Z1JmeXAzdFArdnVzTjFZOHlDK1lnMXNCVm9z?=
 =?utf-8?B?Y3pRM1lncWNVMS9ObXNGa0kxb3l3NlMzak5OekRTUThMbHlhbHpnTE82czU3?=
 =?utf-8?B?TlgvdExLdnp3S2tGN2cyT25mUmtoZ0VQWTdBYmdrekZ1TUd3S282WFl2NnJ2?=
 =?utf-8?B?cFpNNzZWZjBMelR1TWV2Y3R0bTB1V1dHeWdEeTFnU0QwckIyaUZtUkhsaDUz?=
 =?utf-8?B?ZEpSZmtPMUJVNVZ2QlZBSVd0MVZmUnVTcW1veHdoaUdncGl6TWJYaUlSZlNL?=
 =?utf-8?B?cHEvenI4QVJ3UmQzNC9IS3Rvb3J5d05PZzJBMmZHUTVDWWwzYWxJZFlULzVZ?=
 =?utf-8?B?S3dhVVUxdzdKN1lRZVRmbUtoenlPaVNhb2RobzMwdis1Y3VhUW5PTjNTNEg0?=
 =?utf-8?B?dFJid3BGWlBXR0h6ODNzWExNU21uN2x6Ujk1TXFNVDY5dWtOblp6MXAzdTJ1?=
 =?utf-8?B?cHE2MGxtTGk2cmE0WnFYNXVRQ0xsSW1UaTBCRjA1b2p4aVBGYTIreXRqelBy?=
 =?utf-8?B?K0RWWEwwMGZsNHdXYXY1eHJVVFRaczhIbEFDTmUrK0MxYWxqRDk3S0hpSytq?=
 =?utf-8?B?UzVzM2JRTm9waVl3NVFxS2ZxTVFsS2trdE10QTVOV1dWVHNDZWlCL2hIUjhW?=
 =?utf-8?B?M3A3VU9UUUZJUVRoaVhqSGJuNElLQ2YyNXFJWmI2Nm1kZTQ0ek1walRaV2F6?=
 =?utf-8?B?TnR1bWFoVG5JcjI2U1l5cU50aWE3S1hQS1o5SGhwVEQ3b21oMjdZd3dsN0wr?=
 =?utf-8?B?M1lVUDdCNXVSRDNWNklOYTRTNVczRjJzRHQ3UTdtSnJxamlrU05NK0JSV0dK?=
 =?utf-8?B?T1dWcVlXNWIvUlhxTmdPOFplVGtPZTlEcFlPRWZuQmFwT3ZIaTZleGJSQlJ5?=
 =?utf-8?B?a3IzcWRhYVpjeDZHR2Yvc2l0NGtMZVBibU82WnFUaFFJYVdjVHBiZDRZTzVJ?=
 =?utf-8?B?L1VhbGpvZkpHczZicWF6elBsME5sWENwdC9PN2hEdUliQm5mNmZIUjc0YWlM?=
 =?utf-8?B?UlZwUkwzWEw1dFRHckxkdHFkNU1CYmhxR2hod29BMDFQeHpaek40NUxKWmp2?=
 =?utf-8?B?NHplWDE3Q2N4T2ZOSzdaRlIzdzY4VkljZGpxT2oxQ0NGMm5JYmszbWtKSTVl?=
 =?utf-8?B?OW1UVFJBdVNkVDNCWXkvdXNMN3pRQlc0eEFtZnZyU0JuYUh6dGZCZExxeWhX?=
 =?utf-8?B?N0pvZnIzSGlvUEJJajhFT3gwc1dwWWNONzNTMWRsN3pSSkF5Zm1KRUpBMWpo?=
 =?utf-8?B?VXgraDNlMEsxNmpGWG1CM2RHcmhISkdRNHlvUktQRkc3bnNqcjdXQjZIRnU2?=
 =?utf-8?B?UTdoZWNtT0VhQmhCRExKYnpTSlBCdndHa1dabG5RNm5JMUJtRXhLY0JUb2Q3?=
 =?utf-8?B?TmdXSFBJemM4VE01dVRDajZiU3EyNVdkWkwzdkhPVmY3Y0wyeGFIR1ZhNlUr?=
 =?utf-8?B?Y1BPSFozMXZXQzVqanBIdmJrb0lSdmo4cU1MWTdFNjBSOGFzM2RvUzJjd0dG?=
 =?utf-8?B?TE5ZVXZzYlYvSUREellBbmpBUEEwYXpSTzNtb0Z4SFgyL3MyTHVwRmd1WEVV?=
 =?utf-8?B?MHU2MU05TUNnYURBUk1EaFhKcXlKcDFhc3o0aHk2eWlHWWxxbXJrellNTU8y?=
 =?utf-8?B?aW0wM044TjFtelhBeGplK3lmOWVUSkFTZFVXOGIzRFZJenpaRnRMUG5Eb0Uw?=
 =?utf-8?B?akRhLzI0cHU3b2Q3Si93WW16V0FUK1VMSm43bFNnZ05YUm9tV2g0YTQ1OG5F?=
 =?utf-8?B?UlEvcC9PZTEvQ2doK0p2aWxFUnQxMm4xZWpDR1ovT0I2MXFhK3BVaDdnSC9o?=
 =?utf-8?B?cU9YWEIxMTc2N3M1a3VoMnRGZklEMVFmei84VmxvbWhXcGQwT0VUa1JrbUtG?=
 =?utf-8?B?eTRRUk44Ni95OUZTT0RXa0JCTzlWTHVrR2IrNEpDYXZvRG96L1NjYlBKWmF5?=
 =?utf-8?B?RGNGYUxXakpoa0lsbUw2OU9FUGUzMzliYzhSK1dNbTc2dyttRkpxc3NvNXBq?=
 =?utf-8?B?U1E9PQ==?=
X-OriginatorOrg: amlogic.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 64732050-5d10-443a-8621-08dc44ccbc67
X-MS-Exchange-CrossTenant-AuthSource: TYZPR03MB6896.apcprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2024 08:48:50.6375
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0df2add9-25ca-4b3a-acb4-c99ddf0b1114
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kuazDdj11MSbgVrd0RwYqEZgAJA8Jj5FW5p13Mbvj/xP1yz0rWrYBYKf9J44SGWj4cM9/sdwEoRDI+8RsPJk2BBBGDHoT80GKCOzZS4R548=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR03MB8657

Hi Jerome,
     Thanks for your reply.

On 2024/3/14 17:26, Jerome Brunet wrote:
> [ EXTERNAL EMAIL ]
> 
> On Thu 14 Mar 2024 at 16:08, Xianwei Zhao <xianwei.zhao@amlogic.com> wrote:
> 
>>>> +
>>>> +#include "amlogic-a4.dtsi"
>>> Could you describe how the a4 and a5 differs from each other ?
>>> The description given in the commit description is the same.
>>> Beside the a53 vs a55, I'm not seeing much of a difference.
>>> Admittedly, there is not much yet but I wonder if a4 and a5 should have
>>> a common dtsi.
>>>
>> They are mostly the same, A5 include HiFi-DSP and NPU, but A4 is not. And
>> some peripheral modules are different, such as SPI and Ehernet phy.
>>
>> I would like to wait for the follow-on chips to come out before considering
>> a merger with common dtsi file.
>>
> 
> No, Please do it now. There is no reason for the community to review the
> same thing twice if the SoCs are "mostly the same".
> 
OK, I will do it.
>>>> +
>>>> +/ {
>>>> +     model = "Amlogic A113L2 ba400 Development Board";
>>>> +     compatible = "amlogic,ba400","amlogic,a4";
>>>> +     interrupt-parent = <&gic>;
>>>> +     #address-cells = <2>;
>>>> +     #size-cells = <2>;
>>>> +
>>>> +     aliases {
>>>> +             serial0 = &uart_b;
>>>> +     };
>>>> +
>>>> +     memory@0 {
>>>> +             device_type = "memory";
>>>> +             reg = <0x0 0x0 0x0 0x40000000>;
>>>> +     };
>>>> +
>>>> +     reserved-memory {
>>>> +             #address-cells = <2>;
>>>> +             #size-cells = <2>;
>>>> +             ranges;
>>>> +
>>>> +             /* 52 MiB reserved for ARM Trusted Firmware */
>>> That's a lot of memory to blindly reserve.
>>> Any chance we can stop doing that and have u-boot amend reserved memory
>>> zone based on the actual needs of the device ?
>> Yes. U-boot will change size of reserved memory base on actual usage.
> 
> Then u-boot should add (not change) the memory if necessary.
> Please drop this.
> 
Amlogic's u-boot will change the reserved memory size, size is not an 
issue. But Some one use u-boot himself not Amlogic's, If here drop this, 
there is a strange problem when it runs.
>>>
>>>> +             secmon_reserved:linux,secmon {
>>>> +                     compatible = "shared-dma-pool";
>>>> +                     no-map;
>>>> +                     alignment = <0x0 0x400000>;
>>>> +                     reg = <0x0 0x05000000 0x0 0x3400000>;
>>>> +             };
>>>> +     };
>>>> +};
>>>> +
>