Received-SPF: pass (google.com: domain of linux-kernel+bounces-104179-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
Date: Fri, 15 Mar 2024 09:56:44 +0100
From: Dragan Simic <dsimic@manjaro.org>
To: Himanshu Bhavani <himanshu.bhavani@siliconsignals.io>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, Conor Dooley
 <conor+dt@kernel.org>, Heiko Stuebner <heiko@sntech.de>, Lorenz Brun
 <lorenz@brun.one>, devicetree@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: add &gmac2phy in rk3328-rock64
In-Reply-To: <20240315084018.2200581-1-himanshu.bhavani@siliconsignals.io>
References: <20240315084018.2200581-1-himanshu.bhavani@siliconsignals.io>
Message-ID: <96a53f8560b3563328eaf7b9d6f63d87@manjaro.org>
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit

Hello Himanshu,

On 2024-03-15 09:40, Himanshu Bhavani wrote:
> Add '&gmac2phy' node to enable ethernet1 on rk3328-rock64
> 
> Signed-off-by: Himanshu Bhavani <himanshu.bhavani@siliconsignals.io>
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
> b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
> index 229fe9da9c2d..cb919367db54 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
> @@ -12,6 +12,7 @@ / {
> 
>  	aliases {
>  		ethernet0 = &gmac2io;
> +		ethernet1 = &gmac2phy;
>  		mmc0 = &sdmmc;
>  		mmc1 = &emmc;
>  	};
> @@ -392,3 +393,7 @@ &vop {
>  &vop_mmu {
>  	status = "okay";
>  };
> +
> +&gmac2phy {
> +	staus = "okay";
> +};

Unfortunately, this isn't an acceptable change to the Rock64 dts file.
Yes, there's the second built-in Ethernet interface in the RK3328 SoC,
but the Rock64 layout doesn't expose it as a separate physical network
interface, i.e. it isn't available as a port.

Such a change would be fine to be applied to the dts by hand, by someone
who actually adds a second physical network port to their Rock64.