Received-SPF: pass (google.com: domain of linux-kernel+bounces-104197-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <4cd04119-8a93-4304-b1ce-88110788c8ef@criteo.com>
Date: Fri, 15 Mar 2024 10:17:54 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 iwl-net] i40e: Prevent setting MTU if greater than MFS
Content-Language: en-US
To: Tony Nguyen <anthony.l.nguyen@intel.com>, Brett Creeley
 <bcreeley@amd.com>, Erwan Velu <erwanaliasr1@gmail.com>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>,
 "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>,
 Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
 intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20240313090719.33627-2-e.velu@criteo.com>
 <4e203331-62f7-44e7-acd9-f684c30662de@amd.com>
 <c0ccaef6-44eb-4851-b336-cdb06647e1d2@criteo.com>
 <d16ff01c-4a01-4871-93de-a5c26a352301@amd.com>
 <7b612db6-cec6-4873-8a38-fb4c97192aa2@criteo.com>
 <8f4724f8-e831-12f6-d4e1-4700ea47b2a0@intel.com>
From: Erwan Velu <e.velu@criteo.com>
In-Reply-To: <8f4724f8-e831-12f6-d4e1-4700ea47b2a0@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dGM2WW82Y1hDeWVNdS9OSldCWHlUc2lUWDFQcndESTJ1Tnl5WE9jSlJiWGpr?=
 =?utf-8?B?NnhMc1g5eGxuak1xUmhwckVnWHZ4KzdrK2NRalBDWmtmcmxFZzZ1TXdHL2Fm?=
 =?utf-8?B?Um5ud3VIbDREZ3dwSkdyRVFzQ0p3UktpWFFHREFBMllUY2VwY3RabkxFajhR?=
 =?utf-8?B?QXR4OThkcCt4TzFzbXE5ZUl6WUtVeWZOcjBlQkNRRkxLWU9LMXNTZHBOZXF4?=
 =?utf-8?B?clhOQzNkemNkN1R2VE1aM0VLc3RzK0JXaVBPWm1OSHdubmJIcjNmdEFYNERM?=
 =?utf-8?B?cTNrNFdud25MRDZaYy91TU13MUp0U3pvejBsalJ4ZWtqdElydlhxQjBlRTRh?=
 =?utf-8?B?QWYyTEU5SW1xeS9SRVJXSEhSNFlEOGRETFQ3N0ZZWE1TaFlBaC90QWErNm1I?=
 =?utf-8?B?ampQbjd1VnV0NzJZY2UybmRLUHZuQ01hZElLbnJBSkhtSm9KT21acE9vUXlz?=
 =?utf-8?B?WFJjWUZPbHQvUUMwbzZLQzNsWlFDd0huTXArRGdMUTB6OUdTWkFmdWd3US93?=
 =?utf-8?B?TjdsSVlldWlkYW9rOWpoSzJlbzc0UkVqck1BZ1prTU5CZ3ZpS0VkMnJ2NUls?=
 =?utf-8?B?M1M0OEs3ckpmNzF0b0p3UDliVlp5TmFPcU9Ed0dKc0dLdjdLaURZMFJzSW5Y?=
 =?utf-8?B?L3k3VXplWHlmVlFyOXVvQndoWTN5QmZtbHdHaHBiVU1DakkrMmk0RXlVVTVn?=
 =?utf-8?B?N3B6SENMZ29sd01MT1dBTzlLcHRURmFkdEs0V2JuZVE3ck1vNkwyRjRxRjRZ?=
 =?utf-8?B?SjdmOUJPWGxYYWU2bmhmbTJhWmRzRTA4ajNnQmFTZWJMREQxdDBWZUZyL2VM?=
 =?utf-8?B?VEIrblpTNDZ3L01Kck1naDlXTzBpMVhpZlZ1WlF5N3R1ek85Ynd3cjdSTXR1?=
 =?utf-8?B?Q213VHJ2TFN1UXozMms4aExMbElTR1pnU1hlWDRuOWhNMnFuQVBCMG52dXA2?=
 =?utf-8?B?N09sSWl2ZlF4Q0NDcEdrampOZ3ZoNnF1NEVkYTh6Z1N4N0QxVEo3UytkNGNV?=
 =?utf-8?B?bTdpTm5sRnM2OFQxU3FTb3MvcURoMEMydTlEZE9Mbi9yMVorQ1BZMFFOTE81?=
 =?utf-8?B?alBpYUtsendBWWZWc3p3WTVYYlBIWWNWUGZjZFNJU0UvazN2enB2OXdHUnUw?=
 =?utf-8?B?Um5aZ1RVRGdGQ2Vkb05KYVhRVk9NVWJXMjVHUkV1UzZuWGdxbFpVYmljNmY5?=
 =?utf-8?B?OGs1UTdqMXlDNlFrekxPNTlYUGo3b0R4MjlITEw5QzZZV25DcXBZdVBsMUVk?=
 =?utf-8?B?OUp0NmpXR0x1NE9helRIWjNuakpNM3lhUHFRbmVIR0I0cmJJckVCVWFEVVJS?=
 =?utf-8?B?UUU2VGpORU54c3pnWjNpQWl5QUtlMEpJWEVIOXRHbzRTSStCbGUwWUZkZktu?=
 =?utf-8?B?QUNpSENLM0lYdGczRVY3NWhGdStGME0zc2tFR2NkaGJZa0RQTUhzMXBqNFp6?=
 =?utf-8?B?c2czN2NpYzI0b3lYYndjVHltU1cwU0F4Z2V3WnlXMzh3VGdvNStDZ2lSOUgy?=
 =?utf-8?B?SGliNVE1U3RJOTVHMm5yZmJxamRhTFF2ZlZCdzE3NWRranBXeEZnRktqK0NN?=
 =?utf-8?B?SVZ2clE0N2dHNHFQd0hDTm5xUUR2NURjeXhuRy93Rzh0K3dBblZCS09NN05F?=
 =?utf-8?B?bjh4dXdEeFVqRGtSSXA3bGR4Z3liWkxSQzNlNFg3Y1BWN2MxT2FIRWMrQmxH?=
 =?utf-8?B?OWo2d3E1bmtXcmswSUpSWnRNbCtEOXNIbU1nbmxvZzRibFZZaGIyK2FrNVl4?=
 =?utf-8?B?cGRKYXZVRitSdmVVZ1FaQ2NhVmRDRlhLRG5LUnB0NGlVeGFKaDF0MVZJaFRm?=
 =?utf-8?B?ZkY4TFdTS1Vsc2pUeDhoZGhOdUh3cHlSaXpzOWJEeXBldmdERmhmZXM5eEVw?=
 =?utf-8?B?QzJ6MlFqdlhxY1RINEdNRlJDQVBnMXVOV2VlbnhoNmhUM3Rpckh6OTJxWWIv?=
 =?utf-8?B?NUVsaTQwaDk4enBnWFo2Y2tQUGxwdzNvKzlLUEJocmh5OERXTU50d3diOHVx?=
 =?utf-8?B?ajIyeWlSbmdHYUNTOWJwVnZ2MU14QU9rYTJ0dlRGSnVrbzM4TFU2NGl3OUs1?=
 =?utf-8?B?VExFQzBmbi9MVGVUSitBYXMzT0ZNRkNLOUgxNnlsWjVDZ2d0ZHVHL1ExK3Nh?=
 =?utf-8?B?K0NqY0pVTzJML0ZLN2FHNXV6aURFQ0dFUlBsTkhudURKYkdMbGdGektKNzZN?=
 =?utf-8?Q?oJPJonkULuT3iaexW6dp8C5X7vK0b61/e+etp1MlEk3Z?=
X-OriginatorOrg: criteo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f2e65f96-9559-4e1b-5ce7-08dc44d0cc9e
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8989.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2024 09:17:55.7725
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 2a35d8fd-574d-48e3-927c-8c398e225a01
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DV19MAaeRuOSlBz0UFoPG+bQC+A5YkugwH0lmzHS3z4jmjA+ZVdXITjxGvLAeOv4RkBRjgUZfnxJCXe9X/5EdA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7351


Le 14/03/2024 à 21:31, Tony Nguyen a écrit :
> [..]
> Setting the mfs size to max values during init and reset would better; 
> this is what the ice driver does. However, this would take 
> implementing new AdminQ calls. IMO this patch is ok to prevent the 
> issue being reported and allow for ease of backport.
>
That was my first intention, ensure that no one else get stuck in the 
same situation.

It would be nice to backport it to all stable releases once merged.

Erwan,