Received-SPF: pass (google.com: domain of linux-kernel+bounces-104227-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Xu Yang <xu.yang_2@nxp.com>
To: Frank.li@nxp.com,
	will@kernel.org,
	mark.rutland@arm.com,
	robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org,
	shawnguo@kernel.org,
	s.hauer@pengutronix.de,
	kernel@pengutronix.de,
	festevam@gmail.com,
	john.g.garry@oracle.com,
	jolsa@kernel.org,
	namhyung@kernel.org,
	irogers@google.com
Cc: mike.leach@linaro.org,
	peterz@infradead.org,
	mingo@redhat.com,
	acme@kernel.org,
	alexander.shishkin@linux.intel.com,
	adrian.hunter@intel.com,
	linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-perf-users@vger.kernel.org,
	imx@lists.linux.dev
Subject: [PATCH v7 5/8] perf: imx_perf: fix counter start and config sequence
Date: Fri, 15 Mar 2024 17:55:52 +0800
Message-Id: <20240315095555.2628684-5-xu.yang_2@nxp.com>
In-Reply-To: <20240315095555.2628684-1-xu.yang_2@nxp.com>
References: <20240315095555.2628684-1-xu.yang_2@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?or0MEic+zaLUwPBTk9ypcJTEg+jIusZMoTY6cnivkSHfOlll8jWn+SEbzFCV?=
 =?us-ascii?Q?WBzJl3H4Zrh5b8QndPdD00OEBnOwh5e06L+uz8+AtG5FvU6QOIbwoFXVgsD5?=
 =?us-ascii?Q?/tBZN74Zj4b41SxkBxbYsMVE7KFm53AqANtevxSnB0hF4yU5MTH2GdBAsplI?=
 =?us-ascii?Q?CZuP3ddpjoZVwXy0Bjb3Kh76166Ak9kJjvpr2Xa+pSGDEEdhVmLbDsU4O7r4?=
 =?us-ascii?Q?/njwj64xAijkGOsoq8ob0RMY9+z9QrWGmEGPIjNdQdLiQBvUgwFbKgneU5T9?=
 =?us-ascii?Q?uRiSl0+9u3qEZ6zmyWqoeLaPA7NVD1vfeCyXEqhQtEF4weRJvNVCCbncDijY?=
 =?us-ascii?Q?IRBs4ZL6OSG/wPA1ptFDnaKf/CMB0QyR+dePS16Iw/5Lh+xcgbsf0eEFmWXQ?=
 =?us-ascii?Q?Y+4L+SC/j/zV15dcdIALFhLG/l2sK7C7hBVb4ozL/EDLxgftsnWN5UKg30Hg?=
 =?us-ascii?Q?CaT9PHrCS1eA8AOjSOQz6qT5sMkkUvjvSEZZzLHhWqbgBKAf7EQHZKoQ+5kr?=
 =?us-ascii?Q?IJ3msgZK9COtWo77LJy/onX9jIEA/kRIMph5yeWtnphxw9AijkALYWELhs1Q?=
 =?us-ascii?Q?Fc6fHSAy7+9s+bJXKUztpJ/9xp+cyvXkUeMpCTPJDlpd0g51/ZqSLgXozYOE?=
 =?us-ascii?Q?7Ywexu8etsXJvyatF7Lr1lmSCtFivLtuVW9bzT1NZ90pns2DXlkYeZoPsu5o?=
 =?us-ascii?Q?6iyHFeh10S5eqWYO6DiCyWwuCpj83beIkvwpzqQYHh6iiLxef63PmgTfUVh9?=
 =?us-ascii?Q?3f3KZWOHgawrnuJA43/0REG/Fk31vRdRFO4R5TEp4hLSsu+f+MGrVClyErqF?=
 =?us-ascii?Q?5R/lVh017lV4TQAXfvW7VADq/LXVgVBgD4FeMtvipt1Cq9OSaebmtRpF6OlQ?=
 =?us-ascii?Q?LhX5CSR2sr+yze8D0Vr9qyd+v/JlGGeuilvKgqDEMEJWrim7/9D77a+Hplqy?=
 =?us-ascii?Q?8n5oJf2um41J9EjdmRYkBTW+/zpsMUtAAsPHkZle/YLVtwX8eBhseeHdWhUj?=
 =?us-ascii?Q?dXQdYhkOWRsuIbF7nANeuTCddW1Nol2sBcT7bI5X8rdC3lA76jAJl9jqvnxi?=
 =?us-ascii?Q?SgWqcPPARHNeFbsJWDRrvcHcrZvmAqghaRUbesACNGwCciyW3pq4PzMC9u7V?=
 =?us-ascii?Q?hLtd4/FuRU5ZWlnVxjKjswTjxbB5LS0/3rDV0WoY7cI99VXlhrPepyFHnt/9?=
 =?us-ascii?Q?mF6CdbCJVIaaWqkIo4k9HtkZhr5jcj6wRWneYn/J0L2sVbJezG9RSFNo5Q3G?=
 =?us-ascii?Q?1LJ7CXuCQ4BPIS99/aVW3AypGY1+42hVsh7FVGZCWCupDIcb348+sM5F5FIR?=
 =?us-ascii?Q?yQNpYZMbnaATQTYVWkJ3OUzHIGKgd6VokT4GkXVMErbtrCbdxEJJzQye8jxX?=
 =?us-ascii?Q?c4fXBuLnDLEyMu5S0SvoxEsL5h9mOWdW0zr5tfwSLz+Bm9/pEmrUsnY3fO8P?=
 =?us-ascii?Q?CruDlXKj5Yi/1KVapXi36BH6YsPIi1mWXlQsoxS4k5fzCc6Ye+gdYIls51YZ?=
 =?us-ascii?Q?AVX2yNFimqLLqO/S3UyiArMhK2iaNxMje/+zWIGKZ1gIujnIrJ0QuF3Kn0h3?=
 =?us-ascii?Q?50PoAz8cbMbo8MuUT4GeK4pZYQZZcvsWyJY0188w?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a3dea5f9-a52a-4bee-7f58-08dc44d6249d
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8822.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2024 09:56:11.0562
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tDyDUqf9MU9HPj82dB3t8p3B0EbAUSQDOE85hg57FLhjkNj2PbrI5fYhg0ftxrt+LteNQDgzuPPKunRYt0hUpA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7444

In current driver, the counter will start firstly and then be configured.
This sequence is not correct for AXI filter events since the correct
AXI_MASK and AXI_ID are not set yet. Then the results may be inaccurate.

Signed-off-by: Xu Yang <xu.yang_2@nxp.com>

---
Changes in v5:
 - new patch
Changes in v6:
 - no changes
Changes in v7:
 - no changes
---
 drivers/perf/fsl_imx9_ddr_perf.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/perf/fsl_imx9_ddr_perf.c b/drivers/perf/fsl_imx9_ddr_perf.c
index 5537f4e07852..c99c43b214cb 100644
--- a/drivers/perf/fsl_imx9_ddr_perf.c
+++ b/drivers/perf/fsl_imx9_ddr_perf.c
@@ -523,12 +523,12 @@ static int ddr_perf_event_add(struct perf_event *event, int flags)
 	hwc->idx = counter;
 	hwc->state |= PERF_HES_STOPPED;
 
-	if (flags & PERF_EF_START)
-		ddr_perf_event_start(event, flags);
-
 	/* read trans, write trans, read beat */
 	imx93_ddr_perf_monitor_config(pmu, event_id, counter, cfg1, cfg2);
 
+	if (flags & PERF_EF_START)
+		ddr_perf_event_start(event, flags);
+
 	return 0;
 }
 
-- 
2.34.1