Received-SPF: pass (google.com: domain of linux-kernel+bounces-104250-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 15 Mar 2024 11:14:30 +0100
Message-ID: <87wmq3by49.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: syzbot <syzbot+28c1a5a5b041a754b947@syzkaller.appspotmail.com>
Cc: linux-kernel@vger.kernel.org,
	linux-sound@vger.kernel.org,
	perex@perex.cz,
	syzkaller-bugs@googlegroups.com,
	tiwai@suse.com
Subject: Re: [syzbot] [sound?] possible deadlock in snd_pcm_period_elapsed (4)
In-Reply-To: <0000000000000b9a510613b0145f@google.com>
References: <0000000000000b9a510613b0145f@google.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
Precedence: bulk
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII

On Fri, 15 Mar 2024 11:00:31 +0100,
syzbot wrote:
(snip)
> the shortest dependencies between 2nd lock and 1st lock:
>  -> (&timer->lock){+.+.}-{2:2} {
>     HARDIRQ-ON-W at:
>                       lock_acquire+0x1e4/0x530 kernel/locking/lockdep.c:5754
>                       __raw_spin_lock include/linux/spinlock_api_smp.h:133 [inline]
>                       _raw_spin_lock+0x2e/0x40 kernel/locking/spinlock.c:154
>                       spin_lock include/linux/spinlock.h:351 [inline]
>                       class_spinlock_constructor include/linux/spinlock.h:561 [inline]
>                       snd_timer_close_locked+0x53/0x8d0 sound/core/timer.c:412

Ouch, I incorrectly converted from spin_lock_irq() to
guard(spinlock).  It should have been guard(spinlock_irq), of course.

Will submit the fix patch.


thanks,

Takashi