Received-SPF: pass (google.com: domain of linux-kernel+bounces-104271-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 15 Mar 2024 11:32:43 +0100
From: Andrejs Cainikovs <andrejs.cainikovs@toradex.com>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: Andrejs Cainikovs <andrejs.cainikovs@gmail.com>,
	patches@opensource.cirrus.com, linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>
Subject: Re: [RFC PATCH v1] ASoC: wm8904: enable fll with fixed mclk
Message-ID: <ZfQjywL8r+egtG7V@toradex.com>
References: <20240308155831.141229-1-andrejs.cainikovs@gmail.com>
 <Ze7smWSeoCVIcxIo@ediswmail9.ad.cirrus.com>
 <ZfBG9IMFEjjIdgdi@toradex.com>
 <ZfBdxrzX3EnPuGOn@ediswmail9.ad.cirrus.com>
In-Reply-To: <ZfBdxrzX3EnPuGOn@ediswmail9.ad.cirrus.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IZZzzHVt3rj3IdpFghaNTxQbB2bCozuF9ra6nAJPDevWrctZSPSl1yMEZBVL?=
 =?us-ascii?Q?Fjq2+vGTUc5DizAzYkEzOcBenFBVwuJZBu5uAyU8PxKeTcWDmA0nB9Sf+tV/?=
 =?us-ascii?Q?5UR9ioaq//80q/s7vceC6i28murIeNB0To5ABkVETQnAar8nHMktwlBmnTPY?=
 =?us-ascii?Q?0rzXzpf8lZH1UkIZImXgd/v/r0k+cw3ZSSWcLfN0G3Mge8TZbHCuf7/IZnGp?=
 =?us-ascii?Q?7d06rwJ3EkTAiWdq0vER6FyFl2bXyXBmxM5lmEbUibl2+E7GWIvvMJSSfrGY?=
 =?us-ascii?Q?UENZTnXH2xuLMswcvivnbOi8+EO5Zy9tM+VXIipIXB6AE43KRQi00y4nXe1O?=
 =?us-ascii?Q?B+569OuZN8ZJ4s4FV29yfUdnMbe/iBkCSwrxL9xImPX9AIT4jbyTk3aIGjdV?=
 =?us-ascii?Q?oeEfFsCArwk1+bEYd8bkkNuAnglTLix6oeBiJOpRaLTw6+iw2XpLfqW+Jgz7?=
 =?us-ascii?Q?jk3lx/iibeb17QK9WOL9zFYPlvR/k6Rd40uht+cuqf5BVtKNUr4yqKqvgy5c?=
 =?us-ascii?Q?EUk46Dhm+oXVbFq8tEplTi8/L3EPOEwAfy8TUMI9eQTg20cX11YBrPFuRQ7n?=
 =?us-ascii?Q?sXmS/zWFb75dqCvPPCYfQW6TJuEFRQIAQbtiMpS6e/efuoNeIOnQ1mk+xEGB?=
 =?us-ascii?Q?zke7N5Uq6IIsVeB8wEFV+Vjjr+ksjH/wS4mieTo9ZFBW61R/V1GETlT9VUqy?=
 =?us-ascii?Q?6obsodVnkFirqnz9KAXv0CBAsPfvWeQJOqgV++7CyGCYAUX51A1ySZ+6EHMO?=
 =?us-ascii?Q?uMMxmXPAiAJTH4s8ifWPbBLwuiHz3dyAmdvz0YM5FrlJyaH8CJ2Wyq5Qo7ix?=
 =?us-ascii?Q?4/8c566rMb3M2dpUY4jcbUivSlHGrOR0zkK/8DfT1XTyxyjnX7990nDDnhlz?=
 =?us-ascii?Q?3MH3ATWbYSoN7Rai/ooqovTHIxkRliX9dUEmhCcNy7ywDfyyxOyd4D44SRW4?=
 =?us-ascii?Q?xMJLUTHFHF6WXVBx48npn3jwyheOHSXmDgTBZFlO5+F307puQpM9rSN3J+aA?=
 =?us-ascii?Q?TgMfPrdu3bbV/X/t9SGruDU+c0jYf+GKkr3W6zf/bGNtwbxWKA8tabSlMlfw?=
 =?us-ascii?Q?GBoFx7aSv4P08q0HStEtIxBkUwaJbSFVkKHcu6p8MkuqeMBQZ6iWR6o9aXsM?=
 =?us-ascii?Q?rTeOI0D0KLPtYf/Z8OrzvZqZMpL+t9BRK1Q54qFkB9x1MIOZeF2h9pEgGZSk?=
 =?us-ascii?Q?uaYIeIBVYfZ9z4n/+lgvzU8Esznn7sivseTdqhgx/61/6ccu+Sn+SEYoekbb?=
 =?us-ascii?Q?RY5LwF4yq1p8nN6kAb0B2PbKQQ6mFyAoxVaMrv7rY5yU+uVDXgtMcsrsDb3J?=
 =?us-ascii?Q?OY1ROqYD01bDJredVO6mjIuk4E5kqTG88lQim7avFlPw33wYh2q96DQvgSf9?=
 =?us-ascii?Q?JTpG9c90weZ1OvAMwnl3twe5Jr6/URMZrpgpTSiwDYR5zYn24IrA5fcky41J?=
 =?us-ascii?Q?h7ILc1M6hfualBnf6EzJENXuJI/KPHsYBy7Ow3UVDogGy9kQgAmU3edtBtN2?=
 =?us-ascii?Q?smIYMJHRkQzwEK0lcr1AKjDirHE10qcxRzUL4ww12ZnFUO5ctkDNF8D14ZM7?=
 =?us-ascii?Q?NgDUR1O9sPFbvS2fmw58+gQA+XnFSYFwpzoNVp3ZXOeAwKHko/O+qpBBZqzk?=
 =?us-ascii?Q?Aw=3D=3D?=
X-OriginatorOrg: toradex.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f12a33e0-46c4-4468-bd79-08dc44db40f7
X-MS-Exchange-CrossTenant-AuthSource: ZRAP278MB0254.CHEP278.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2024 10:32:45.9836
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: d9995866-0d9b-4251-8315-093f062abab4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: W04d1rrPbFNberYzyvWaZuDtiA1ozO7msQRlXWi6PipT9jMibbbJnhJeeomzJNJALZhvDdNxeuLPstsytF8bgeXe4kmvCIjrqjaY4Nf7bP0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV0P278MB0949
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: toradex.com
Content-Type: text/plain; charset=WINDOWS-1252
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 12, 2024 at 01:51:02PM +0000, Charles Keepax wrote:
> Ah, ok I see what I was missing here. simple_card_utils calls
> clk_set_rate if you specify mclk_fs. Which you don't want in this
> case. My gut reaction is that really the problem here is the machine
> driver doesn't support the clocking setup you have.
>=20
> Having a quick look through the simple card stuff can you remove:
>=20
> =09clocks =3D <&audio_refclk1>;
>=20
> From the machine driver DT stuff, and add mclk-fs. I think that
> should cause the simple card to call the codec dai_set_sysclk
> but without ever touching the audio_refclk. A small change in
> simple_util_parse_clk might also be needed to allow it to return
> without finding a clock. Which feels like a much simpler and less
> scary change.

Thanks for your help, Charles. Your suggestion works as expected.
Btw, there was no need to touch simple_util_parse_clk as it does
allow to return without finding a clock.

Best regards,
Andrejs.

> My only slight reservation is the automatic clocking thing only
> really exists as a hack to support simple card anyway. But overal
> I think it might be better to try to move the direction of travel
> more to adding support for the clocking systems that exist into
> simple-card rather than tweaking the codec driver to work around
> it.
>=20
> Thanks,
> Charles