Received-SPF: pass (google.com: domain of linux-kernel+bounces-104329-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 15 Mar 2024 12:23:14 +0100
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Maxim Korotkov <korotkov.maxim.s@gmail.com>
Cc: Boris Brezillon <bbrezillon@kernel.org>, Richard Weinberger
 <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>, Hector Palacios
 <hector.palacios@digi.com>, linux-mtd@lists.infradead.org,
 linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org
Subject: Re: [PATCH] mtd: rawnand: hynix: fixed typo
Message-ID: <20240315122314.10c88c2e@xps-13>
In-Reply-To: <20240313102721.1991299-1-korotkov.maxim.s@gmail.com>
References: <20240313102721.1991299-1-korotkov.maxim.s@gmail.com>
Organization: Bootlin
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Maxim,

korotkov.maxim.s@gmail.com wrote on Wed, 13 Mar 2024 13:27:20 +0300:

> The function hynix_nand_rr_init() should probably return an error code.
> Judging by the usage, it seems that the return code is passed up=20
> the call stack.
> Right now, it always returns 0 and the function hynix_nand_cleanup()
> in hynix_nand_init() has never been called.

Isn't it done like that on purpose? Read-retry is not a mandatory
feature.

> Found by RASU JSC and Linux Verification Center (linuxtesting.org)
>=20
> Fixes: 626994e07480 ("mtd: nand: hynix: Add read-retry support for 1x nm =
MLC NANDs")
>=20
> Signed-off-by: Maxim Korotkov <korotkov.maxim.s@gmail.com>
> ---

Thanks,
Miqu=C3=A8l