Received-SPF: pass (google.com: domain of linux-kernel+bounces-104347-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: "Shradha Todi" <shradha.t@samsung.com>
To: "'Stephen Boyd'" <sboyd@kernel.org>, "'Dan Carpenter'"
	<dan.carpenter@linaro.org>
Cc: <linux-clk@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-pci@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
	<linux-samsung-soc@vger.kernel.org>, <mturquette@baylibre.com>,
	<jingoohan1@gmail.com>, <lpieralisi@kernel.org>, <kw@linux.com>,
	<robh@kernel.org>, <bhelgaas@google.com>, <krzysztof.kozlowski@linaro.org>,
	<alim.akhtar@samsung.com>, <linux@armlinux.org.uk>,
	<m.szyprowski@samsung.com>, <manivannan.sadhasivam@linaro.org>,
	<pankaj.dubey@samsung.com>, <gost.dev@samsung.com>
In-Reply-To: <9927a3356ce54c626ab4733844a4385b.sboyd@kernel.org>
Subject: RE: [PATCH v6 1/2] clk: Provide managed helper to get and enable
 bulk clocks
Date: Fri, 15 Mar 2024 17:04:44 +0530
Message-ID: <104401da76cc$ccc772c0$66565840$@samsung.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQH2hJCcwYDjJDqbclltz640cKP7jQL/AcmgAaOboDkDexFUCAD2UfeNAfilKBWwqCa/4A==
Content-Language: en-in
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <20240220084046.23786-1-shradha.t@samsung.com>
	<CGME20240220084120epcas5p1e8980539667c3d9da20f49fc645d8f4c@epcas5p1.samsung.com>
	<20240220084046.23786-2-shradha.t@samsung.com>
	<f00eed31-4baf-4d5c-934d-8223d1ab554d@moroto.mountain>
	<022301da6fbf$aae4f7e0$00aee7a0$@samsung.com>
	<9927a3356ce54c626ab4733844a4385b.sboyd@kernel.org>


> -----Original Message-----
> From: Stephen Boyd <sboyd=40kernel.org>
> Sent: 09 March 2024 06:21
> To: 'Dan Carpenter' <dan.carpenter=40linaro.org>; Shradha Todi
> <shradha.t=40samsung.com>
> Cc: linux-clk=40vger.kernel.org; linux-kernel=40vger.kernel.org; linux-
> pci=40vger.kernel.org; linux-arm-kernel=40lists.infradead.org; linux-sams=
ung-
> soc=40vger.kernel.org; mturquette=40baylibre.com; jingoohan1=40gmail.com;
> lpieralisi=40kernel.org; kw=40linux.com; robh=40kernel.org; bhelgaas=40go=
ogle.com;
> krzysztof.kozlowski=40linaro.org; alim.akhtar=40samsung.com;
> linux=40armlinux.org.uk; m.szyprowski=40samsung.com;
> manivannan.sadhasivam=40linaro.org; pankaj.dubey=40samsung.com;
> gost.dev=40samsung.com
> Subject: RE: =5BPATCH v6 1/2=5D clk: Provide managed helper to get and en=
able bulk
> clocks
>=20
> Quoting Shradha Todi (2024-03-06 04:13:03)
> > >
> > > When clk_bulk_get_all() returns zero then we return success here.
> > >
> >
> > Yes, we are returning success in case there are no clocks as well. In
> > case there are no clocks defined in the DT-node, then it is assumed
> > that the driver does not need any clock manipulation for driver
> > operation. So the intention here is to continue without throwing
> > error.
>=20
> Maybe we shouldn't even return the clks to the caller. Do you have any us=
e for
> the clk pointers?

The intention to return the clk pointers was in the case where caller wants=
 to
manipulate a particular clock in certain conditions. They can obtain the cl=
ock pointer
and use clk_set_parent, clk_set_rate on those particular clocks.
But I understand that in that case users can use existing clk_bulk_get_all(=
) API.
So, should I go ahead and send v7?