Received-SPF: pass (google.com: domain of linux-kernel+bounces-104380-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <baed1e49-d854-4517-8219-2a5bb0b3cd1b@huawei.com>
Date: Fri, 15 Mar 2024 20:10:05 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH-next v3] arm32: enable HAVE_LD_DEAD_CODE_DATA_ELIMINATION
Content-Language: en-US
To: Arnd Bergmann <arnd@arndb.de>, Ard Biesheuvel <ardb@kernel.org>
CC: <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>, Russell King
	<linux@armlinux.org.uk>, Andrew Davis <afd@ti.com>, Andrew Morton
	<akpm@linux-foundation.org>, "Kirill A. Shutemov"
	<kirill.shutemov@linux.intel.com>, Geert Uytterhoeven
	<geert+renesas@glider.be>, Jonathan Corbet <corbet@lwn.net>, Mike Rapoport
	<rppt@kernel.org>, Rob Herring <robh@kernel.org>, Thomas Gleixner
	<tglx@linutronix.de>, Linus Walleij <linus.walleij@linaro.org>, Fangrui Song
	<maskray@google.com>
References: <20240315063154.696633-1-liuyuntao12@huawei.com>
 <CAMj1kXH+FaddHV5--kqB_wVgw_M682MvchPB1BoCuDuA6vVyvg@mail.gmail.com>
 <d7a1996f-f558-4cea-b8ca-eb071d02c6d4@huawei.com>
 <CAMj1kXHP-M7hTsCmorgzvDiPB1jRXHciJrXjJR82zmkxUTD-5Q@mail.gmail.com>
 <b3e3f664-f8ad-41d7-b8d5-3c83818ff489@huawei.com>
 <d91cf190-e583-422f-884d-79552b674f72@app.fastmail.com>
From: "liuyuntao (F)" <liuyuntao12@huawei.com>
In-Reply-To: <d91cf190-e583-422f-884d-79552b674f72@app.fastmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit


On 2024/3/15 19:51, Arnd Bergmann wrote:
> On Fri, Mar 15, 2024, at 12:48, liuyuntao (F) wrote:
>> On 2024/3/15 18:46, Ard Biesheuvel wrote:
>>> @@ -28,6 +28,7 @@
>>>                                      -DEFI_HAVE_MEMCHR -DEFI_HAVE_STRRCHR \
>>>                                      -DEFI_HAVE_STRCMP -fno-builtin -fpic \
>>>                                      $(call cc-option,-mno-single-pic-base)
>>> +cflags-$(CONFIG_ARM)           := $(filter-out -fdata-sections, $(CFLAGS-y))
>>>    cflags-$(CONFIG_RISCV)         += -fpic -DNO_ALTERNATIVE -mno-relax
>>>    cflags-$(CONFIG_LOONGARCH)     += -fpie
>>
>> Another error:
>> cannot initialize array of ‘short unsigned int’ from a string literal
>> with type array of ‘unsigned int’
>>    17 | static const efi_char16_t shim_MokSBState_name[] = L"MokSBStateRT";
> 
> The line sets cflags-y to an empty string.
> 
> It probably should have been
> 
> cflags-$(CONFIG_ARM)           := $(filter-out -fdata-sections, $(cflags-y))
> 
> (small cflags instead of CFLAGS).
> 
>       Arnd

Oh, my mistake, after fixed this bug, still this error:
> arm-linux-gnueabi-ld: warning: orphan section `.data.efi_loglevel' from `drivers/firmware/efi/libstub/printk.stub.o' being placed in section `.data.efi_loglevel'
> arm-linux-gnueabi-ld: warning: orphan section `.data.screen_info_guid' from `drivers/firmware/efi/libstub/screen_info.stub.o' being placed in section `.data.screen_info_guid'
> arm-linux-gnueabi-ld: warning: orphan section `.data.cpu_state_guid' from `drivers/firmware/efi/libstub/arm32-stub.stub.o' being placed in section `.data.cpu_state_guid'
> arm-linux-gnueabi-ld: warning: orphan section `.data.efi_nokaslr' from `drivers/firmware/efi/libstub/efi-stub-helper.stub.o' being placed in section `.data.efi_nokaslr'

The -fdata-sections option is present in the KBUILD_CFLAGS_KERNEL 
variable; altering cflags-y only affect the KBUILD_CFLAGS variable.
It seems that the -fdata-sections option needs to be removed from the 
KBUILD_CFLAGS_KERNEL variable.
> ifdef CONFIG_LD_DEAD_CODE_DATA_ELIMINATION
> KBUILD_CFLAGS_KERNEL += -ffunction-sections -fdata-sections
> KBUILD_RUSTFLAGS_KERNEL += -Zfunction-sections=y
> LDFLAGS_vmlinux += --gc-sections
> endif