Received-SPF: pass (google.com: domain of linux-kernel+bounces-104384-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 15 Mar 2024 13:14:12 +0100
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Maxim Korotkov <korotkov.maxim.s@gmail.com>
Cc: Boris Brezillon <bbrezillon@kernel.org>, Richard Weinberger
 <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>, Hector Palacios
 <hector.palacios@digi.com>, linux-mtd@lists.infradead.org,
 linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org
Subject: Re: [PATCH] mtd: rawnand: hynix: fixed typo
Message-ID: <20240315131412.488167c1@xps-13>
In-Reply-To: <529774b9-20be-485d-b218-2452ce536770@gmail.com>
References: <20240313102721.1991299-1-korotkov.maxim.s@gmail.com>
	<20240315122314.10c88c2e@xps-13>
	<529774b9-20be-485d-b218-2452ce536770@gmail.com>
Organization: Bootlin
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Maxim,

korotkov.maxim.s@gmail.com wrote on Fri, 15 Mar 2024 14:45:47 +0300:

> Hi,
>=20
> On 15.03.2024 14:23, Miquel Raynal wrote:
> > Isn't it done like that on purpose? Read-retry is not a mandatory
> > feature. =20
>=20
> Works it as designed? I'm not sure about it.
> I wouldn't rule it out, but it's a little weird that the hynix_nand_rr_in=
it() function
> is used as if it can return an error but never returns.
>=20
> Probably  checking  of value returned from hynix_nand_rr_init()
> should be removed in hynix_nand_init()

It is indeed confusing. I'll take it.

Thanks,
Miqu=C3=A8l