Received-SPF: pass (google.com: domain of linux-kernel+bounces-104408-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Jianfeng Liu <liujianfeng1994@gmail.com>
To: heiko@sntech.de
Cc: conor+dt@kernel.org,
	devicetree@vger.kernel.org,
	ezequiel@vanguardiasur.com.ar,
	knaerzche@gmail.com,
	krzysztof.kozlowski+dt@linaro.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-media@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	liujianfeng1994@gmail.com,
	mchehab@kernel.org,
	p.zabel@pengutronix.de,
	robh+dt@kernel.org,
	sfr@canb.auug.org.au,
	sigmaris@gmail.com
Subject: Re: [PATCH v3 2/2] dt-bindings: media: rockchip-vpu: Add rk3588 vpu compatible string
Date: Fri, 15 Mar 2024 20:45:56 +0800
Message-Id: <20240315124556.2405143-1-liujianfeng1994@gmail.com>
In-Reply-To: <9414316.4vTCxPXJkl@diego>
References: <9414316.4vTCxPXJkl@diego>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Hi Heiko,

Fri, 15 Mar 2024 13:22:18 +0100, Heiko Stübner wrote:
>at least the rk3588 has multiple v{d/e{.}pu blocks, so this compatible
>is very misleading. As you mention in the commit description already,
>this describes the vdpu121, so can we please use that in the compatible
>as well to distinguish this one from the others that hopefully will come
>later?

Since vpdu121 is in both rk3568 and rk3588, maybe it's better to change
rk3568 as well. But rk3568-vpu has been in kernel for a long time so this
would be a big change. I will submit v4 with rockchip,rk3588-vdpu121.

Regards,
Jianfeng