Received: by 2002:ab2:2994:0:b0:1ef:ca3e:3cd5 with SMTP id n20csp764860lqb; Fri, 15 Mar 2024 06:06:42 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV13HC6K1JmkhEfShkxHLhs5F7dXvsuPziCafQV8ioIw5UQf5pWzOLVTYuIANp4WaKoGg99I4hjDo5QOYRlmq43KKwF8lwMSSXWIh9TCQ== X-Google-Smtp-Source: AGHT+IFPO68Pe5dbipvRwmzAXsjcotqPgXuP2h6mwrq2sqym5yZ2hMr9TNb8EdiX1OXJ1KlTZpwi X-Received: by 2002:a81:a9c4:0:b0:60a:2696:135b with SMTP id g187-20020a81a9c4000000b0060a2696135bmr5246336ywh.21.1710508002045; Fri, 15 Mar 2024 06:06:42 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710508002; cv=pass; d=google.com; s=arc-20160816; b=uGw+nAw0aANrEDjDEDYX4Lt+lHyvrwKL6cunNmVNiTQVIObCwglPDqm1n3MoWqujIe 5lgiq1X82tFjF684dx0xisF6GnRmuU3NuNudeeIRoXzAnLxVo/lkX9KjYa1m/VdTV8pk vGx+A7hwldnY8QwOMD855wbxLy0z6t7Jkn6vwZ3Zztdvh1Nzd99O+r6fgefHl8y1tZr6 0JkcxE6oxV54qULruJvx5edADBssyBXsbj7Y5owX3BnWXSRofdvFW0ut8kp7A/EP2dbp +vgVI1NotbuhwQMWNl+i7TeOhYI1wg9+qq3xEZNeSpdAvdr/s3B3Y1O0qufn7FIBEAWw 5j9Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=h0kmXpK9z8Cbb01imjKku9KrVFT23NuIbeSvNfonlgA=; fh=AnfS9oAU/3jO6q7PyKy7S8usacZxxEVwbLrZWr3/kxM=; b=hcxWPXiDDXfyzJuUiff+nSY33Qv3r6Rx6nfk8+fbn8vBkaqdfZLN/AzwTouLNjCYfd 21c1ImdUyIhM6V9U2EhyjkAoYO/EZ9DUK5dAlUEu3xZxPLqxlxe40LrOhuef+CUg4v95 CGNopBppBmhsdNWT4jXwghMDTi1jw6pAwy6DQBx6imZq1G5OxM93apbwX0hhDeK20rTP vV9hS6bWPFUxdwrBrg7TqgaUisFR0rwuBl0Cpi28Av1Yj9wfVPD4HyD0rc5lGEaiH88h Y7Ngjg8jwYU2e1NpuNy/Vq7uR3up0anVGddBLcLfiao4M6EEEcsQ7DtUs0wFGJWcEOCu oMrg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=sina.com); spf=pass (google.com: domain of linux-kernel+bounces-104433-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-104433-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id v6-20020a814806000000b0060a07c5b21bsi1624775ywa.390.2024.03.15.06.06.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Mar 2024 06:06:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-104433-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=sina.com); spf=pass (google.com: domain of linux-kernel+bounces-104433-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-104433-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 10C251C21394 for ; Fri, 15 Mar 2024 13:06:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 450312511E; Fri, 15 Mar 2024 13:06:29 +0000 (UTC) Received: from mail115-95.sinamail.sina.com.cn (mail115-95.sinamail.sina.com.cn [218.30.115.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B731E18624 for ; Fri, 15 Mar 2024 13:06:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=218.30.115.95 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710507988; cv=none; b=aCukTiBHy6Wt/idrCkOM2lM1shma0w3GAdKG6dvG3pOa0w1uMFe13AeCyc27Amyn0hvgGYyybiO9EsTk9FyzOvagZ/+U4qBnwjR5mPNmikMaVkwhyeG9ZgettVIipjnPheCDMZ+KMFowQON5bO0ulASCuz4Np9AI3Hii1OHVF/Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710507988; c=relaxed/simple; bh=yJudiLMA36Y3KxSoumkJPCVd40zRvl4KvkUR0jh4l5g=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=TcPJdxoZGhoE1wqgAQZs7IdUfczqjDNeNVqFbNSTB50FRdHqmsxN2mqfH4ltx2FQ3Bc72XBHORVQ8wjWMHSHFlXkz8VvC2Z7dur+I9t5Gv89TNnewGfwtRo1ppJG3R3T6xJ7eylUX6jExxiuu5SKVmqQclWeF26d7TQsrIIp+SE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sina.com; spf=pass smtp.mailfrom=sina.com; arc=none smtp.client-ip=218.30.115.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sina.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sina.com X-SMAIL-HELO: localhost.localdomain Received: from unknown (HELO localhost.localdomain)([116.24.10.95]) by sina.com (172.16.235.24) with ESMTP id 65F447BE00006E11; Fri, 15 Mar 2024 21:06:10 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com Authentication-Results: sina.com; spf=none smtp.mailfrom=hdanton@sina.com; dkim=none header.i=none; dmarc=none action=none header.from=hdanton@sina.com X-SMAIL-MID: 42060945089131 X-SMAIL-UIID: 1B503741C4CE417D9884D0A33183E19F-20240315-210610-1 From: Hillf Danton To: syzbot Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com, tiwai@suse.com Subject: Re: [syzbot] [sound?] possible deadlock in snd_timer_close_locked Date: Fri, 15 Mar 2024 21:05:58 +0800 Message-Id: <20240315130558.2420-1-hdanton@sina.com> In-Reply-To: <00000000000099d9850613b12348@google.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Fri, 15 Mar 2024 04:16:27 -0700 > syzbot found the following issue on: > > HEAD commit: fe46a7dd189e Merge tag 'sound-6.9-rc1' of git://git.kernel.. > git tree: upstream > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=13a304a5180000 #syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master --- x/sound/core/timer.c +++ y/sound/core/timer.c @@ -409,8 +409,9 @@ static void snd_timer_close_locked(struc struct snd_timer *timer = timeri->timer; if (timer) { - guard(spinlock)(&timer->lock); + spin_lock_irq(&timer->lock); timeri->flags |= SNDRV_TIMER_IFLG_DEAD; + spin_unlock_irq(&timer->lock); } if (!list_empty(&timeri->open_list)) { --